Commit graph

3959 commits

Author SHA1 Message Date
Peter Penz 894232ebda Places Panel: Show drop indicator
The dropping itself has not been implemented yet.
2012-05-21 21:48:45 +02:00
Peter Penz 3b6892b685 Use flat control-buttons 2012-05-19 22:44:37 +02:00
Peter Penz c318a3da6c Show video previews according to file content instead of the mimetype-string
Show a video widget depending on the video content instead of the mimetype
string: There are container formats which can be either audios or videos.
Besides, the rmvb video files have a mimetype of
"application/vnd.rn-realmedia", and these files can be recognized as videos
correctly now.

The patch has been provided by Hui Ni.

REVIEW: 104988
FIXED-IN: 4.9
2012-05-19 22:30:31 +02:00
Peter Penz e9d29bcf30 Enable basic drag and drop support for the Places Panel
The dropping has not been implemented yet, however in the context of
this step the creating of the drag-pixmap is now forwarded to
the item-widgets. This allows creating some optimized dragging-pixmaps
e.g. for the details-view, where only the name and icon should
be provided as drag-pixmap.
2012-05-18 23:31:44 +02:00
Peter Penz d9eab08fcb Don't create a .directory-file for each directory
This regression has been introduced on master and has not been
released yet: Due to the changed properties-format an update has
been done which resulted in writing a .directory file into each
newly entered directory.

The patch updates the view-properties and version only in the
constructor so that it is assured that reading properties never
accidently will change the internal version.

A unit-test has been added to catch regressions like this in future.

BUG: 300240
FIXED-IN: 4.9.0
2012-05-18 19:43:17 +02:00
Peter Penz a6241cf8ea Fix index-range issue 2012-05-17 22:10:18 +02:00
Peter Penz 727fd64e12 Create unit-test for KStandardItemModel 2012-05-17 22:00:39 +02:00
Peter Penz bd02faa982 KStandardItemModel: Fix inconsistent internal state
Assure that the index-cache is kept consistent with the items when
a removing or inserting is done. A unit-test will be created as soon
as possible.
2012-05-17 13:34:31 +02:00
Peter Penz bca055a38e Add unit-test to test a possible crash when updating group-headers 2012-05-17 11:47:21 +02:00
Peter Penz ff6e4341c5 Fix crash related to group-headers
If multiple ranges are inserted or removed, the updating of
the group-headers may only be done after _all_ ranges have been
inserted/removed and not after each individual range. Otherwise
the layouter-cache is not in a consistent state yet.
2012-05-17 11:16:19 +02:00
Peter Penz 855560dd32 Shorten the "path" content if possible
Replace the home-path by '~' for having a shorter content.
2012-05-16 23:42:13 +02:00
Peter Penz 3ad3dd5afb Fix default sort-role
The default sort-role property internally has been renamed from
"name" to "text" to be open for more generic usecases like in
the KStandardItemModel.
2012-05-16 23:27:36 +02:00
Peter Penz 3e2cf9721b Provide default view properties for system-places
For the "Recently Accessed"-places and "Search For"-places like
documents, images, audio-files and videos proper default properties
are created now (e.g. previews and images-sizes are shown when
searching for "images" etc).
2012-05-16 23:13:55 +02:00
Peter Penz 2fd31c8a95 Update trash-icon dependent on whether the thrash is empty or not
The class PlacesItemStorageAccessListener has been renamed to
PlacesItemSignalHandler and represents a generic signal handler
for the PlacesItem.
2012-05-16 19:19:57 +02:00
Peter Penz a632e8b9ef Fix possible crash when hiding items 2012-05-16 16:51:17 +02:00
Peter Penz 88c6859284 Implement bookmark synchronization
Whenever the bookmarks are changed by another application, the
state must be synchronized within the model.
2012-05-16 13:47:30 +02:00
Peter Penz d47d83c9ae Let the places-item determine the group itself
Related improvements: When loading the bookmarks assure in any
case that items having the same group are inserted as one single
group.
2012-05-14 22:09:09 +02:00
Peter Penz f74c72b965 Fix several bookmark synchronization issues 2012-05-14 17:42:10 +02:00
Peter Penz c10affe267 Translation improvements
Thanks to Frederik Schwarzer for the suggestions!
2012-05-14 15:04:21 +02:00
Peter Penz 77ad7c431a PlacesItemModel: Automatically save bookmarks
Prevent that a manual call to save changed bookmarks is
necessary.
2012-05-14 14:58:34 +02:00
Peter Penz 6e9713c558 PlacesItemModel: Remove setItemHidden and isItemHidden
This should be handled automatically when the hidden-state of
the item itself gets toggled.
2012-05-13 23:30:38 +02:00
Peter Penz 1426b8d3c7 Places Panel: Prepare code to save state of bookmarks
The saving is still disabled currently until 100 % backward
compatibility with KFilePlacesView has been reached.
2012-05-13 21:45:59 +02:00
Peter Penz 6039c246ea Remove obsolete signal/slot connection 2012-05-12 11:47:40 +02:00
Peter Penz 042899e25f Fix faulty signal/slot connection 2012-05-12 11:42:31 +02:00
Peter Penz 28daa45a44 Places Panel: Implement eject and teardown actions
Further fixes:
- Add/remove item when device has been added/removed
- Update emblem if the accessibility-state has been changed
2012-05-11 23:02:14 +02:00
Peter Penz b319c59b8d Allow moving items to trash also for non-local files
See bug 188032 for an ongoing discussion. In case if this behavior
is really not wanted by users (the feedback on bugs.kde.org will
show), the review-request
https://git.reviewboard.kde.org/r/104915/ should be merged too
(after adjusting some parts of the code).
2012-05-11 16:26:34 +02:00
Peter Penz 73c30c7ea2 Allow to remember view-properties for the search-mode
Per default Dolphin remembers the view-properties for each search-URL
individually. However when being in the search-mode, where the
search-URL is different each time by definition, it should also
be possible for the user to adjust the view-properties. The DolphinView
is not aware about any "search-mode", so an interface has been added
to provide a "context" for storing the view-properties. The context
will be adjusted by the DolphinViewContainer in case if the search-mode
is active.
2012-05-10 23:29:25 +02:00
Peter Penz 4fad8f8f53 Reimplement search-filters
BUG: 270721
BUG: 280377
FIXED-IN: 4.9.0
2012-05-10 22:45:12 +02:00
Script Kiddy b983b7d2da SVN_SILENT made messages (.desktop file) 2012-05-10 09:43:29 +02:00
Peter Penz 6150ac5d5d Assure backward compatibility for the sort-role
Dolphin 2.1 uses "text" instead of "name" as default-role. Provide
backward compatibility with older .directory files and assure
that they get updated.
2012-05-09 15:50:54 +02:00
Peter Penz 9641672247 Let the group-headers respect the item-offset 2012-05-09 14:04:04 +02:00
Peter Penz 321f747ddf Create items for devices that have not been added as bookmarks yet 2012-05-09 09:04:06 +02:00
Peter Penz 02b251372e Remove unimplemented declaration 2012-05-08 21:26:07 +02:00
Peter Penz df99de6428 Places Panel: Add missing translation strings
Provide a temporary dummy-implementation with the missing translation
strings, so that the translation-string-freeze gets respected.
2012-05-07 23:24:18 +02:00
Peter Penz a024e3e2aa Remove workaround to start/stop the resource watcher
Using the latest resource-watcher from kde-runtime does not make
this workaround necessary anymore.
2012-05-06 22:08:02 +02:00
Peter Penz 5cf40dba79 Remove kde-runtime dependency "nepomukdatamanagement"
Follow the suggestion from Vishesh Handa and copy the ResourceWatcher
code from kde-runtime instead of creating a dependency. This will of
course get removed again as soon as Nepomuk's resource watcher will
get a public API.
2012-05-06 21:52:33 +02:00
Peter Penz 814a64681d Show "duration" in the format hh::mm::ss 2012-05-06 13:32:20 +02:00
Peter Penz d4173443ab Fix sorting issues for Nepomuk-roles
Just use a string-comparison as default-compare.
2012-05-06 13:00:42 +02:00
Peter Penz 9419f0f3a5 Fix issue that no Nepomuk-data is shown when searching 2012-05-06 12:43:57 +02:00
Peter Penz 7f96282e41 Allow to remember view-properties for search-results
Until now it was only possible to adjust the view-properties for
searching in general. Now the view-properties can be adjusted
dependent on the query (e.g. images, documents, ...).
2012-05-06 12:33:28 +02:00
Peter Penz 37bd2116cb Additional information: Use "Audio" instead of "Music"
This is consistent to the term used in the places panel.
2012-05-06 11:57:14 +02:00
Peter Penz 8e68c4235d Assure that a newly created item gets selected/focused and visible
Thanks to Franz Fellner for the patch!

CCBUG: 291064
CCMAIL: alpine.art.de@googlemail.com
2012-05-05 22:03:21 +02:00
Peter Penz 23fff35aeb Places Panel: Provide access to devices 2012-05-05 21:38:37 +02:00
Peter Penz 067642a23c Places Panel: Implement PlacesItemModel::setHiddenItemsShown(false) 2012-05-03 22:27:11 +02:00
Peter Penz 9c033396b9 Places Panel: Provide "Open in New Tab" entry
Additionally some translation cleanups have been done because of the
soft-feature-freeze.

BUG: 176718
FIXED-IN: 4.9.0
2012-05-03 16:37:32 +02:00
Peter Penz aacf20282d Places Panel: Allow showing of hidden items 2012-05-02 23:57:04 +02:00
Peter Penz f158bf097a Places Panel: Fix implementation issues when hiding items 2012-05-02 21:24:16 +02:00
Peter Penz d76b113ad1 Places Panel: Allow hiding of items
Related changes:
- Animate changed items for the details-view in case it is not expandable
- Remove the hardcoded "isHidden"-code in KStandardItemListWidget and
  allow derived widgets to define themselves what means "hidden" within
  their context.

The current code needs a lot of bugfixing, but lets make this in smaller
steps during the next days...
2012-05-01 23:14:52 +02:00
Peter Penz 6a7cb5ff7d Fix crash when closing Dolphin during generating previews
BUG: 299108
FIXED-IN: 4.9.0
2012-04-30 18:55:48 +02:00
Peter Penz cb1f42a1eb Places Panel: Minor fixes/improvements
- Determine group of a new entry dependent from the protocol
- Allow panels to forward error-messages to the view-container
  (also applied to Folders Panel)
2012-04-30 18:27:56 +02:00