Commit graph

26 commits

Author SHA1 Message Date
David Faure 3b5ccaacf5 Fix memory leak
svn path=/trunk/KDE/kdebase/apps/; revision=1119153
2010-04-26 17:29:02 +00:00
David Faure 7f5e80a8d3 Unbreak favicon checking; in many error cases it wouldn't proceed to the next item.
Also when the cached favicon was recent enough, then the kded module wouldn't emit anything;
fixed by adding a "forceDownloadHostIcon" and an error signal in the favicons kded module.
CCBUG: 23102
 (and probably others)

svn path=/trunk/KDE/kdebase/apps/; revision=1116050
2010-04-18 14:24:11 +00:00
David Faure 1cd5acff40 remove dep on globalbookmarkmanager.h; move m_model to holder
svn path=/trunk/KDE/kdebase/apps/; revision=1115823
2010-04-17 16:01:46 +00:00
David Faure c2dee9346d Get rid of two more singletons (how many singletons can one have in a single program?)
svn path=/trunk/KDE/kdebase/apps/; revision=1115716
2010-04-17 08:10:35 +00:00
David Faure 054cbc204c Port favicon and testlink to having their own model pointer.
Try to repair these things (the status wasn't returned by the model), but doesn't seem to work yet.

svn path=/trunk/KDE/kdebase/apps/; revision=1112533
2010-04-08 12:16:33 +00:00
Dirk Mueller 40210ad407 RELICENSE: GPLv2->GPLv23
svn path=/trunk/KDE/kdebase/apps/; revision=749122
2007-12-16 15:37:21 +00:00
Daniel Teske 153180367e Better. Make some things work.
Like drag and dropping bookmarks.
Filtering.
And various fixes all over the place.
Still not really where it should be for a release.

svn path=/trunk/KDE/kdebase/apps/; revision=748964
2007-12-16 01:47:07 +00:00
David Faure 3c76d4c6b5 * Move KonqPixmapProvider to Konqueror, unused elsewhere (it's for favicons in the location bar)
* Delete KonqFavIconMgr, was merely a dbus interface wrapper, so generate a org::kde::FavIcon instead. This also spotted a typo in the .xml file...
* Call favicon.downloadHostIcon synchronously instead of with NoBlock; was racy [sounds like a possible kde3 bug too, it was using send instead of call]
    Blocking during that method call isn't a big problem anyway, if a real download has to happen it will be delayed via a KIO job anyway (-> the method returns fast).

* One must connect to a dbus signal using a real connect, in unit tests; QSignalSpy isn't enough since it's connect() that triggers some DBUS magic which makes our process listen to the signal. That's quite tricky and unexpected...

svn path=/trunk/KDE/kdebase/apps/; revision=730878
2007-10-29 23:12:46 +00:00
David Faure 7190562aad Fix compilation; ported to dbus except for the khtml->print hack and the startup stuff (will do that one later)
svn path=/trunk/KDE/kdebase/apps/; revision=552872
2006-06-19 10:42:32 +00:00
Laurent Montel 83b60776c5 Use QT macro for signal/slots
svn path=/trunk/KDE/kdebase/nsplugins/; revision=500480
2006-01-20 11:09:06 +00:00
André Wöbbeking 73be974b33 include cleanup
svn path=/trunk/KDE/kdebase/apps/; revision=484132
2005-11-29 13:56:41 +00:00
Laurent Montel 0944c3d3ea Q3ValueList--
svn path=/trunk/KDE/kdebase/apps/; revision=480589
2005-11-15 16:37:53 +00:00
Dirk Mueller 40b74b7fc1 SVN_SILENT: fix typo
svn path=/trunk/KDE/kdebase/nsplugins/; revision=467416
2005-10-05 08:44:32 +00:00
Daniel Teske 40c354dcc3 Remove Q3PtrList from BookmarkIterator and derived classes.
Replave QVector<KBookmark> by QList<KBookmark> (== KBookmark::List).


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=464923
2005-09-28 16:16:52 +00:00
Daniel Teske fddf326d4e Port keditbookmarks to Qt4's model/view framework.
Editing, creating and selecting bookmarks works.
For deleting you have to run apply-patches in your qt-copy directory.
All other things are broken. (E.g. drag'n'drop, the edit fields at the bottom, the searchline...)

I wrote down some of my learned lessons while working with Qt4's model/view framework
at http://www.squorn.de/kde/qtmodelview.html


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=448977
2005-08-13 20:13:21 +00:00
Stephan Kulow e77f20dbaf svn merge svn+ssh://coolo@svn.kde.org/home/kde/trunk/KDE/kdebase@438057
svn+ssh://coolo@svn.kde.org/home/kde/branches/work/kde4/kdebase
          .

I couldn't resolve one kicker conflict that results from different
development directions, so I rely on Aaron to sort it out - the file
is commited with conflicts

svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=439627
2005-07-28 14:59:42 +00:00
Dirk Mueller b3736b51bc update FSF address
svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=431577
2005-07-04 19:02:09 +00:00
Daniel Teske 1d51ccad92 Fix merge-while-modified by removing it.
(It used a broken design.)
Instead immediately forward changes in keditbookmarks
to all other kbookmarkmanagers.

BUG: 77355


svn path=/trunk/KDE/kdebase/konqueror/keditbookmarks/; revision=425768
2005-06-15 14:41:18 +00:00
Alexander Kellett 7f65c026be sick of having two different coding styles between kio/bookmarks and here,
so, add 4 space modelines to all files. i'll gradually fix the files over
the coming days.

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=256804
2003-10-06 18:31:25 +00:00
Alexander Kellett 7ccdbac059 const fixes in bookmarkiterator and subclasses
enum for paintstyle
method and variable renames
url()

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=212337
2003-03-08 13:22:06 +00:00
Alexander Kellett c78d55307d renames:
doBlah -> doAction
   isBlahable -> isApplicable

svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=211136
2003-03-03 20:52:39 +00:00
Alexander Kellett 16033d764f split faviconupdater class into updater.{cpp,h}
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=208423
2003-02-21 21:28:33 +00:00
Alexander Kellett 859ba99bb2 shuffle compile fix make wonderful and a few other things
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=205237
2003-02-06 13:16:40 +00:00
Alexander Kellett baba9e4c7e shuffles and cleanups
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=205216
2003-02-06 09:59:59 +00:00
Alexander Kellett 4ff4b0c3e6 merge in make_it_even_cooler_branch
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=201732
2003-01-21 16:16:53 +00:00
Alexander Kellett 6efddba670 moving out favicons stuff into new files
svn path=/trunk/kdebase/konqueror/keditbookmarks/; revision=181291
2002-09-30 12:36:56 +00:00