Commit graph

7148 commits

Author SHA1 Message Date
Alexander Lohnau
0c38a27cc0 Install servicemenus in new install location
Since KIO 5.85, this new file location is preferred over the
KServiceTypeTrader results.

With this change, single desktop files from the KDE store are installed
in the correct location. If however a custom install script is used,
developers need to adjust their scripts.

Because the "kio/servicemenus" locations is different than the one
KAuthorized allows by default, we have to mark the file as executable.

Task: https://phabricator.kde.org/T14543
2022-04-01 17:55:11 +00:00
Felix Ernst
0e15ff7f14 Merge branch 'release/22.04' 2022-04-01 12:17:25 +02:00
George Florea Bănuș
29383426d6 Fix tooltip closing while mouse moves over item
The itemHovered signal is emitted whenever the mouses moves causing the
tooltip to close.
2022-04-01 10:12:05 +00:00
l10n daemon script
356ccd21b4 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-04-01 02:03:03 +00:00
Nicolas Fella
3ccc0420a6 Merge branch 'release/22.04' 2022-04-01 00:13:19 +02:00
Nicolas Fella
1041b52c7a Don't crash when mountpoint is not found
findByPath may return a nullptr, in that case don't access it

BUG: 452100
2022-03-31 23:24:59 +02:00
Kai Uwe Broulik
64ffcdad4f [ToolTipManager] Create DolphinFileMetaDataWidget on-demand again
This reverts b7fbd19a76 but creates the
widget only once and then reuses it.

However, ownership of a parent-less widget is transferred to the
`KToolTipWidget` but since we first request metadata, then show the
tooltip (or won't if the mouse moved on since), we cannot rely on
the `KToolTipWidget` exclusively.

Instead, when we still delete the widget ourself until we have
shown the `KToolTipWidget` once at which point it will handle the
life time for us.

This fixes parenting the widget to `DolphinView` which would make
it appear as a broken line in the top left of the window.
2022-03-31 14:22:24 +02:00
l10n daemon script
a8966d230c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-29 03:51:20 +00:00
l10n daemon script
c7531ba749 GIT_SILENT made messages (after extraction) 2022-03-29 03:00:38 +00:00
l10n daemon script
447c35868c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-29 02:21:23 +00:00
l10n daemon script
d658c7e090 GIT_SILENT made messages (after extraction) 2022-03-29 00:58:32 +00:00
Kai Uwe Broulik
df75b31304 Merge branch 'release/22.04' 2022-03-28 17:09:52 +02:00
Kai Uwe Broulik
466fa20f7f [ViewProperties] Apply better default roles for special views
This adds the following additional special view modes (some of them were
already there but broken because they weren't applied, or were
changed to have better defaults now that they are actually used):

* Recent Files and Recent Documents, timeline:
  Details view with grouped sorting enabled and Name, Path, Modified
* Search For Images:
  Icon view with Name, Dimensions, Date Time of the Picture
* Search For Audio:
  Details view with Name, Artist, Album, Duration
* Search For Videos:
  Icon view with just Name
* Search For everything else, including Documents:
  Details view with Name, Path, Modified
* Trash:
  Details view with Name, (Original) Path, Deletion Time

BUG: 400969
BUG: 340393
BUG: 186376
FIXED-IN: 22.04.0
2022-03-28 14:56:49 +02:00
Kai Uwe Broulik
e304aa79b4 [ViewProperties] Consider existing roles in convertAdditionalInfo
Otherwise all default overrides for roles we perform in this class are moot.
2022-03-28 14:52:15 +02:00
Nicolas Fella
b7fbd19a76 Reuse metadata widget when creating tooltips
Currently any time we hover the mouse over a file we create a new DolphinFileMetaDataWidget (even when we don't actually show a tooltip).

That is quite wasteful

Instead we can reuse the existing instance and only change the URL
2022-03-25 11:18:46 +01:00
Steffen Hartleib
f509d41baf Using the gesture recognizer from KWidgetsAddons
Using the gesture recognizer from KWidgetsAddons, so that the source code for the gestures is only in one place
2022-03-23 22:00:31 +00:00
Felix Ernst
45af4bc0e0 Allow for more explicit button labels
This commit allows us to very explicitly refer to any set of items
in text. This way buttons don't need to be labeled generically
like "Permanently Delete" but can be enriched to be labeled
"Permanently Delete "FileName"" or "Copy 7 Selected Folders" or
"Copy 6 Files" or "Rename "file1", "file2", "file3", "file4" and
"folder5"".

This commit tries to save translators a lot of work by using a
translation puzzle. This might be problematic for some languages.
The alternative on the other hand would mean that any label which
wants to be explicit would need to have over 10 translations just
for one label which seems quite bad as well.

A fallback is to be implemented for languages that can't really
accommodate for any specific word puzzle. This is explained in the
documentation.
2022-03-23 15:03:32 +00:00
l10n daemon script
0a9c018497 GIT_SILENT made messages (after extraction) 2022-03-23 02:46:59 +00:00
l10n daemon script
49726ad591 GIT_SILENT made messages (after extraction) 2022-03-23 00:58:56 +00:00
Nicolas Fella
1cd00946c4 Port to target-based ecm_add_app_icon 2022-03-21 20:43:31 +01:00
Nicolas Fella
05132a2f1d Port to target-based ecm_add_app_icon 2022-03-20 20:16:04 +01:00
l10n daemon script
109eb3334d SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-20 03:39:12 +00:00
l10n daemon script
3c1ebfcfb1 GIT_SILENT made messages (after extraction) 2022-03-20 02:49:46 +00:00
l10n daemon script
fa72ae8577 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-20 02:14:36 +00:00
l10n daemon script
990c6e7aa5 GIT_SILENT made messages (after extraction) 2022-03-20 00:55:37 +00:00
Kai Uwe Broulik
3fab07c967 Prettify labels in back/forward button menu
Adds a compact label based on the closes place similar to the
address bar (e.g. instead of /home/user/Pictures/Holidays it will
show Pictures/Holidays), unless "show full path in address bar"
is enabled.

Also, add the folder icon
2022-03-18 19:57:13 +01:00
Laurent Montel
c6bccbf6de Fix some compile error against qt6 2022-03-15 13:30:13 +01:00
Albert Astals Cid
db16b7d1cd GIT_SILENT Upgrade release service version to 22.07.70. 2022-03-12 12:57:14 +01:00
Albert Astals Cid
f9baca9288 GIT_SILENT Upgrade release service version to 22.03.80. 2022-03-12 12:20:04 +01:00
Anthony Fieroni
94acf0ba0b Pass dolphin view as parent widget to plugins
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
2022-03-11 08:20:09 +02:00
l10n daemon script
ecda1e9500 GIT_SILENT made messages (after extraction) 2022-03-11 00:51:19 +00:00
l10n daemon script
7c6a34222c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-07 01:44:55 +00:00
l10n daemon script
3366f62b09 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-05 01:48:28 +00:00
l10n daemon script
62f1897e59 GIT_SILENT made messages (after extraction) 2022-03-05 00:47:08 +00:00
Kai Uwe Broulik
df79f5b477 [Places Panel] Reject drops on unwritable locations
Indicate that you cannot drop here.

Avoids a "Cannot drop file" or "not supported" error when
dropping files ontop of a search or timeline URL.

It is done in Dolphin rather than the library as there we cannot
assume what a consumer might be doing with the drop.
2022-03-04 18:25:38 +00:00
David Edmundson
b6e03e05f4 Fix issue where newly inserted items end up in the wrong directory
If we have directory "a" and "a/b" and expand both, then collapse "a" we
tell KDirWatcher to stop watching both these directories.

However, KDirWatcher keeps them in the listersCurrentlyHolding list as
well as the listersCurrentlyListing list and will still notify of
changes. If a new file appears in "a/b/" we will still get change
notifications.

When dolphin processes these changes we cannot find the relevant parent
node. It then gets confused and inserts the item into the root directory
from the POV of the model notifications. When we then open the relevant
folder the model knows a node with that URL exists and fails to add it
correctly.

This can also be reproduced by continually downloading files into a
subdirectory tree and rapidly expanding and collapsing folders a few
levels deep.
2022-03-04 10:57:16 +00:00
Felix Ernst
cd369a1519 Always select items on activation
There is an unintended side-effect in
d383961719 which this MR fixes.

Normally in Dolphin, when clicking on an item to open/activate it,
it is both selected by the click and opened/activated.

Prior to this MR, the item wasn't selected when all of these
conditions were met:
- Use ActivateItemOnSingleClick also knwon as single-click mode
- Have more than one item selected already
- Click on an item that was previously not selected

Prior to this MR, the click would deselect all items and
activate the clicked item but not select it.

With this MR, the click will deselect all items, activate
the clicked item and also select it and move the anchor there.

When testing this with folders, make sure to navigate back after activating the folder. The folder should then still be selected.

This is then consistent with the behaviour when the specific
conditions mentioned above are not met.
2022-03-04 10:41:50 +00:00
Janet Blackquill
e8dc49e4b2 KItemListHeaderWidget: don't crash if widget == nullptr
BUG: 449238
2022-03-03 16:02:29 +00:00
Stefano Crocco
505bf52f59 Display Apply button in KCMs
When displaying the KCMs in another application's configuration dialog
(for example, in Konqueror), the Apply, Ok and Reset buttons aren't
shown. This issue is caused by a missing Apply flag in the call to
setButtons in the KCModule constructor.

the fact that in the call to setButtons
from the KCModule constructor, the Apply flag is missing.

BUG: 448352
2022-03-01 12:00:37 +01:00
Heiko Becker
f73183c0f6 GIT_SILENT Update Appstream for new release
(cherry picked from commit 3ac70fe65b)
2022-02-27 19:01:08 +01:00
l10n daemon script
7a9aa9076f GIT_SILENT made messages (after extraction) 2022-02-27 00:52:17 +00:00
Jan Blackquill
3ce9d1d19e KStandardItemListWidget: don't double up the expansion offset 2022-02-26 00:48:00 -05:00
Kai Uwe Broulik
c68f1f6f8d Merge branch 'release/21.12' 2022-02-25 21:03:36 +01:00
Eugene Popov
8250961206 [CompactView] Remove animation on file rename
This MR fixes an issue where the label is cut off when renaming in Compact View mode.

BUG: 449179
FIXED-IN: 22.04
2022-02-25 19:37:01 +00:00
Ismael Asensio
c623522ecb [DolphinQueryTest] Fix class name duplication 2022-02-25 19:23:18 +00:00
Janet Blackquill
ddba4f5fd8 KStandardItemListWidget: handle RtL drawing properly
BUG: 449211
2022-02-25 16:35:05 +00:00
Kai Uwe Broulik
d031696a92 Fix rating pixmap alignment on high-dpi screens
When calculating layout geometry based on the pixmap size,
one needs to divide by `devicePixelRatio`
2022-02-23 20:44:22 +01:00
Kai Uwe Broulik
cd81906550 Ignore empty roles for textRect calculation
Avoids a text rect taller than the area that actually contains text,
as can be seen by hovering files in a folder with "additional roles"
that a given file does not contain.
2022-02-23 20:27:33 +01:00
l10n daemon script
d774088a52 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-02-20 01:50:36 +00:00
l10n daemon script
78753ad23c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-02-18 01:51:42 +00:00