Commit graph

1114 commits

Author SHA1 Message Date
Rafael Fernández López
1e27cae3e5 The drag&drop helper did not make the difference between the different kind of views. The only view that draws the hover indicator with rounded corners is the icon view
mode. For that reason, the drop marker with the detailed view was drawn with rounded corners. For making it consistent, we draw the drop indicator as the hover effect 
indicator, so the only one that draws rounded corners is the icon one.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=749225
2007-12-16 20:56:24 +00:00
Peter Penz
ae44181e5e If the URL navigator is editable and has the focus, Ctrl+A should select the URL and not all items (thanks to Morton O. Hansen for the patch!)
BUG: 153697

svn path=/trunk/KDE/kdebase/apps/; revision=749188
2007-12-16 19:25:59 +00:00
Rafael Fernández López
242b88396f Oh, this is already the default. Thanks Pino
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=749105
2007-12-16 14:17:23 +00:00
Rafael Fernández López
8991d90471 Use the "new" bug dialog opening bugs.kde.org that will also check for already reported issues. :)
Regarding the thread on kde-devel mailing list 'KDE4 - doplhin   - bug reporting uses "very old" bug system'

CCMAIL: peter.penz@gmx.at
CCMAIL: kde-devel@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=749101
2007-12-16 14:11:07 +00:00
Peter Penz
7122f99d75 Only browse through zip and tar files if they are local (otherwise a cryptic error message will occur). We really must make this behavior configurable in KDE 4.1 - I'd suggest that per default no browsing through zip and tar is done (with an option turning this on again)
BUG: 153985
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=749059
2007-12-16 12:23:49 +00:00
Rafael Fernández López
58d37b2331 When collapsing nodes that made the scrollbar bigger, it didnt became smaller. I've debugged on event() method to find out which event was the one called. It seems
QEvent::MetaCall is always called when we want and is not as impressive called as paintEvent(), so there we go. This will fix another problem that when a second expanded 
cached node should make the horizontal scrollbar bigger it didn't till the tree view lost the focus or was resized. Everything fixed :)

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=749049
2007-12-16 11:53:28 +00:00
Peter Penz
1a7cf5427f the signal urlsDropped is not available anymore in the DolphinView
svn path=/trunk/KDE/kdebase/apps/; revision=749047
2007-12-16 11:49:39 +00:00
Peter Penz
8808c0bca2 replace Q_ASSERT by 'if', otherwise each caller of updateElasticBand() must check the state itself
svn path=/trunk/KDE/kdebase/apps/; revision=749045
2007-12-16 11:43:39 +00:00
Rafael Fernández López
bef9d64b2a Missing call
svn path=/trunk/KDE/kdebase/apps/; revision=749041
2007-12-16 11:31:12 +00:00
Peter Penz
3d2593f423 fixes for the terminal panel:
* assure that the correct directory is entered when reopening the terminal
* let the terminal be focused also when reopening it

BUG: 153785
BUG: 153756

svn path=/trunk/KDE/kdebase/apps/; revision=749039
2007-12-16 11:28:52 +00:00
Rafael Fernández López
792ebd6691 Fix the problem of the tree view. When we are expanding too many nodes (or very large ones) a horizontal scrollbar wasn't shown. Now it is.
CCMAIL: peter.penz@gmx.at
CCMAIL: wstephenson@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=748978
2007-12-16 03:37:29 +00:00
Rafael Fernández López
f55fe7bce6 The latest fix still had the same problem when dragging went out of the viewport and entered again. Non droppable places (e.g. files) were still drawn with MouseOver
flag. This completely fixes the problem for all cases, the problem was the hovered cached index being updated at indexAt() method used for general purposes. Now it is 
updated on the MouseMove method, and this gives consistence.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=748970
2007-12-16 02:14:15 +00:00
Rafael Fernández López
8fea48eb44 Fix the problem of the elements being rendered as hovered when a dragging was being done. Regarding your mail Peter, well some variables are bad-named, but their values
were correct :)

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=748962
2007-12-16 01:37:11 +00:00
Peter Penz
fb4907dc6d Fixed "Eike Hein"-details-view-issue:
1. Open a Dolphin window
2. Switch to Details view
3. Navigate to a folder with a dozen or so items
4. Size the window so that there is an empty space below
   the items
5. Move the mouse pointer below the items
6. Click and hold the mouse button, and move the pointer
   upward to select all items in the list using the rect.
   While selecting in this manner, move the pointer so
   high that it is above the list headers in the toolbar.
   Then, while still holding the mouse button and being
   outside the listview's rect, move the pointer left out
   of the window. Now with the pointer outside of the
   window, move the pointer down into the area below the
   list items, so that the selection rectangle no longer
   intersects with the items. Notice they're still all
   selected.

CCMAIL: hein@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=748830
2007-12-15 17:11:13 +00:00
Peter Penz
ceafa5cc22 Fixed issue that Ctrl+A inverted the selection instead doing a "Select All". It seems like a Qt issue, but I'm not 100 % sure - I'll try to make this reproducible with a Qt-only code after KDE 4.0 and submit a bug report to Trolltech...
BUG: 153938

svn path=/trunk/KDE/kdebase/apps/; revision=748823
2007-12-15 16:48:48 +00:00
Rafael Fernández López
1e3da19459 This fixes the selection problem with the mouse _only_ for the categorized view. QListView has a bug that will toggle the last selection done, have to report it to TT.
BUG: 154028
CCMAIL: wstephenson@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=748822
2007-12-15 16:48:07 +00:00
Peter Penz
ecce6e87f8 fixed selection behavior in the details view (when the selection enters the viewport area, Qt's QTreeView does no selection at all, even if the items are still within the elastic band)
svn path=/trunk/KDE/kdebase/apps/; revision=748819
2007-12-15 16:25:23 +00:00
Peter Penz
e91a20c9b8 simplified code for assuring that Open Office files won't get browsed + added comment (thanks to David for the hint)
svn path=/trunk/KDE/kdebase/apps/; revision=748799
2007-12-15 15:20:45 +00:00
Script Kiddy
86078850a4 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=748723
2007-12-15 08:25:51 +00:00
Sebastian Trueg
ff53c10f6c No need to export that yet
svn path=/trunk/KDE/kdebase/apps/; revision=748555
2007-12-14 19:48:42 +00:00
Rafael Fernández López
6be0981c7d Oh, this won't let Ctrl+click for deselecting items ... OK, a different hack is needed.
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=748549
2007-12-14 19:27:50 +00:00
Sebastian Trueg
737b74aa29 Use the same codebase for rating drawing as in KRatingWidget and playground/nepomuk.
For KDE 4.1 we will export this in kdelibs/nepomuk

CCMAIL: peter.penz@gmx.at
CCMAIL: ereslibre@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=748547
2007-12-14 19:23:02 +00:00
Rafael Fernández López
e983e0e38e Very interesting bug in Qt in which I will debug. For now, and since we need to release with the source version of Qt (not patched) we need this workaround. The problem
is that when you select by dragging with a rect a set of items, say (1, 2, 3) and you Ctrl+drag another set (5,6) the (1,2,3) selection is lost. If you do the same, that 
is: select (1, 2, 3), now Ctrl+click on (4), it is not lost. Now, ctrl+drag another set (5, 6), the selection lost is (4). So we can say that the selection lost is the 
last one done.

This is only a workaround and should be removed when fixed on Qt (I am going to debug it on Qt, to see where the fail is).

This workaround does not only fix KCategorizedView, but QListView also.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=748545
2007-12-14 19:20:47 +00:00
David Faure
609ce09292 Moving code around in dolphin fixes DnD support in konqueror :)
svn path=/trunk/KDE/kdebase/apps/; revision=748476
2007-12-14 15:53:40 +00:00
Peter Penz
c436a142e8 Fixed issue that when clicking on Open Office files that Dolphin handles the files as zip-folder. I'm not sure whether there might be a nicer way doing this, but at least for KDE 4.0 this should be sufficient.
BUG: 153981

svn path=/trunk/KDE/kdebase/apps/; revision=748399
2007-12-14 11:45:11 +00:00
Script Kiddy
1e72ef9ca0 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=748324
2007-12-14 07:53:43 +00:00
Rafael Fernández López
2df7bd3475 Forgot to modify the code for category selection. Fixed.
svn path=/trunk/KDE/kdebase/apps/; revision=748264
2007-12-13 23:40:29 +00:00
Rafael Fernández López
51b61d7735 Fix the bug reported by Will. Now this code is also more polite. This was a TODO and now is fixed :) Still a bug somewhere on Qt...
when you ctrl+selection rect (with mouse), it is lost the last selection done if they were done by groups. Going to dive more into 
this problem, but it lives on Qt.

BUG: 153876
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=748258
2007-12-13 23:24:14 +00:00
Script Kiddy
be448fc44f SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=747945
2007-12-13 08:03:38 +00:00
Rafael Fernández López
d351d41e4b Fixes the problem with the keyboard navigation when a selection with the right-click or a dragging unitary selection was done.
BUG: 153875

svn path=/trunk/KDE/kdebase/apps/; revision=747421
2007-12-12 00:04:13 +00:00
Peter Penz
1ab719d490 fixed issue that turning off the preview during the preview job still was active did not work as expected
TODO for 4.1: provide a preview helper class which can be shared between DolphinView and the special use case of DolphinColumnViewWidget

BUG: 153816

svn path=/trunk/KDE/kdebase/apps/; revision=747348
2007-12-11 19:19:44 +00:00
Peter Penz
4e43b5465f use different icon for "Add to places" as suggested by David Vignoni
CCMAIL: david@icon-king.com

svn path=/trunk/KDE/kdebase/apps/; revision=747049
2007-12-10 22:00:48 +00:00
Adriaan de Groot
c9a2f61942 Another handful of workaround includes
svn path=/trunk/KDE/kdebase/apps/; revision=746913
2007-12-10 16:19:11 +00:00
Sebastian Trueg
1329ae5ba3 Added Soprano include dir
svn path=/trunk/KDE/kdebase/apps/; revision=746869
2007-12-10 13:55:05 +00:00
Sebastian Trueg
929931b060 Use Xesam ontology instead of NIE. Since Strigi uses Xesam and we have no mapping yet this does make much more sense.
svn path=/trunk/KDE/kdebase/apps/; revision=746846
2007-12-10 12:34:56 +00:00
Script Kiddy
db5fcb7f76 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=746474
2007-12-09 07:38:20 +00:00
Peter Penz
26a15eb88e Follow David's advice and use 'delete' instead of 'deleteLater()'. Disconnecting the signals from KDirLister solves a previous crash.
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=746428
2007-12-08 23:05:32 +00:00
Jakob Petsovits
6a59da39bc Icon naming spec compliance (code changes - KDE/):
dialog-apply -> dialog-ok-apply

svn path=/trunk/KDE/kdebase/apps/; revision=746427
2007-12-08 23:01:41 +00:00
Peter Penz
3a2a6011e8 don't forget to delete the proxy model
svn path=/trunk/KDE/kdebase/apps/; revision=746418
2007-12-08 22:42:13 +00:00
Peter Penz
23f6a51f85 SVN_SILENT: adjusted position of comment
svn path=/trunk/KDE/kdebase/apps/; revision=746415
2007-12-08 22:39:04 +00:00
Peter Penz
b5bb77e45b don't forget to update the scrollbar size when resizing the column view
svn path=/trunk/KDE/kdebase/apps/; revision=746306
2007-12-08 17:09:56 +00:00
Peter Penz
54dfdc930a fixed memory leaks (thanks to David for fixing this in KDirOperator)
svn path=/trunk/KDE/kdebase/apps/; revision=746294
2007-12-08 16:16:45 +00:00
Rafael Fernández López
fc9a6701da Now that we changed some needed stuff at naturalCompare() method, we can set the replacementchar to put "Others" category on the last place. Now, we can actually call it
"Others" since it is placed the last one, and it is not necessary to call it "Uncategorized" because it was placed the first one before.

svn path=/trunk/KDE/kdebase/apps/; revision=746061
2007-12-07 17:49:49 +00:00
Rafael Fernández López
f048b7fd65 workaround no longer needed
svn path=/trunk/KDE/kdebase/apps/; revision=746029
2007-12-07 15:39:49 +00:00
Peter Penz
1d2e10bcb2 fixed issue that when using "Use common view properties for all folders" the view mode is reset to "icons" when using e. g. the FTP protocol
svn path=/trunk/KDE/kdebase/apps/; revision=745711
2007-12-06 21:36:52 +00:00
Peter Penz
e651545527 Fixed wrong usage of QStyleOptionViewItem: caching of the file item in the constructor is too early (thanks to Fredrik for the hint!). This fixes 2 issues:
* the selection color of the details view now uses the correct selection color
* changing the colors of KDE results in updating the colors of all Dolphin views

CCMAIL: hein@kde.org
CCMAIL: ereslibre@kde.org
CCMAIL: mw_triad@users.sourceforge.net

svn path=/trunk/KDE/kdebase/apps/; revision=745700
2007-12-06 21:06:45 +00:00
Peter Penz
4939ae662f fixed issue that the information panel shows wrong meta data when having split views in combination with selected items
BUG: 151644

svn path=/trunk/KDE/kdebase/apps/; revision=745669
2007-12-06 19:38:24 +00:00
Allen Winter
04948c542a use the ${GENERIC_LIB_VERSION} and ${GENERIC_SOLIB_VERSION} macros to help keep
with library versioning consistency into the future.
ok'd by dfaure.

svn path=/trunk/KDE/kdebase/apps/; revision=745632
2007-12-06 16:55:50 +00:00
Rafael Fernández López
848b3eb621 Fix palette problem as workaround. This is needed if the categorization is enabled
svn path=/trunk/KDE/kdebase/apps/; revision=745630
2007-12-06 16:51:43 +00:00
Rafael Fernández López
1ec3860a26 We didn't want this changes here... of course... Qt bug
svn path=/trunk/KDE/kdebase/apps/; revision=745561
2007-12-06 12:22:30 +00:00