Commit graph

326 commits

Author SHA1 Message Date
Frank Reininghaus c0922a81d8 Do not warn the user about closing Dolphin windows with multiple tabs
if Dolphin is closed by the session manager, i.e., if the user logs
out. The fix is inspired by the way this issue is handled in
Konqueror.

BUG: 201803

svn path=/trunk/KDE/kdebase/apps/; revision=1011002
2009-08-13 18:54:16 +00:00
Peter Penz 99eacd9f56 move statusbar code into the directory "statusbar"
svn path=/trunk/KDE/kdebase/apps/; revision=1005704
2009-08-01 20:01:51 +00:00
Peter Penz 8e6dbadef2 Fixed performance issues related to selections and deleting of files:
- Don't connect to KDirLister::itemDeleted(const KFileItem&), but KDirLister::itemsDeleted(const KFileItemList&). Otherwise Dolphin is informed about each single file deletion instead of getting the deleted items as a list. Thanks to David Faure for the hint!

- DolphinViewContainer::updateStatusBar() can be expensive when a lot of files are selected, as the file size must get retrieved. Assure that fast calls for updateStatusBar() don't trigger a synchronous update, do the update after 300 ms where no further update has been triggered.

- Dolphin provides a list of file items when emitting the selectionChanged() signal. Collecting the file items is a quite expensive operation, so use the same approach as when updating the statusbar: only emit the selection changed signal when no change has been done within 300 ms. This improves the performance when doing huge selections a lot.

- Make updateStatusBar() a private method, the main window should not need to take care about updating the statusbar (this is done internally now by DolphinViewContainer).

BUG: 199090
BUG: 195787
CCBUG: 199352
CCBUG: 188218

svn path=/trunk/KDE/kdebase/apps/; revision=995015
2009-07-11 17:48:05 +00:00
Peter Penz c3ffc95a73 - adding missing const
- minor adjustment of name
- use same declaration order as other private methods

CCMAIL: predator106@gmail.com 

svn path=/trunk/KDE/kdebase/apps/; revision=994089
2009-07-10 06:07:32 +00:00
Shaun Reich 70915125f7 Fixed the annoying bug (for me) that dealt with having a very long folder name. In this case, the name of the tab could be many more times bigger than the tabBar itself.
Now they are ellided, so e.g. "really really long folder name...is" or something.

Few more cases left for me to fix(shortly), but those are not quite close to this section.

svn path=/trunk/KDE/kdebase/apps/; revision=993618
2009-07-09 04:41:53 +00:00
Peter Penz c1ea2c3491 krazy qtclasses fixes
svn path=/trunk/KDE/kdebase/apps/; revision=973289
2009-05-26 18:52:14 +00:00
Peter Penz 3a612f1f24 use correct icon name (issue reported by krazy)
svn path=/trunk/KDE/kdebase/apps/; revision=973278
2009-05-26 18:39:25 +00:00
Peter Penz ec859058c6 krazy fixes
svn path=/trunk/KDE/kdebase/apps/; revision=969874
2009-05-19 07:25:40 +00:00
Frank Reininghaus 07ad9b3726 Update the directory of the Terminal Panel if the current URL is not a
"file:" URL, but is nevertheless local (e.g., "desktop:").

This fix is also applied to the new "Open external Terminal" action
which will be in KDE 4.3.

BUG: 167810 

svn path=/trunk/KDE/kdebase/apps/; revision=969265
2009-05-17 19:57:07 +00:00
Frank Reininghaus cc8a62ff16 Don't show an empty window caption when browsing "/", "trash:", etc.
BUG: 190783

svn path=/trunk/KDE/kdebase/apps/; revision=964061
2009-05-05 21:49:03 +00:00
Frank Reininghaus cadfb2a3c6 Make it impossible to hide one of the views in a split view setup
completely by dragging the QSplitterHandle to the left or right. This
fixes the problem that a hidden view disappears completely after
closing the visible view. The root cause of this issue still seems to
be unclear though.

BUG: 190265

svn path=/trunk/KDE/kdebase/apps/; revision=957703
2009-04-22 18:29:02 +00:00
Frank Reininghaus b842968e4a Make Qt 4.5's new "move tab" feature work in Dolphin. Up to now, tabs could be moved in the tab bar using drag&drop, but DolphinMainWindow didn't notice :-(
Note that there's no need to call setActiveTab() because the active tab is the same before and after the move operation - only its index in the tab bar has changed.

BUG: 189641

svn path=/trunk/KDE/kdebase/apps/; revision=954556
2009-04-15 21:50:50 +00:00
David Faure 402a17bf1f KonqFileItemCapabilities -> KFileItemListProperties
svn path=/trunk/KDE/kdebase/apps/; revision=948007
2009-04-01 23:34:33 +00:00
Peter Penz 66ef40ec88 Use KNewMenu::createDirectory() instead of KonqOperations::newDir() when F10 has been pressed, so that the directory gets automatically selected afterwards.
CCMAIL: rahman.duran@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=945037
2009-03-26 18:44:36 +00:00
Rahman Duran bd2f7179de BUG: 175658
GUI:

The remote encoding code adapted from Konqueror to Dolphin. Now user can change
encoding for remote urls like ftp. Konqueror doesn't use
KRemoteEncodingPlugin anymore. Instead, this feature is supplied to
Konqueror via DolphinPart.

svn path=/trunk/KDE/kdebase/apps/; revision=944659
2009-03-25 22:00:50 +00:00
Peter Penz abc9b18816 Fixed issue that tabs are not remembered when restoring a session. Thanks a lot to Rahman Duran for the patch!
BUG: 181227
CCMAIL: rahman.duran@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=941226
2009-03-19 07:23:41 +00:00
Peter Penz 644938fcde SVN_SILENT: remove trailing spaces
svn path=/trunk/KDE/kdebase/apps/; revision=940620
2009-03-17 20:34:32 +00:00
Frank Reininghaus b9b9df7296 Ask for confirmation when closing a Dolphin window with more than one tab. This can be disabled by checking the "Do not ask again" checkbox in the confirmation dialog or in Dolphin's settings dialog.
FEATURE: 168417

svn path=/trunk/KDE/kdebase/apps/; revision=938767
2009-03-12 22:40:32 +00:00
Shaun Reich fb362b97a7 No need to set the accelerator manually, it's done automatically anyways(or it will be).
svn path=/trunk/KDE/kdebase/apps/; revision=938478
2009-03-11 22:41:57 +00:00
Shaun Reich 7a22141c55 This patch isn't needed anymore thanks to dfaure's up-coming patch to kmenu, the accelerator manager will automatically handle KMenu's.
svn path=/trunk/KDE/kdebase/apps/; revision=938471
2009-03-11 22:25:39 +00:00
Shaun Reich 6e4711a6a8 Changed i++ to ++i. I accidentally did the first when I first made the recently closed tabs feature (habitual).
svn path=/trunk/KDE/kdebase/apps/; revision=938422
2009-03-11 20:48:37 +00:00
Shaun Reich eba839113b The last commit made the menu be on the heap, this switches it back to stack... (I initially couldn't figure out how to do that (had to pass by reference)).
svn path=/trunk/KDE/kdebase/apps/; revision=938420
2009-03-11 20:47:46 +00:00
Shaun Reich a619ca0872 Changed a tab's KMenu to have it's accelerators managed automatically.
svn path=/trunk/KDE/kdebase/apps/; revision=938417
2009-03-11 20:31:09 +00:00
Peter Penz 7697cad99f Provide an "Open Terminal" entry for the Tools menu (thanks to Rahman Duran for the patch!)
BUG: 164746

svn path=/trunk/KDE/kdebase/apps/; revision=937624
2009-03-10 06:59:27 +00:00
Peter Penz 0e5b55b778 SVN_SILENT: comment update
svn path=/trunk/KDE/kdebase/apps/; revision=937623
2009-03-10 06:36:34 +00:00
Shaun Reich b23c00997a A change in focus between the split view, would not update the icon on the tab that it was in-now does.
svn path=/trunk/KDE/kdebase/apps/; revision=937597
2009-03-10 00:40:37 +00:00
Shaun Reich f320652966 The tab icon now obeys the icon of the folder that it is currently browsing. Before it would just use the "folder" icon, but it now finds the icon of that folder, and uses it.
BUG: 182702

svn path=/trunk/KDE/kdebase/apps/; revision=937595
2009-03-10 00:35:59 +00:00
Shaun Reich 0945eb5bc2 Added a few things to the "Recently Closed Tabs" menu:
* Paths now ellide when they get too big. That is, according to the font size, not character length.

* Added automatic mnemomics (or however you spell that crazy word) to the menu's items.

svn path=/trunk/KDE/kdebase/apps/; revision=937504
2009-03-09 19:50:32 +00:00
Shaun Reich abfa3fff9d The "Recently Closed Tabs" action menu now has a limit of 10, before it could just go on for practically ever, which would yield an annoyingly huge list of closed tabs.
svn path=/trunk/KDE/kdebase/apps/; revision=937477
2009-03-09 18:10:35 +00:00
Shaun Reich 9d7103f6ef There is no point in setting the text of a tab, each time a tab is selected, the only time we should have to do that is when we are using a split view.
This also kind of hides the Qt 4.5 tab bug (a very ugly one) from "regular" users (who don't use the split view).

svn path=/trunk/KDE/kdebase/apps/; revision=937116
2009-03-09 02:31:41 +00:00
Shaun Reich 86dd791791 Changed deprecated use of signal closeRequested(int) to tabCloseRequested(int)
svn path=/trunk/KDE/kdebase/apps/; revision=933837
2009-03-01 18:19:38 +00:00
Peter Penz 0d4306596a SVN_SILENT: minor coding style cleanups
svn path=/trunk/KDE/kdebase/apps/; revision=933598
2009-03-01 12:42:51 +00:00
Peter Penz 7a48b5fec1 removed Quick-View code (it has already been disabled before)
svn path=/trunk/KDE/kdebase/apps/; revision=933591
2009-03-01 12:23:05 +00:00
Peter Penz 3b98165a3f don't make the struct ClosedTab accessible for other classes
CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=933589
2009-03-01 12:20:23 +00:00
Shaun Reich dd89f93181 Fixed a bug in the "Recently Closed Tabs" menu that would cause it to show more recent tabs at the bottom.
The most recent tab will now always be shown right below the separator, which is right below the "Clear Recently Closed Tabs" action.

svn path=/trunk/KDE/kdebase/apps/; revision=933487
2009-03-01 02:27:35 +00:00
Shaun Reich 78e9cc506f Closed tabs are now remembered within Dolphin, so if you accidentally close them, or need to reopen a previous one-go crazy.
Closed tabs now become stored in the "Go"->"Recently Closed Tabs" menu.

To clear this list, there is an action within that menu. 

Clicking on a remembered tab's action, will remove that entry, restore that tab, and focus it.

svn path=/trunk/KDE/kdebase/apps/; revision=933483
2009-03-01 01:38:20 +00:00
Laurent Montel 00e6fb5c7b Fix warning about shortcut
svn path=/trunk/KDE/kdebase/apps/; revision=933227
2009-02-28 12:50:34 +00:00
Shaun Reich 7e7c14ba65 * Remove deprecated use of KTabBar::setCloseButtonEnabled(), use qt-provided method-QTabBar::setTabsClosable().
* Enable dragging of tabs thanks to the new feature in Qt 4.5, QTabBar::setMovable(), now that the KTabBar has been ported. The dragging is a very neat effect.

BUG: 164313

svn path=/trunk/KDE/kdebase/apps/; revision=930077
2009-02-22 17:06:15 +00:00
Shaun Reich 5cec8a2dd9 Middle-clicking on tabs will now close them.
svn path=/trunk/KDE/kdebase/apps/; revision=924467
2009-02-10 20:48:16 +00:00
Shaun Reich eb9dd90419 Changed the order of the shortcut for opening a new tab from Ctrl+Shift+N to Ctrl+T, so the latter is now the default, and is shown like that. It now shows up like the other items in the file menu. (it doesn't have a shift key modifier in it).
svn path=/trunk/KDE/kdebase/apps/; revision=922452
2009-02-07 04:47:04 +00:00
Peter Penz dc34436f23 Display correct folder names in tabs, if they contain a '&' character. Thanks to Frank Reininghaus for the patch!
BUG: 181765

svn path=/trunk/KDE/kdebase/apps/; revision=919021
2009-01-31 11:08:08 +00:00
Peter Penz 2033278815 minor coding style fixes (http://techbase.kde.org/Policies/Kdelibs_Coding_Style):
* use spaces instead of tabs
* correct braces

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=918537
2009-01-30 06:13:11 +00:00
Shaun Reich 6a0898178c The mouse wheel now works on Dolphin's tabs (to switch tabs), like just about every other KDE app.
svn path=/trunk/KDE/kdebase/apps/; revision=918498
2009-01-29 23:44:20 +00:00
Peter Penz d85a6ec6dd Use a custom SearchWidget instead directly using a KLineEdit. Currently the DolphinSearchWidget acts as "playground" to test some ideas. If it works well it might be a good idea moving this widget as KSearchBox (?) to kdelibs, so that it can be used by the file dialog or other applications.
svn path=/trunk/KDE/kdebase/apps/; revision=913572
2009-01-19 14:25:08 +00:00
Peter Penz be1298d9aa Provide a search box for the nepomuksearch:/ KIO slave. This is just an initial prototype to get some feedback, the search box and the URL navigator still need some love for this usecase...
CCMAIL: sebastian@trueg.de

svn path=/trunk/KDE/kdebase/apps/; revision=913451
2009-01-19 13:17:33 +00:00
Peter Penz 8acb68ed28 Relayout of the settings dialog, so that all Dolphin KPart relevant settings can be made available in Konqueror's settings dialog too. Further cleanups and layout fixes are required and will be done during the next week.
svn path=/trunk/KDE/kdebase/apps/; revision=912587
2009-01-17 18:42:06 +00:00
Peter Penz 6d6ac58d3f provide icons for "Places", "Folders", "Information" and "Terminal" actions, so that they can be added to the toolbar
BUG: 180847

svn path=/trunk/KDE/kdebase/apps/; revision=911845
2009-01-16 09:54:55 +00:00
Peter Penz f37ecd6ecf Cleanup panel related class names: The terms "sidebar"/"sidebarpage" are relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-)
svn path=/trunk/KDE/kdebase/apps/; revision=911089
2009-01-14 20:14:36 +00:00
Peter Penz 307285e963 Group classes into folders, Dolphin is too big in the meantime for having a flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later.
svn path=/trunk/KDE/kdebase/apps/; revision=911065
2009-01-14 19:26:23 +00:00
Peter Penz 86d9c40ab7 prevent that the user can open more than one instance of the settings dialog
svn path=/trunk/KDE/kdebase/apps/; revision=910588
2009-01-13 18:06:15 +00:00