Commit graph

2078 commits

Author SHA1 Message Date
David Faure 72f99574b4 don't complain about
KDirModel::indexForUrl: KUrl("") not found
every time the selection changes

svn path=/trunk/KDE/kdebase/apps/; revision=907756
2009-01-08 18:00:56 +00:00
Laurent Montel 054a5eca04 Fix compile with enable final
svn path=/trunk/KDE/kdebase/apps/; revision=907022
2009-01-07 12:27:38 +00:00
Laurent Montel c907d6cd6b Not necessary
svn path=/trunk/KDE/kdebase/apps/; revision=907018
2009-01-07 12:22:36 +00:00
Script Kiddy 580da51e01 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=906580
2009-01-06 12:52:00 +00:00
Peter Penz c11baf1ad5 fixed issue that the zoom slider tooltip showed the previous size when changing the slider with the mouse
svn path=/trunk/KDE/kdebase/apps/; revision=906188
2009-01-05 18:41:06 +00:00
Peter Penz b2db9bd9ed QAbstractItemView::scrollTo() may get called by QListView::keyPressEvent(), so m_enableScrollTo (which is checked in DolphinIconsView::scrollTo()) must be enabled before. This fixes the issue that the autoscrolling does not work if exactly one item is selected and an invisible item should get focused because of a key press.
BUG: 179049

svn path=/trunk/KDE/kdebase/apps/; revision=906179
2009-01-05 18:21:34 +00:00
Peter Penz 59ac1d10ae Only expand the tree view if it has an enabled 'itemsExpandable' property. If this is not the case, the folder will get opened like in the icon view by exchanging the whole content.
CCBUG: 178630

svn path=/trunk/KDE/kdebase/apps/; revision=905632
2009-01-04 18:35:32 +00:00
Peter Penz 291c9219a2 SVN_SILENT: minor coding style cleanups
svn path=/trunk/KDE/kdebase/apps/; revision=905631
2009-01-04 18:31:59 +00:00
Peter Penz 2872b35f4b Fixed issue that in combination with the "automatically open folders during drag operations" the details view is not drawn correctly in the following case: Drag an item in the icons view to a folder which uses the details view.
Thanks to Simon St. James for the patch!

CCBUG: 178630

svn path=/trunk/KDE/kdebase/apps/; revision=905627
2009-01-04 18:26:43 +00:00
Peter Penz 6f38e24dbb Don't set the mouse button state to NoButton, this is invalid e. g. during a drag operation. The mouse button state will be updated anyhow on each item-click. This fixes the regression that the feature "automatically open folders during drag operations" did not work anymore after one level.
Thanks to Simon St. James for the good analyzes!

BUG: 178630

svn path=/trunk/KDE/kdebase/apps/; revision=905622
2009-01-04 18:19:48 +00:00
Peter Penz 74f73dd2af SVN_SILENT: minor coding style cleanups
svn path=/trunk/KDE/kdebase/apps/; revision=905620
2009-01-04 18:14:26 +00:00
Script Kiddy fbd7cb02a5 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=905486
2009-01-04 13:22:16 +00:00
Simon Paul St James e896fc8e11 contentsPos turned out to be a little broken - it would always return (0,0), except in a very unusual set of circumstances where it returned ... "different" values, causing very odd behaviour with the elastic band :) Remove it.
svn path=/trunk/KDE/kdebase/apps/; revision=904995
2009-01-03 16:00:21 +00:00
Peter Penz 64059e5083 don't cache the preview of the information sidebar, as this restricts the maximum size to 256 x 256 pixels
svn path=/trunk/KDE/kdebase/apps/; revision=904639
2009-01-02 17:26:12 +00:00
Script Kiddy c6dbe9a31d SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=904551
2009-01-02 13:30:12 +00:00
Peter Penz bac6ebe5d3 Instead of increasing the grid spacing, increase the item size, so that there is more space for the text.
svn path=/trunk/KDE/kdebase/apps/; revision=904408
2009-01-02 09:04:16 +00:00
Laurent Montel da089e957c not necessary
svn path=/trunk/KDE/kdebase/apps/; revision=904391
2009-01-02 08:00:53 +00:00
Peter Penz 3fc700f042 fixed crash when enabling grouping by date and having dates like
30 December 2008 (is "Week 1" (of 2009 , but for 2008 too))
28 December 2008 (is "Week 52" (of 2008) )

Thanks to Darío Andrés for the patch!

BUG: 179019

svn path=/trunk/KDE/kdebase/apps/; revision=903432
2008-12-30 14:48:18 +00:00
Peter Penz 5194a032ac optimize the grid size of the icons view to prevent having gaps on the right border (= row arrangement) or on the bottom border (= column arrangement)
svn path=/trunk/KDE/kdebase/apps/; revision=903417
2008-12-30 14:32:45 +00:00
Peter Penz 46483d7c08 SVN_SILENT: minor coding style cleanups
svn path=/trunk/KDE/kdebase/apps/; revision=903414
2008-12-30 14:29:58 +00:00
Script Kiddy 8536030ea5 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=902470
2008-12-28 13:25:02 +00:00
Script Kiddy 649668d845 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=902162
2008-12-27 16:16:25 +00:00
Nuno Fernades Pinheiro 170ae64f6a fix bug Bug 177446 icons now in Oxygen
svn path=/trunk/KDE/kdebase/apps/; revision=902064
2008-12-27 15:07:16 +00:00
Script Kiddy 1123841d73 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=901727
2008-12-26 13:31:59 +00:00
Leonardo Finetti efbce1059c Patch by Drew Fisher: enable keypad enter in dolphin.
Tested by me and approved by Peter Penz.

BUG: 178735


svn path=/trunk/KDE/kdebase/apps/; revision=901630
2008-12-26 11:34:09 +00:00
Script Kiddy bba48e459d SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=901125
2008-12-24 13:32:45 +00:00
David Faure 818864ec48 Open the sidebar on applications:/, not on applications:, that URL makes no sense [and crashes kdirmodel...].
BUG: 178416

svn path=/trunk/KDE/kdebase/apps/; revision=901012
2008-12-24 11:45:09 +00:00
Peter Penz 86ee6dbd07 assure that the zoom slider tooltip is always updated when changing a value
svn path=/trunk/KDE/kdebase/apps/; revision=900577
2008-12-23 10:54:56 +00:00
Peter Penz e1ca3fc1ee revert SVN commit 899245: The patch does not work as expected.
CCMAIL: ereslibre@kde.org
CCBUG: 173027

svn path=/trunk/KDE/kdebase/apps/; revision=900071
2008-12-22 07:18:18 +00:00
Peter Penz 9f87bf8d88 minor coding style fixes:
* let the global variable 'others' be a static member 'm_others'
* constify

svn path=/trunk/KDE/kdebase/apps/; revision=900070
2008-12-22 07:17:06 +00:00
Peter Penz 49ec13f58e fixed ARK drop handling as suggested by Harald Hvaal
svn path=/trunk/KDE/kdebase/apps/; revision=899770
2008-12-21 15:14:03 +00:00
Script Kiddy 833ab70add SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=899710
2008-12-21 12:59:15 +00:00
Peter Penz 17033c5da6 When common view properties are used for all folders, the internal properties should not be changed during the lifetime of a DolphinView instance. This allows to e. g. split a view and work with different view modes on each view.
BUG: 174102

svn path=/trunk/KDE/kdebase/apps/; revision=899571
2008-12-21 10:15:19 +00:00
Script Kiddy 88ae4d94bc SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=899357
2008-12-20 14:39:35 +00:00
Peter Penz f2d61b242d Assure that the items within the "Others" group are sorted too, when sorting by name and using categorization.
@Rafael: Could you please have a look whether this patch is OK? It fixes bug 173027 but it is unclear for me why the deleted lines had been added at all. Thanks :-)

CCMAIL: ereslibre@kde.org
BUG: 173027

svn path=/trunk/KDE/kdebase/apps/; revision=899245
2008-12-20 12:54:46 +00:00
Peter Penz de2d93b068 minor improvement to last commit: only request the focus if we have a listable protocol; otherwise leave the focus where it was (e. g. so that the user can enter another URL)
svn path=/trunk/KDE/kdebase/apps/; revision=898822
2008-12-19 06:48:57 +00:00
Peter Penz 426a57997b Don't request the focus for the view because of a completed directory lister, instead directly request it when we know that the user has entered a new URL. This prevents that the focus gets stolen from the Terminal when somebody types "touch foo".
BUG: 178070

svn path=/trunk/KDE/kdebase/apps/; revision=898819
2008-12-19 06:41:26 +00:00
Peter Penz d05c4ba829 turn off the filter when closing the filterbar by CTRL+I
BUG: 177948

svn path=/trunk/KDE/kdebase/apps/; revision=897988
2008-12-17 10:35:02 +00:00
Peter Penz f9beadde75 assure that a column of the column view acts as focus proxy when being active
svn path=/trunk/KDE/kdebase/apps/; revision=897744
2008-12-16 18:52:26 +00:00
Peter Penz 94ef8919bf Assure that the view gets focused when:
* Enter or Ctrl+Enter is pressed in the URL navigator
* when the filter bar gets closed

BUG: 158232

svn path=/trunk/KDE/kdebase/apps/; revision=897739
2008-12-16 18:37:02 +00:00
David Faure 04f6e7b374 Ctrl+F when in trash:/ (or any other remote protocol) said "malformed url" because KRun tried to download to a temp file via kioexec. %u tells it not to do that.
Alternatively we could look up kfind.desktop and use KRun::run(KService).

svn path=/trunk/KDE/kdebase/apps/; revision=897114
2008-12-15 11:53:29 +00:00
Peter Penz d2fbbd44b4 * Don't ignore the maximum file size for previews in the information panel. Corresponding to bug 177740 creating a thumbnail for a 200 MB PNG consumes 700 MB temporary memory...
* Remember the created thumbnail for later reuse.

BUG: 177740

svn path=/trunk/KDE/kdebase/apps/; revision=896725
2008-12-14 11:25:44 +00:00
Peter Penz 44d2f43a40 When dropping an Amarok file into Dolphin, mimeData->hasUrls() returns true although the number of URLs is 0. I'll have to do further investigations to fix this in a clean way, but in the meantime this patch prevents opening an error dialog box.
CCBUG: 176580

svn path=/trunk/KDE/kdebase/apps/; revision=896517
2008-12-13 17:32:12 +00:00
Peter Penz 7fbc814147 only jump automatically to the current index, if the autoscrolling is not active
svn path=/trunk/KDE/kdebase/apps/; revision=896481
2008-12-13 15:39:09 +00:00
Peter Penz c91c770ef1 provide separate scroll increments for the horizontal and vertical scrolling
svn path=/trunk/KDE/kdebase/apps/; revision=896466
2008-12-13 15:29:42 +00:00
Peter Penz d0c97573d4 Especially when using the details view in combination with the split functionality, the size of the name column can get too small. Do an optimized resizing in this case (at least for up to 200 items, otherwise the performance penalty is too big).
svn path=/trunk/KDE/kdebase/apps/; revision=896446
2008-12-13 15:15:04 +00:00
Peter Penz 99271699f3 Handling the key events for autoscrolling in DolphinViewAutoscroller does not work good enough (e. g. when letters are pressed, the current index might change too). Revert to Frank Reininhaus' original patch to fix this issue :-)
CCMAIL: frank78ac@googlemail.com

svn path=/trunk/KDE/kdebase/apps/; revision=896362
2008-12-13 14:08:07 +00:00
Peter Penz a86985b0b4 The nasty "100 ms" delay is not necessary anymore, doing a queued call works perfectly to restore the contents position of a view.
CCMAIL: kdedevel@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=896237
2008-12-12 22:33:14 +00:00
Peter Penz 3b4e44d6da if "split view" is used as startup setting, also open new tabs in the split view mode
BUG: 176980

svn path=/trunk/KDE/kdebase/apps/; revision=896206
2008-12-12 20:30:23 +00:00
Peter Penz 37c5fc0813 If the users enters an URL that represents a file, open the file by the corresponding application instead of showing an error message.
BUG: 165877

svn path=/trunk/KDE/kdebase/apps/; revision=896189
2008-12-12 19:44:28 +00:00