Commit graph

6879 commits

Author SHA1 Message Date
Nicolas Fella
1041b52c7a Don't crash when mountpoint is not found
findByPath may return a nullptr, in that case don't access it

BUG: 452100
2022-03-31 23:24:59 +02:00
l10n daemon script
a8966d230c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-29 03:51:20 +00:00
l10n daemon script
c7531ba749 GIT_SILENT made messages (after extraction) 2022-03-29 03:00:38 +00:00
Kai Uwe Broulik
466fa20f7f [ViewProperties] Apply better default roles for special views
This adds the following additional special view modes (some of them were
already there but broken because they weren't applied, or were
changed to have better defaults now that they are actually used):

* Recent Files and Recent Documents, timeline:
  Details view with grouped sorting enabled and Name, Path, Modified
* Search For Images:
  Icon view with Name, Dimensions, Date Time of the Picture
* Search For Audio:
  Details view with Name, Artist, Album, Duration
* Search For Videos:
  Icon view with just Name
* Search For everything else, including Documents:
  Details view with Name, Path, Modified
* Trash:
  Details view with Name, (Original) Path, Deletion Time

BUG: 400969
BUG: 340393
BUG: 186376
FIXED-IN: 22.04.0
2022-03-28 14:56:49 +02:00
Kai Uwe Broulik
e304aa79b4 [ViewProperties] Consider existing roles in convertAdditionalInfo
Otherwise all default overrides for roles we perform in this class are moot.
2022-03-28 14:52:15 +02:00
l10n daemon script
0a9c018497 GIT_SILENT made messages (after extraction) 2022-03-23 02:46:59 +00:00
Nicolas Fella
1cd00946c4 Port to target-based ecm_add_app_icon 2022-03-21 20:43:31 +01:00
l10n daemon script
109eb3334d SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-20 03:39:12 +00:00
l10n daemon script
3c1ebfcfb1 GIT_SILENT made messages (after extraction) 2022-03-20 02:49:46 +00:00
Albert Astals Cid
f9baca9288 GIT_SILENT Upgrade release service version to 22.03.80. 2022-03-12 12:20:04 +01:00
Anthony Fieroni
94acf0ba0b Pass dolphin view as parent widget to plugins
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
2022-03-11 08:20:09 +02:00
l10n daemon script
ecda1e9500 GIT_SILENT made messages (after extraction) 2022-03-11 00:51:19 +00:00
l10n daemon script
7c6a34222c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-07 01:44:55 +00:00
l10n daemon script
3366f62b09 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-03-05 01:48:28 +00:00
l10n daemon script
62f1897e59 GIT_SILENT made messages (after extraction) 2022-03-05 00:47:08 +00:00
Kai Uwe Broulik
df79f5b477 [Places Panel] Reject drops on unwritable locations
Indicate that you cannot drop here.

Avoids a "Cannot drop file" or "not supported" error when
dropping files ontop of a search or timeline URL.

It is done in Dolphin rather than the library as there we cannot
assume what a consumer might be doing with the drop.
2022-03-04 18:25:38 +00:00
David Edmundson
b6e03e05f4 Fix issue where newly inserted items end up in the wrong directory
If we have directory "a" and "a/b" and expand both, then collapse "a" we
tell KDirWatcher to stop watching both these directories.

However, KDirWatcher keeps them in the listersCurrentlyHolding list as
well as the listersCurrentlyListing list and will still notify of
changes. If a new file appears in "a/b/" we will still get change
notifications.

When dolphin processes these changes we cannot find the relevant parent
node. It then gets confused and inserts the item into the root directory
from the POV of the model notifications. When we then open the relevant
folder the model knows a node with that URL exists and fails to add it
correctly.

This can also be reproduced by continually downloading files into a
subdirectory tree and rapidly expanding and collapsing folders a few
levels deep.
2022-03-04 10:57:16 +00:00
Felix Ernst
cd369a1519 Always select items on activation
There is an unintended side-effect in
d383961719 which this MR fixes.

Normally in Dolphin, when clicking on an item to open/activate it,
it is both selected by the click and opened/activated.

Prior to this MR, the item wasn't selected when all of these
conditions were met:
- Use ActivateItemOnSingleClick also knwon as single-click mode
- Have more than one item selected already
- Click on an item that was previously not selected

Prior to this MR, the click would deselect all items and
activate the clicked item but not select it.

With this MR, the click will deselect all items, activate
the clicked item and also select it and move the anchor there.

When testing this with folders, make sure to navigate back after activating the folder. The folder should then still be selected.

This is then consistent with the behaviour when the specific
conditions mentioned above are not met.
2022-03-04 10:41:50 +00:00
Janet Blackquill
e8dc49e4b2 KItemListHeaderWidget: don't crash if widget == nullptr
BUG: 449238
2022-03-03 16:02:29 +00:00
Stefano Crocco
505bf52f59 Display Apply button in KCMs
When displaying the KCMs in another application's configuration dialog
(for example, in Konqueror), the Apply, Ok and Reset buttons aren't
shown. This issue is caused by a missing Apply flag in the call to
setButtons in the KCModule constructor.

the fact that in the call to setButtons
from the KCModule constructor, the Apply flag is missing.

BUG: 448352
2022-03-01 12:00:37 +01:00
Heiko Becker
f73183c0f6 GIT_SILENT Update Appstream for new release
(cherry picked from commit 3ac70fe65b)
2022-02-27 19:01:08 +01:00
l10n daemon script
7a9aa9076f GIT_SILENT made messages (after extraction) 2022-02-27 00:52:17 +00:00
Jan Blackquill
3ce9d1d19e KStandardItemListWidget: don't double up the expansion offset 2022-02-26 00:48:00 -05:00
Kai Uwe Broulik
c68f1f6f8d Merge branch 'release/21.12' 2022-02-25 21:03:36 +01:00
Eugene Popov
8250961206 [CompactView] Remove animation on file rename
This MR fixes an issue where the label is cut off when renaming in Compact View mode.

BUG: 449179
FIXED-IN: 22.04
2022-02-25 19:37:01 +00:00
Ismael Asensio
c623522ecb [DolphinQueryTest] Fix class name duplication 2022-02-25 19:23:18 +00:00
Janet Blackquill
ddba4f5fd8 KStandardItemListWidget: handle RtL drawing properly
BUG: 449211
2022-02-25 16:35:05 +00:00
Kai Uwe Broulik
d031696a92 Fix rating pixmap alignment on high-dpi screens
When calculating layout geometry based on the pixmap size,
one needs to divide by `devicePixelRatio`
2022-02-23 20:44:22 +01:00
Kai Uwe Broulik
cd81906550 Ignore empty roles for textRect calculation
Avoids a text rect taller than the area that actually contains text,
as can be seen by hovering files in a folder with "additional roles"
that a given file does not contain.
2022-02-23 20:27:33 +01:00
l10n daemon script
d774088a52 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-02-20 01:50:36 +00:00
l10n daemon script
78753ad23c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-02-18 01:51:42 +00:00
l10n daemon script
c0f86d3a58 GIT_SILENT made messages (after extraction) 2022-02-16 02:18:21 +00:00
l10n daemon script
b6e47b4750 GIT_SILENT made messages (after extraction) 2022-02-16 00:48:33 +00:00
Eugene Popov
a05343530d Fix zooming animation
Current implementation of the zooming animation is a bit buggy.
This MR fixes the following issues:
* in the Icon view mode, the icons sometimes "jump"
* in the Compact view mode, the labels sometimes are cut off

BUG: 449179
2022-02-13 12:16:34 +00:00
Kai Uwe Broulik
e9bd295b3c [Places Panel] Make use of KFilePlacesView::dragAutoActivationDelay
Code moved to KIO
2022-02-07 07:29:35 +00:00
Ben Cooksley
d0898592a1 Use the CDN based endpoint rather than the legacy endpoint which hits our download redirector.
CCMAIL: distributions@kde.org

(cherry picked from commit 694e4e2452)
2022-02-07 06:19:51 +13:00
l10n daemon script
32c072fe5f SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-02-06 01:58:24 +00:00
Kai Uwe Broulik
0dac70d059 Hide "Places" section header when panels are unlocked
Avoids showing "Places" twice.
2022-02-05 22:18:28 +00:00
Kai Uwe Broulik
f645e6b4b2 Store model as a DolphinPlacesModel
Because that's what it is. It's a subclass anyway but saves us some
casts in the future.
2022-02-05 22:18:28 +00:00
l10n daemon script
cd6664c569 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2022-02-05 01:47:47 +00:00
Nicolas Fella
ce7852fb23 Merge branch 'release/21.12' 2022-02-04 12:58:29 +01:00
Nicolas Fella
3b4676b387 Fix opening FTP files in their preferred app
When passing an URL like ftp://foo/bar.txt OpenUrlJob opens it in the default handler for ftp urls, not the one for txt files, which would be more appropriate here

By passing along the mimetype we can change that behavior to what we want

BUG: 443253
2022-02-04 00:18:00 +01:00
Méven Car
08a9aaad2c InformationPanel: Improve video arrow overlay appearance 2022-02-02 18:16:59 +01:00
Bharadwaj Raju
487e95376d Don't set ignoreMaximumSize on preview jobs for slow files
With this change (plus https://invent.kde.org/frameworks/kio/-/merge_requests/702), slow files will be treated as remote files for generating previews. This should make browsing local mounts of remote locations smoother.
2022-02-02 09:41:10 +00:00
Méven Car
851b356f38 Dimension role: use × instead of x 2022-01-31 20:35:58 +01:00
Nicolas Fella
ca35c71f3d Improve placeholder message for unassigned tag
When opening tags:/ we show 'No tags' when there are no tags found.

When opening a tag that exists but doesn't have any files associated we show the same message, which isnt't appropriate.

Instead show "No files tagged with 'foo'", which makes more sense
2022-01-31 18:16:29 +00:00
Kai Uwe Broulik
1c5b6d4d10 Add "Unlock panels" to main window context menu
It's the Qt-provided one that shows on the menu bar
and dock widget title bars.
2022-01-31 12:06:08 +00:00
Kai Uwe Broulik
d68bb06e89 Sync panel action icon to built-in toggleViewAction
Ensures the icon is used consistently also in Qt-provided UI
2022-01-29 20:33:23 +00:00
Felix Ernst
64af89a3ff Fix my previous bad merge
I failed to notice that the changes didn't apply cleanly. With this
commit everything should be a-okay again.
2022-01-29 18:47:40 +01:00
Felix Ernst
793ad44cb8 Merge branch 'release/21.12' 2022-01-29 18:14:49 +01:00