Commit graph

2082 commits

Author SHA1 Message Date
Shaun Reich bacc9c9137 The "Show 'Delete' Command" checkbox now gets restored to it's default (false).
svn path=/trunk/KDE/kdebase/apps/; revision=919996
2009-02-02 02:38:42 +00:00
Shaun Reich 9587d04b80 These radio buttons are paired, when you enable one, you inherently disable the other, so we're just repeating ourselves by doing this manually.
svn path=/trunk/KDE/kdebase/apps/; revision=919995
2009-02-02 02:34:57 +00:00
Simon Paul St James b1d8854ad2 Hovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want. Detect and prevent it.
BUG:182618

Shipped! ;)

svn path=/trunk/KDE/kdebase/apps/; revision=919950
2009-02-01 22:03:04 +00:00
Shaun Reich e3bf301477 I forgot to change these three tabs to the new method usage also. Effected was the View Modes page.
svn path=/trunk/KDE/kdebase/apps/; revision=919919
2009-02-01 21:01:06 +00:00
Shaun Reich 9f7c2424d9 Now when you click the button "Defaults" in the settings dialog, it will push the settings to the UI, then the user can apply, cancel, or modify them from there. Also removed the message box prompt. Use settings->useDefaults(true), then set it back to false after you are done loading settings in the restoreDefaults() method calls. Don't use ->setDefaults() normally, anymore.
svn path=/trunk/KDE/kdebase/apps/; revision=919897
2009-02-01 20:43:26 +00:00
Script Kiddy 3df531dcf6 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=919783
2009-02-01 16:24:40 +00:00
Peter Penz 8e13b80d5f Replace patch for bug 181226 by a different approach, as the previous patch resulted in a changed behavior when using the double-click mode (-> a treeview item had to be pressed twice to show it in the main view).
CCBUG: 172360
CCBUG: 181226

svn path=/trunk/KDE/kdebase/apps/; revision=919648
2009-02-01 14:08:40 +00:00
Script Kiddy d56646dd0f SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=919234
2009-01-31 15:57:53 +00:00
Peter Penz e5edeb7446 Postpone the creating of the media object until the play- or stop-button has been pressed. This solves the issue that Dolphin might get blocked during hovering media files. Dolphin still gets blocked when requesting a media object the first time, but for the user this "just" means that after pressing the play-button the first time, that the playing starts a little bit later.
CCMAIL: kretz@kde.org
CCMAIL: kdedevel@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=919063
2009-01-31 13:04:40 +00:00
Peter Penz 68a7ed8bcf Don't delete and recreate the phonon widget each time the URL changes, use the existing widget instance if possible.
svn path=/trunk/KDE/kdebase/apps/; revision=919058
2009-01-31 12:42:01 +00:00
Peter Penz 29a5af6390 * move the search button to the end
* use the default search icon instead of the nepomuk icon

svn path=/trunk/KDE/kdebase/apps/; revision=919051
2009-01-31 12:21:52 +00:00
Peter Penz 341f8456f0 Allow to enable/disable the "Expandable Folders" setting of the details-view by the context menu of the header.
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=919035
2009-01-31 11:36:44 +00:00
Peter Penz dc34436f23 Display correct folder names in tabs, if they contain a '&' character. Thanks to Frank Reininghaus for the patch!
BUG: 181765

svn path=/trunk/KDE/kdebase/apps/; revision=919021
2009-01-31 11:08:08 +00:00
Peter Penz 1f3916a222 SVN_SILENT: just mention what the method does, skip implementation details
svn path=/trunk/KDE/kdebase/apps/; revision=918538
2009-01-30 06:16:13 +00:00
Peter Penz 2033278815 minor coding style fixes (http://techbase.kde.org/Policies/Kdelibs_Coding_Style):
* use spaces instead of tabs
* correct braces

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=918537
2009-01-30 06:13:11 +00:00
Shaun Reich 6a0898178c The mouse wheel now works on Dolphin's tabs (to switch tabs), like just about every other KDE app.
svn path=/trunk/KDE/kdebase/apps/; revision=918498
2009-01-29 23:44:20 +00:00
Script Kiddy 444310cff0 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=918487
2009-01-29 23:37:07 +00:00
Shaun Reich 2632ea2643 Default size and Preview size sliders, were using wrong signal to notify that settings have changed. The keyboard, when used on the slider, wouldn't enable the apply button, nor clicking to either side of the slider to change it. sliderMoved signal emission changed to valueChanged. Effects all tabs in Settings Dialog->View Modes.
svn path=/trunk/KDE/kdebase/apps/; revision=917972
2009-01-28 21:27:16 +00:00
Script Kiddy 527f6e9290 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=917787
2009-01-28 15:01:35 +00:00
Simon Paul St James 9d3ed99ab0 Initial import of Matthias's draft patch for adding video and audio previewing (similar to the file dialog) to Dolphin's metadata panel. Since Phonon is currently in-process only with the memory/ stability issues that come with this, this might have to be disabled by default - we'll see how it goes. Thanks, Matthias!
CCMAIL:kretz@kde.org
CCMAIL:peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=917389
2009-01-27 19:50:21 +00:00
Shaun Reich 68b3e86fdf The apply button in the settings dialog now disables itself when settings are applied, as per all of the other KDE applications, added in DolphinSettingsDialog::applySettings(). It was already setup to re-enable on a settings change.
svn path=/trunk/KDE/kdebase/apps/; revision=917168
2009-01-27 01:13:03 +00:00
David Faure 591fde8f4a Don't crash if parentWidget is 0 (even though I don't recommend setting it to 0, the dirlister mainwindow won't be set if you reparent the widget later on)
BUG: 161681

svn path=/trunk/KDE/kdebase/apps/; revision=916972
2009-01-26 15:45:39 +00:00
Simon Paul St James 248ce7c57a Refactor the folder expansion system. Main effect: instead of having a list of m_expandedViews which cannot yet be deleted, we more accurately identify the current source of the drag operation if any and store only this for later deletion.
This also fixes folder-expansion not working in Column view.

svn path=/trunk/KDE/kdebase/apps/; revision=916701
2009-01-25 19:46:08 +00:00
Simon Paul St James 5b8a817a73 In rare circumstances (a very narrow viewport is a necessary, but not sufficient, condition) DolphinDetailsView::resizeColumns() is called with an empty model so that sizeHintForColumn(...) returns -1 and so the name column ultimately has width -1. Detect and prevent this.
svn path=/trunk/KDE/kdebase/apps/; revision=915781
2009-01-23 18:55:08 +00:00
Simon Paul St James 5b5f0c9d7e Two KFilePreviewGenerator's operating on the same KDirModel can lead to infinite loops of preview generation. If view is not delete'd (e.g. as a result of a FolderExpander), then m_previewGenerator won't be either: delete it manually to prevent having two active at once.
svn path=/trunk/KDE/kdebase/apps/; revision=914799
2009-01-21 19:43:41 +00:00
Sebastian Trueg 02781d747d Only actually change the resource if tags were changed.
svn path=/trunk/KDE/kdebase/apps/; revision=914234
2009-01-20 17:41:56 +00:00
Simon Paul St James 9aa43f8bae Update the KPart host's status bar info when selection changes.
svn path=/trunk/KDE/kdebase/apps/; revision=913713
2009-01-19 19:11:38 +00:00
Peter Penz 41dd38c07c don't use any spacing between the search button and the input field
svn path=/trunk/KDE/kdebase/apps/; revision=913589
2009-01-19 15:02:09 +00:00
David Faure 056b6855d3 Fix lack of error handling in RMB/Move To... (e.g. when src is root-owned) because the parent for KonqOperations
was the popupmenu, which gets deleted before the job finishes.

svn path=/trunk/KDE/kdebase/apps/; revision=913576
2009-01-19 14:33:10 +00:00
Peter Penz d85a6ec6dd Use a custom SearchWidget instead directly using a KLineEdit. Currently the DolphinSearchWidget acts as "playground" to test some ideas. If it works well it might be a good idea moving this widget as KSearchBox (?) to kdelibs, so that it can be used by the file dialog or other applications.
svn path=/trunk/KDE/kdebase/apps/; revision=913572
2009-01-19 14:25:08 +00:00
Peter Penz be1298d9aa Provide a search box for the nepomuksearch:/ KIO slave. This is just an initial prototype to get some feedback, the search box and the URL navigator still need some love for this usecase...
CCMAIL: sebastian@trueg.de

svn path=/trunk/KDE/kdebase/apps/; revision=913451
2009-01-19 13:17:33 +00:00
Peter Penz ed7d5e466f use correct icon
svn path=/trunk/KDE/kdebase/apps/; revision=913415
2009-01-19 11:12:24 +00:00
Peter Penz 514fe2be7e added settings module 'General' that can be used by Konqueror
svn path=/trunk/KDE/kdebase/apps/; revision=913414
2009-01-19 11:11:11 +00:00
Peter Penz a038b894db * enable the apply button when settings have been changed
* restore default settings correctly

svn path=/trunk/KDE/kdebase/apps/; revision=913412
2009-01-19 11:10:04 +00:00
Peter Penz 0772ebc3aa added settings module for 'Navigation', that can be used by Konqueror
svn path=/trunk/KDE/kdebase/apps/; revision=913405
2009-01-19 10:39:11 +00:00
Peter Penz d522c6701d hide the tooltips when a key is pressed (thanks to Shaun Reich for the initial patch)
CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=913383
2009-01-19 08:57:35 +00:00
Harald Sitter 920307602b Fix Dolphin's desktop file. The additional quotation of %u made dolphin be started with an empty (but existing) location value which made it fall back to XDG's document path as of KDE 4.2. Without
quotation it doesn't get that empty value and starts using it's configured default location.
BUG: 169016

svn path=/trunk/KDE/kdebase/apps/; revision=912654
2009-01-17 23:07:46 +00:00
Peter Penz 8acb68ed28 Relayout of the settings dialog, so that all Dolphin KPart relevant settings can be made available in Konqueror's settings dialog too. Further cleanups and layout fixes are required and will be done during the next week.
svn path=/trunk/KDE/kdebase/apps/; revision=912587
2009-01-17 18:42:06 +00:00
David Faure 9e6b85cd6e Remove useless code, replaced with slotRedirection.
svn path=/trunk/KDE/kdebase/apps/; revision=912124
2009-01-16 18:47:40 +00:00
David Faure f56446a61a Repair redirections in DolphinPart, it used to notify of redirections by connecting to urlChanged,
but iirc there were recent changes which make dolphinview emit redirection instead of urlChanged in that case
Makes me wonder if urlChanged is still useful for anything?
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=911974
2009-01-16 13:21:33 +00:00
Peter Penz 185f35da3a Pressing "Enter" in the folders panel should open the folder in the main view. Thanks to Darío Andrés for the patch!
BUG: 172360

svn path=/trunk/KDE/kdebase/apps/; revision=911855
2009-01-16 10:28:25 +00:00
Peter Penz 6d6ac58d3f provide icons for "Places", "Folders", "Information" and "Terminal" actions, so that they can be added to the toolbar
BUG: 180847

svn path=/trunk/KDE/kdebase/apps/; revision=911845
2009-01-16 09:54:55 +00:00
Peter Penz 24b3fb6f6c cleanup sort order, so that it is easier later to split the files into several CMakeLists.txt
svn path=/trunk/KDE/kdebase/apps/; revision=911094
2009-01-14 20:22:17 +00:00
Peter Penz f37ecd6ecf Cleanup panel related class names: The terms "sidebar"/"sidebarpage" are relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-)
svn path=/trunk/KDE/kdebase/apps/; revision=911089
2009-01-14 20:14:36 +00:00
Peter Penz 307285e963 Group classes into folders, Dolphin is too big in the meantime for having a flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later.
svn path=/trunk/KDE/kdebase/apps/; revision=911065
2009-01-14 19:26:23 +00:00
Peter Penz 86d9c40ab7 prevent that the user can open more than one instance of the settings dialog
svn path=/trunk/KDE/kdebase/apps/; revision=910588
2009-01-13 18:06:15 +00:00
Stefan Monov 942778cb2a someone forgot to move the comment along with the code ;)
svn path=/trunk/KDE/kdebase/apps/; revision=909814
2009-01-12 10:11:30 +00:00
Peter Penz d15ff33059 SVN_SILENT: fixed indentation (was a mix of 1, 2 or 4 spaces...)
svn path=/trunk/KDE/kdebase/apps/; revision=909451
2009-01-11 16:35:07 +00:00
Peter Penz 6d2904ec48 add action "Close Tab" to the file menu, so that users get the chance to discover the key shortcut
svn path=/trunk/KDE/kdebase/apps/; revision=909450
2009-01-11 16:28:42 +00:00
Peter Penz db5ee5f2a6 raise() and activateWindow() are not needed in this case
svn path=/trunk/KDE/kdebase/apps/; revision=908812
2009-01-10 14:27:07 +00:00