From fa04e37569a316b3aaab3ca9fc42d50501347fd8 Mon Sep 17 00:00:00 2001 From: Andreas Krutzler Date: Fri, 10 Nov 2017 19:32:53 -0700 Subject: [PATCH] Prevent "Two clicks renaming" if the selected file/folder is not movable Summary: Two clicks renaming doesn't check if the user is actually allowed to rename a file/folder. With this patch, this get fixed. Depends on D7647 Reviewers: rkflx, #dolphin, ngraham Reviewed By: #dolphin, ngraham Subscribers: elvisangelaccio, ngraham, #dolphin Differential Revision: https://phabricator.kde.org/D8740 --- src/views/dolphinview.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index 4485c17079..cd802eec1c 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -1125,8 +1125,12 @@ void DolphinView::slotMouseButtonPressed(int itemIndex, Qt::MouseButtons buttons void DolphinView::slotSelectedItemTextPressed(int index) { if (GeneralSettings::renameInline()) { - m_twoClicksRenamingItemUrl = m_model->fileItem(index).url(); - m_twoClicksRenamingTimer->start(QApplication::doubleClickInterval()); + const KFileItem item = m_model->fileItem(index); + const KFileItemListProperties capabilities(KFileItemList() << item); + if (capabilities.supportsMoving()) { + m_twoClicksRenamingItemUrl = item.url(); + m_twoClicksRenamingTimer->start(QApplication::doubleClickInterval()); + } } }