From e26ee6455e408654de7e31a8ba84d44056d08bc2 Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Sat, 27 Oct 2018 16:53:59 +0200 Subject: [PATCH] Don't enable two-clicks renaming in single-click mode Summary: This was supposed to be part of commit 5454283008f2, but apparently we didn't notice it was missing. Test Plan: - Enable single-click mode from system settings - Select a file in dolphin - Long-click the selected file and make sure inline renaming doesn't start Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D16460 --- src/views/dolphinview.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index 1db62b8003..3bb71089f6 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -1116,7 +1116,7 @@ void DolphinView::slotMouseButtonPressed(int itemIndex, Qt::MouseButtons buttons void DolphinView::slotSelectedItemTextPressed(int index) { - if (GeneralSettings::renameInline()) { + if (GeneralSettings::renameInline() && !m_view->style()->styleHint(QStyle::SH_ItemView_ActivateItemOnSingleClick)) { const KFileItem item = m_model->fileItem(index); const KFileItemListProperties capabilities(KFileItemList() << item); if (capabilities.supportsMoving()) {