From f38d788a97fe195e3257bccdd351162bd14c1ac9 Mon Sep 17 00:00:00 2001 From: Felix Ernst Date: Mon, 16 Oct 2023 16:50:07 +0200 Subject: [PATCH] Never show status bar context menu away from status bar The status bar context menu was hard-coded to always appear at the cursor position. However, context menus can also be triggered by keyboard, for example with the Menu key, in which case it makes no sense to show the context menu at whatever random position the mouse cursor currently is. Instead invoke the context menu in the middle of the status bar when it is opened by keyboard. --- src/statusbar/dolphinstatusbar.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/statusbar/dolphinstatusbar.cpp b/src/statusbar/dolphinstatusbar.cpp index 9c101b3fa..9830960dc 100644 --- a/src/statusbar/dolphinstatusbar.cpp +++ b/src/statusbar/dolphinstatusbar.cpp @@ -269,7 +269,7 @@ void DolphinStatusBar::contextMenuEvent(QContextMenuEvent *event) showSpaceInfoAction->setCheckable(true); showSpaceInfoAction->setChecked(GeneralSettings::showSpaceInfo()); - const QAction *action = menu.exec(QCursor::pos()); + const QAction *action = menu.exec(event->reason() == QContextMenuEvent::Reason::Mouse ? QCursor::pos() : mapToGlobal(QPoint(width() / 2, height() / 2))); if (action == showZoomSliderAction) { const bool visible = showZoomSliderAction->isChecked(); GeneralSettings::setShowZoomSlider(visible);