From f267544472905c44d5d9721d18a5a6785bccb3ee Mon Sep 17 00:00:00 2001 From: Felix Ernst Date: Sun, 23 Oct 2022 19:37:50 +0200 Subject: [PATCH] Fix view mode-specific settings not always applying When the current view mode is different from the view mode for which settings were changed in Dolphin's settings dialog, those changes were sometimes not present when then changing the view mode of a view to the view mode for which settings were changed. This commit fixes this by always loading the settings for all view modes in the DolphinItemListView even if the view is currently using only one of those view modes. --- src/views/dolphinitemlistview.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/views/dolphinitemlistview.cpp b/src/views/dolphinitemlistview.cpp index 60d5577b83..5dec2b1f88 100644 --- a/src/views/dolphinitemlistview.cpp +++ b/src/views/dolphinitemlistview.cpp @@ -77,8 +77,10 @@ void DolphinItemListView::setEnabledSelectionToggles(DolphinItemListView::Select void DolphinItemListView::readSettings() { - ViewModeSettings settings(itemLayout()); - settings.readConfig(); + // We load the settings for all view modes now because we don't load them when the view mode changes. + IconsModeSettings::self()->load(); + CompactModeSettings::self()->load(); + DetailsModeSettings::self()->load(); beginTransaction();