kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-10-28 03:21:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Consti'fy

Browse source
This commit is contained in:
Laurent Montel 2019-01-11 07:03:26 +01:00
parent d099123841
commit e5ebb31e54
5 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/kitemviews/kfileitemmodel.cpp
View file

@ -1717,8 +1717,8 @@ bool KFileItemModel::lessThan(const ItemData* a, const ItemData* b, const QColla
return (sortOrder() == Qt::AscendingOrder) ? result < 0 : result > 0; return (sortOrder() == Qt::AscendingOrder) ? result < 0 : result > 0;
} }
void KFileItemModel::sort(QList<KFileItemModel::ItemData*>::iterator begin, void KFileItemModel::sort(const QList<KFileItemModel::ItemData*>::iterator &begin,
QList<KFileItemModel::ItemData*>::iterator end) const const QList<KFileItemModel::ItemData*>::iterator &end) const
{ {
auto lambdaLessThan = [&] (const KFileItemModel::ItemData* a, const KFileItemModel::ItemData* b) auto lambdaLessThan = [&] (const KFileItemModel::ItemData* a, const KFileItemModel::ItemData* b)
{ {
@ -1982,7 +1982,7 @@ QList<QPair<int, QVariant> > KFileItemModel::sizeRoleGroups() const
return groups; return groups;
} }
QList<QPair<int, QVariant> > KFileItemModel::timeRoleGroups(std::function<QDateTime(const ItemData *)> fileTimeCb) const QList<QPair<int, QVariant> > KFileItemModel::timeRoleGroups(const std::function<QDateTime(const ItemData *)> &fileTimeCb) const
{ {
Q_ASSERT(!m_itemData.isEmpty()); Q_ASSERT(!m_itemData.isEmpty());

4
src/kitemviews/kfileitemmodel.h
View file

@ -371,7 +371,7 @@ private:
* Sorts the items between \a begin and \a end using the comparison * Sorts the items between \a begin and \a end using the comparison
* function lessThan(). * function lessThan().
*/ */
void sort(QList<ItemData*>::iterator begin, QList<ItemData*>::iterator end) const; void sort(const QList<ItemData*>::iterator &begin, const QList<ItemData*>::iterator &end) const;
/** /**
* Helper method for lessThan() and expandedParentsCountCompare(): Compares * Helper method for lessThan() and expandedParentsCountCompare(): Compares
@ -386,7 +386,7 @@ private:
QList<QPair<int, QVariant> > nameRoleGroups() const; QList<QPair<int, QVariant> > nameRoleGroups() const;
QList<QPair<int, QVariant> > sizeRoleGroups() const; QList<QPair<int, QVariant> > sizeRoleGroups() const;
QList<QPair<int, QVariant> > timeRoleGroups(std::function<QDateTime(const ItemData *)> fileTimeCb) const; QList<QPair<int, QVariant> > timeRoleGroups(const std::function<QDateTime(const ItemData *)> &fileTimeCb) const;
QList<QPair<int, QVariant> > permissionRoleGroups() const; QList<QPair<int, QVariant> > permissionRoleGroups() const;
QList<QPair<int, QVariant> > ratingRoleGroups() const; QList<QPair<int, QVariant> > ratingRoleGroups() const;
QList<QPair<int, QVariant> > genericStringRoleGroups(const QByteArray& typeForRole) const; QList<QPair<int, QVariant> > genericStringRoleGroups(const QByteArray& typeForRole) const;

2
src/kitemviews/kfileitemmodelrolesupdater.cpp
View file

@ -405,7 +405,7 @@ void KFileItemModelRolesUpdater::slotItemsRemoved(const KItemRangeList& itemRang
} }
} }
void KFileItemModelRolesUpdater::slotItemsMoved(const KItemRange& itemRange, QList<int> movedToIndexes) void KFileItemModelRolesUpdater::slotItemsMoved(const KItemRange& itemRange, const QList<int> &movedToIndexes)
{ {
Q_UNUSED(itemRange); Q_UNUSED(itemRange);
Q_UNUSED(movedToIndexes); Q_UNUSED(movedToIndexes);

2
src/kitemviews/kfileitemmodelrolesupdater.h
View file

@ -157,7 +157,7 @@ public:
private slots: private slots:
void slotItemsInserted(const KItemRangeList& itemRanges); void slotItemsInserted(const KItemRangeList& itemRanges);
void slotItemsRemoved(const KItemRangeList& itemRanges); void slotItemsRemoved(const KItemRangeList& itemRanges);
void slotItemsMoved(const KItemRange& itemRange, QList<int> movedToIndexes); void slotItemsMoved(const KItemRange& itemRange, const QList<int> &movedToIndexes);
void slotItemsChanged(const KItemRangeList& itemRanges, void slotItemsChanged(const KItemRangeList& itemRanges,
const QSet<QByteArray>& roles); const QSet<QByteArray>& roles);
void slotSortRoleChanged(const QByteArray& current, void slotSortRoleChanged(const QByteArray& current,

2
src/tests/kitemlistcontrollertest.cpp
View file

@ -197,7 +197,7 @@ struct KeyPress {
*/ */
struct ViewState { struct ViewState {
ViewState(int current, const KItemSet selection, bool activated = false) : ViewState(int current, const KItemSet &selection, bool activated = false) :
m_current(current), m_current(current),
m_selection(selection), m_selection(selection),
m_activated(activated) m_activated(activated)