kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 09:50:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't store view properties on network shares

Browse source 
Entering a folder will have Dolphin determine whether it can store the view properties in a .directory file within the folder or
in a generic config location.
It does so by checking for permissions on the file and parent dir causing various stat calls that potentially block on a slow mount.
Also, the config reading thereafter can be very slow.
Moreover, network shares are typically shared between users, so one user's view properties shouldn't affect or be overwritten
by this Dolphin instance.
It doesn't resolve symlinks but is surely an improvement over the status quo.

Differential Revision: https://phabricator.kde.org/D23458
This commit is contained in:
Kai Uwe Broulik 2019-08-28 09:46:58 +02:00
parent f4a1d1b022
commit db717a21c5
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/views/viewproperties.cpp
View file

@ -26,6 +26,8 @@
#include <QCryptographicHash>
#include <KFileItem>
namespace {
const int AdditionalInfoViewPropertiesVersion = 1;
const int NameRolePropertiesVersion = 2;
@ -70,6 +72,11 @@ ViewProperties::ViewProperties(const QUrl& url) :
m_filePath = url.toLocalFile();
bool useDestinationDir = !isPartOfHome(m_filePath);
if (!useDestinationDir) {
const KFileItem fileItem(url);
useDestinationDir = fileItem.isSlow();
}
if (!useDestinationDir) {
const QFileInfo dirInfo(m_filePath);
const QFileInfo fileInfo(m_filePath + QDir::separator() + ViewPropertiesFileName);