From dacded2afdfa85a16b99d8522284155cd5175ee5 Mon Sep 17 00:00:00 2001 From: David Faure Date: Thu, 4 Sep 2014 17:50:48 +0200 Subject: [PATCH] extract method renameItem, factorizes the common code --- src/views/renamedialog.cpp | 35 ++++++++++++++++------------------- src/views/renamedialog.h | 1 + 2 files changed, 17 insertions(+), 19 deletions(-) diff --git a/src/views/renamedialog.cpp b/src/views/renamedialog.cpp index 5b20942d52..d3c80e3da5 100644 --- a/src/views/renamedialog.cpp +++ b/src/views/renamedialog.cpp @@ -128,6 +128,20 @@ RenameDialog::~RenameDialog() { } +void RenameDialog::renameItem(const KFileItem &item, const QString& newName) +{ + const KUrl oldUrl = item.url(); + KUrl newUrl = oldUrl; + newUrl.setFileName(KIO::encodeFileName(newName)); + + QWidget* widget = parentWidget(); + if (!widget) { + widget = this; + } + + KonqOperations::rename(widget, oldUrl, newUrl); +} + void RenameDialog::slotButtonClicked(int button) { if (button == KDialog::Ok) { @@ -135,16 +149,7 @@ void RenameDialog::slotButtonClicked(int button) if (m_renameOneItem) { Q_ASSERT(m_items.count() == 1); - const KUrl oldUrl = m_items.first().url(); - KUrl newUrl = oldUrl; - newUrl.setFileName(KIO::encodeFileName(m_newName)); - - QWidget* widget = parentWidget(); - if (!widget) { - widget = this; - } - - KonqOperations::rename(widget, oldUrl, newUrl); + renameItem(m_items.first(), m_newName); } else { renameItems(); } @@ -187,15 +192,7 @@ void RenameDialog::renameItems() } if (oldUrl.fileName() != newName) { - KUrl newUrl = oldUrl; - newUrl.setFileName(KIO::encodeFileName(newName)); - - QWidget* widget = parentWidget(); - if (!widget) { - widget = this; - } - - KonqOperations::rename(widget, oldUrl, newUrl); + renameItem(item, newName); } } } diff --git a/src/views/renamedialog.h b/src/views/renamedialog.h index 29ef8bdf13..430c707a3c 100644 --- a/src/views/renamedialog.h +++ b/src/views/renamedialog.h @@ -49,6 +49,7 @@ private slots: private: void renameItems(); + void renameItem(const KFileItem &item, const QString& newName); /** * @return Returns the string \p name, where the characters represented by