From d8c11a67bd98820fd2c9a4b616460857af70344b Mon Sep 17 00:00:00 2001 From: Alex Miranda Date: Mon, 21 Oct 2019 21:39:30 +0200 Subject: [PATCH] Disable keyboard accelerators for the tabs widget Summary: Now that there are actions for switching to a specific tab with default Alt + shortcuts, automatically assigned keyboard accelerators can result in ambiguous shortcuts when using specific tab names containing numbers. Not adding any accelerators for the tabs widget ensures the default shortcuts work reliably regardless of tab names. Test Plan: - Verify there are no ambiguous shortcuts when browsing folders with names containing only numbers - Verify other keyboard accelerators still work (menu bar, context menu and others) Reviewers: #vdg, #dolphin, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D24794 --- src/dolphintabwidget.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/dolphintabwidget.cpp b/src/dolphintabwidget.cpp index 0408d7ed47..9ecc14427a 100644 --- a/src/dolphintabwidget.cpp +++ b/src/dolphintabwidget.cpp @@ -28,6 +28,7 @@ #include #include #include +#include #include #include @@ -37,6 +38,8 @@ DolphinTabWidget::DolphinTabWidget(QWidget* parent) : m_placesSelectorVisible(true), m_lastViewedTab(0) { + KAcceleratorManager::setNoAccel(this); + connect(this, &DolphinTabWidget::tabCloseRequested, this, QOverload::of(&DolphinTabWidget::closeTab)); connect(this, &DolphinTabWidget::currentChanged,