mirror of
https://invent.kde.org/system/dolphin
synced 2024-10-28 03:21:56 +00:00
Fix performance regression when loading folders in Details View
When using Details View, only insert all pending items immediately if new items are inserted which might be children of a pending item. Fixes the problem that inserting the items in multiple bunches slows down the folder loading. Note that the cause of the slowness when inserting in multiple bunches is that KItemListSizeHintResolver needs O(N^2) time in the worst case for inserting N items into a model with N existing ones. REVIEW: 111226
This commit is contained in:
parent
bbbf039338
commit
d72ce53141
|
@ -759,10 +759,6 @@ void KFileItemModel::slotItemsAdded(const KUrl& directoryUrl, const KFileItemLis
|
|||
parentUrl.adjustPath(KUrl::RemoveTrailingSlash);
|
||||
|
||||
if (m_requestRole[ExpandedParentsCountRole]) {
|
||||
// To be able to compare whether the new items may be inserted as children
|
||||
// of a parent item the pending items must be added to the model first.
|
||||
dispatchPendingItemsToInsert();
|
||||
|
||||
KFileItem item = items.first();
|
||||
|
||||
// If the expanding of items is enabled, the call
|
||||
|
@ -776,6 +772,12 @@ void KFileItemModel::slotItemsAdded(const KUrl& directoryUrl, const KFileItemLis
|
|||
return;
|
||||
}
|
||||
|
||||
if (directoryUrl != directory()) {
|
||||
// To be able to compare whether the new items may be inserted as children
|
||||
// of a parent item the pending items must be added to the model first.
|
||||
dispatchPendingItemsToInsert();
|
||||
}
|
||||
|
||||
// KDirLister keeps the children of items that got expanded once even if
|
||||
// they got collapsed again with KFileItemModel::setExpanded(false). So it must be
|
||||
// checked whether the parent for new items is still expanded.
|
||||
|
|
Loading…
Reference in a new issue