kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-10-28 03:21:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes memory leak of KItemListHeader

Browse source 
Summary:
Fixes memory leak of KItemListHeader
The KItemListHeader passed the listView parent object to the QObject
base class, but that pointer seems to always be nullptr causing the
KItemListHeader to not be memory managed by anything. Instead simple
use the listView as parent pointer.

Test Plan: This leak was found using Address Sanitizer

Reviewers: elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: elvisangelaccio, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D14453
This commit is contained in:
David Hallas 2018-07-29 12:10:16 +02:00
parent 16edd9ccec
commit d2783df310
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/kitemviews/kitemlistheader.cpp
View file

@ -74,7 +74,7 @@ qreal KItemListHeader::preferredColumnWidth(const QByteArray& role) const
}
KItemListHeader::KItemListHeader(KItemListView* listView) :
QObject(listView->parent()),
QObject(listView),
m_view(listView)
{
m_headerWidget = m_view->m_headerWidget;