kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-07-07 10:51:45 +00:00
Code Issues Projects Releases Wiki Activity

DolphinContextMenu: Do not check if the clicked folder is in the Places

Browse Source 
This prevents that the setup of the PlacesItemModel queries Solid for
the available devices, which can take some time.

Places can be added multiple times now using the context menu, but this
has always been possible with drag and drop anyway.

See https://forum.kde.org/viewtopic.php?f=223&t=130617 for a dicsussion
on this topic.

REVIEW: 126904
This commit is contained in:
Frank Reininghaus 2016-01-27 06:56:14 +01:00
parent 2257b94e4f
commit d094c8ffe6
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/dolphincontextmenu.cpp
View File

@ -427,16 +427,11 @@ void DolphinContextMenu::addShowMenuBarAction()
bool DolphinContextMenu::placeExists(const QUrl& url) const
{
PlacesItemModel model;
const int count = model.count();
for (int i = 0; i < count; ++i) {
const QUrl placeUrl = model.placesItem(i)->url();
if (placeUrl.matches(url, QUrl::StripTrailingSlash)) {
return true;
}
}
// Creating up a PlacesItemModel to find out if 'url' is one of the Places
// can be expensive because the model asks Solid for the devices which are
// available, which can take some time.
// TODO: Consider restoring this check if the handling of Places and devices
// will be decoupled in the future.
return false;
}