mirror of
https://invent.kde.org/system/dolphin
synced 2024-09-17 15:31:20 +00:00
Make thumbnail frame-and-shadow drawing criteria match those of the file dialog
Summary: KIO's file dialog already has logic to avoid drawing frames around images detected as likely to be icons, which is improved with D15071. Since Dolphin doesn't use KIO for any of this (boo) we have to pull it over here too; this patch brings the same feature to Dolphin, as well as the feature to disable frames and shadows for all thumbnails at very small sizes, which improves clarity. With this patch, Dolphin's frame drawing behavior becomes consistent with that of the file dialog (as of D15071). BUG: 295526 FIXED-IN: 18.12.0 Test Plan: Icons no longer have frames: {F6214279} Images without transparency still have frames: {F6214280} Nicer presentation for folders with mixed image types (images without transparency get frames; images without it don't): {F6214278} At small sizes, thumbnail clarity is improved by omitting the frame and shadow. Before: {F6214296} After: {F6214294} Reviewers: #dolphin, broulik, elvisangelaccio Reviewed By: #dolphin, broulik, elvisangelaccio Subscribers: markg, anthonyfieroni, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D15069
This commit is contained in:
parent
8f10b5540c
commit
cf0052c296
|
@ -495,14 +495,9 @@ void KFileItemModelRolesUpdater::slotGotPreview(const KFileItem& item, const QPi
|
||||||
|
|
||||||
QPixmap scaledPixmap = pixmap;
|
QPixmap scaledPixmap = pixmap;
|
||||||
|
|
||||||
const QString mimeType = item.mimetype();
|
if (!pixmap.hasAlpha()
|
||||||
const int slashIndex = mimeType.indexOf(QLatin1Char('/'));
|
&& m_iconSize.width() > KIconLoader::SizeSmallMedium
|
||||||
const bool isFontPreview = mimeType.rightRef(slashIndex).contains(QLatin1String("font"));
|
&& m_iconSize.height() > KIconLoader::SizeSmallMedium) {
|
||||||
const bool isFolderPreview = item.isDir();
|
|
||||||
const bool isWindowsExePreview = mimeType == QLatin1String("application/x-ms-dos-executable") ||
|
|
||||||
mimeType == QLatin1String("application/x-msdownload");
|
|
||||||
|
|
||||||
if (!isFolderPreview && !isFontPreview && !isWindowsExePreview) {
|
|
||||||
if (m_enlargeSmallPreviews) {
|
if (m_enlargeSmallPreviews) {
|
||||||
KPixmapModifier::applyFrame(scaledPixmap, m_iconSize);
|
KPixmapModifier::applyFrame(scaledPixmap, m_iconSize);
|
||||||
} else {
|
} else {
|
||||||
|
|
Loading…
Reference in a new issue