kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-10-28 03:21:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PlacesItemModelTest] Try to double test timeout

Browse source 
The randomly failing `testRefresh()` on the CI can be reproduced by
replacing the QTRY_COMPARE with a simple QCOMPARE.

So it seems the CI can be slow such that the default QTR_COMPARE
timeout of 5 seconds is not enough.

If a timeout of 10 seconds fixes this particular test case, we can use
this bigger timeout also in the other failing tests.
This commit is contained in:
Elvis Angelaccio 2018-10-13 11:15:09 +02:00
parent 009cecfe88
commit c9dd3478be
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/tests/placesitemmodeltest.cpp
View file

@ -43,6 +43,11 @@ Q_DECLARE_METATYPE(KItemRange)
#define KDE_ROOT_PATH "/"
#endif
namespace
{
constexpr int TIMEOUT = 10000;
}
static QString bookmarksFile()
{
return QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/user-places.xbel";
@ -738,7 +743,7 @@ void PlacesItemModelTest::testRefresh()
m_model->refresh();
// item must be equal
QTRY_COMPARE(item->text(), sameItem->text());
QTRY_COMPARE_WITH_TIMEOUT(item->text(), sameItem->text(), TIMEOUT);
}
void PlacesItemModelTest::testIcons_data()