From c96efc7ccba67a48920713a2d2b0461c747ca3fb Mon Sep 17 00:00:00 2001 From: Fabian Vogt Date: Sat, 30 Sep 2017 15:49:52 +0200 Subject: [PATCH] Fix build with Qt 5.10 Summary: QStaticText's constructor with const QString & as argument is now explicit. Test Plan: Did not build before, now does. Note that this might change the behaviour as the other properties of m_text are now kept, which was not the case before. I'm not sure what the expected behaviour here is supposed to be. Reviewers: #dolphin, #kde_applications, cfeck Reviewed By: cfeck Subscribers: cfeck, #kde_applications, #dolphin Differential Revision: https://phabricator.kde.org/D8075 --- src/kitemviews/kstandarditemlistgroupheader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kitemviews/kstandarditemlistgroupheader.cpp b/src/kitemviews/kstandarditemlistgroupheader.cpp index 2afaa168c5..c7997faf1c 100644 --- a/src/kitemviews/kstandarditemlistgroupheader.cpp +++ b/src/kitemviews/kstandarditemlistgroupheader.cpp @@ -101,7 +101,7 @@ void KStandardItemListGroupHeader::updateCache() const qreal maxWidth = size().width() - 4 * styleOption().padding; if (role() == "rating") { - m_text = QString(); // krazy:exlude=nullstrassign + m_text.setText(QString()); const qreal height = styleOption().fontMetrics.ascent(); const QSizeF pixmapSize(qMin(height * 5, maxWidth), height);