mirror of
https://invent.kde.org/system/dolphin
synced 2024-08-21 17:30:15 +00:00
fix opening new windows unnecessary
fixes a regression introduced by https://invent.kde.org/utilities/ark/-/merge_requests/44 BUG: 440663
This commit is contained in:
parent
9e2418f025
commit
c628c9d64d
|
@ -60,7 +60,7 @@ bool Dolphin::attachToExistingInstance(const QList<QUrl>& inputUrls, bool openFi
|
|||
{
|
||||
bool attached = false;
|
||||
|
||||
if (inputUrls.isEmpty() || !GeneralSettings::openExternallyCalledFolderInNewTab()) {
|
||||
if (inputUrls.isEmpty()) {
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -81,19 +81,20 @@ bool Dolphin::attachToExistingInstance(const QList<QUrl>& inputUrls, bool openFi
|
|||
}
|
||||
|
||||
// check to see if any instances already have any of the given URLs or their parents open
|
||||
const auto urls = QUrl::toStringList(inputUrls);
|
||||
for (const QString& url : urls) {
|
||||
QList<QUrl> newWindowURLs;
|
||||
for (const QUrl& url : inputUrls) {
|
||||
bool urlFound = false;
|
||||
const QString urlString = url.toString();
|
||||
|
||||
// looping through the windows starting from the active one
|
||||
int i = activeWindowIndex;
|
||||
do {
|
||||
auto &interface = dolphinInterfaces[i];
|
||||
|
||||
auto isUrlOpenReply = openFiles ? interface.first->isItemVisibleInAnyView(url) : interface.first->isUrlOpen(url);
|
||||
auto isUrlOpenReply = openFiles ? interface.first->isItemVisibleInAnyView(urlString) : interface.first->isUrlOpen(urlString);
|
||||
isUrlOpenReply.waitForFinished();
|
||||
if (!isUrlOpenReply.isError() && isUrlOpenReply.value()) {
|
||||
interface.second.append(url);
|
||||
interface.second.append(urlString);
|
||||
urlFound = true;
|
||||
break;
|
||||
}
|
||||
|
@ -103,7 +104,11 @@ bool Dolphin::attachToExistingInstance(const QList<QUrl>& inputUrls, bool openFi
|
|||
while (i != activeWindowIndex);
|
||||
|
||||
if (!urlFound) {
|
||||
dolphinInterfaces[activeWindowIndex].second.append(url);
|
||||
if (GeneralSettings::openExternallyCalledFolderInNewTab()) {
|
||||
dolphinInterfaces[activeWindowIndex].second.append(urlString);
|
||||
} else {
|
||||
newWindowURLs.append(url);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -120,6 +125,14 @@ bool Dolphin::attachToExistingInstance(const QList<QUrl>& inputUrls, bool openFi
|
|||
attached = true;
|
||||
}
|
||||
}
|
||||
if (attached && !newWindowURLs.isEmpty()) {
|
||||
if (openFiles) {
|
||||
openNewWindow(newWindowURLs, nullptr, Dolphin::OpenNewWindowFlag::Select);
|
||||
} else {
|
||||
openNewWindow(newWindowURLs);
|
||||
}
|
||||
}
|
||||
|
||||
return attached;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue