mirror of
https://invent.kde.org/system/dolphin
synced 2024-10-28 03:21:56 +00:00
Use setShowOpenOrExecuteDialog(true) with OpenUrlJob
It makes more sense for a file manager to always ask the user: - whether to execute binaries - whether to open an executable script as text or execute it The openOrExecute dialog from KIOWidgets has a "don't ask again" checkbox, and that setting is also accessible from Dolphin's settings dialog. See the discussion at https://bugs.kde.org/show_bug.cgi?id=429839#c10
This commit is contained in:
parent
c95d7fae79
commit
c03b43b4a1
|
@ -1083,7 +1083,7 @@ void DolphinMainWindow::handleUrl(const QUrl& url)
|
|||
} else {
|
||||
m_lastHandleUrlOpenJob = new KIO::OpenUrlJob(url);
|
||||
m_lastHandleUrlOpenJob->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
|
||||
m_lastHandleUrlOpenJob->setRunExecutables(true);
|
||||
m_lastHandleUrlOpenJob->setShowOpenOrExecuteDialog(true);
|
||||
|
||||
connect(m_lastHandleUrlOpenJob, &KIO::OpenUrlJob::mimeTypeFound, this,
|
||||
[this, url](const QString &mimetype) {
|
||||
|
|
|
@ -638,7 +638,6 @@ void DolphinViewContainer::slotItemActivated(const KFileItem& item)
|
|||
}
|
||||
|
||||
KIO::OpenUrlJob *job = new KIO::OpenUrlJob(item.targetUrl());
|
||||
job->setRunExecutables(true);
|
||||
job->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
|
||||
job->setShowOpenOrExecuteDialog(true);
|
||||
job->start();
|
||||
|
|
Loading…
Reference in a new issue