kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use setShowOpenOrExecuteDialog(true) with OpenUrlJob

Browse source 
It makes more sense for a file manager to always ask the user:
 - whether to execute binaries
 - whether to open an executable script as text or execute it

The openOrExecute dialog from KIOWidgets has a "don't ask again" checkbox,
and that setting is also accessible from Dolphin's settings dialog.

See the discussion at https://bugs.kde.org/show_bug.cgi?id=429839#c10
This commit is contained in:
Ahmad Samir 2020-12-15 00:40:12 +02:00
parent c95d7fae79
commit c03b43b4a1
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/dolphinmainwindow.cpp
View file

@ -1083,7 +1083,7 @@ void DolphinMainWindow::handleUrl(const QUrl& url)
} else {
m_lastHandleUrlOpenJob = new KIO::OpenUrlJob(url);
m_lastHandleUrlOpenJob->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
m_lastHandleUrlOpenJob->setRunExecutables(true);
m_lastHandleUrlOpenJob->setShowOpenOrExecuteDialog(true);
connect(m_lastHandleUrlOpenJob, &KIO::OpenUrlJob::mimeTypeFound, this,
[this, url](const QString &mimetype) {

1
src/dolphinviewcontainer.cpp
View file

@ -638,7 +638,6 @@ void DolphinViewContainer::slotItemActivated(const KFileItem& item)
}
KIO::OpenUrlJob *job = new KIO::OpenUrlJob(item.targetUrl());
job->setRunExecutables(true);
job->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this));
job->setShowOpenOrExecuteDialog(true);
job->start();