From bf1081a824d9024a400d2ac2437f169c6765caa5 Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Sat, 3 Feb 2018 22:21:30 +0100 Subject: [PATCH] Fix all 'explicit constructor' krazy warnings --- src/dolphinpart_ext.h | 8 ++++---- src/kitemviews/kfileitemlistview.h | 2 +- src/kitemviews/kitemlistgroupheader.h | 2 +- src/kitemviews/kitemlistheader.h | 2 +- src/kitemviews/kitemlistselectionmanager.h | 2 +- src/kitemviews/kitemlistview.h | 2 +- src/kitemviews/kitemmodelbase.h | 2 +- src/kitemviews/kitemrange.h | 2 +- src/kitemviews/kitemset.h | 2 +- src/kitemviews/kstandarditemlistgroupheader.h | 2 +- src/kitemviews/kstandarditemlistview.h | 2 +- src/kitemviews/private/kfileitemmodeldirlister.h | 2 +- src/kitemviews/private/kitemlistheaderwidget.h | 2 +- src/kitemviews/private/kitemlistkeyboardsearchmanager.h | 2 +- src/kitemviews/private/kitemlistselectiontoggle.h | 2 +- src/kitemviews/private/kitemlistsizehintresolver.h | 2 +- src/kitemviews/private/kitemlistviewanimation.h | 2 +- src/kitemviews/private/kitemlistviewlayouter.h | 2 +- src/middleclickactioneventfilter.h | 2 +- src/panels/information/phononwidget.h | 2 +- src/panels/places/placesitemlistgroupheader.h | 2 +- src/settings/general/confirmationssettingspage.h | 2 +- src/settings/general/previewssettingspage.h | 2 +- src/settings/general/statusbarsettingspage.h | 2 +- src/settings/navigation/navigationsettingspage.h | 2 +- src/settings/services/servicessettingspage.h | 2 +- src/settings/trash/trashsettingspage.h | 2 +- src/settings/viewmodes/dolphinfontrequester.h | 2 +- src/settings/viewmodes/viewmodesettings.h | 2 +- src/settings/viewmodes/viewsettingspage.h | 2 +- src/statusbar/dolphinstatusbar.h | 2 +- src/views/tooltips/dolphinfilemetadatawidget.h | 2 +- 32 files changed, 35 insertions(+), 35 deletions(-) diff --git a/src/dolphinpart_ext.h b/src/dolphinpart_ext.h index 590fc169cd..2011bcd0c3 100644 --- a/src/dolphinpart_ext.h +++ b/src/dolphinpart_ext.h @@ -32,7 +32,7 @@ class DolphinPartBrowserExtension : public KParts::BrowserExtension { Q_OBJECT public: - DolphinPartBrowserExtension( DolphinPart* part ); + explicit DolphinPartBrowserExtension( DolphinPart* part ); void restoreState(QDataStream &stream) override; void saveState(QDataStream &stream) override; @@ -52,7 +52,7 @@ class DolphinPartFileInfoExtension : public KParts::FileInfoExtension Q_OBJECT public: - DolphinPartFileInfoExtension(DolphinPart* part); + explicit DolphinPartFileInfoExtension(DolphinPart* part); QueryModes supportedQueryModes() const override; bool hasSelection() const override; @@ -68,7 +68,7 @@ class DolphinPartListingFilterExtension : public KParts::ListingFilterExtension Q_OBJECT public: - DolphinPartListingFilterExtension(DolphinPart* part); + explicit DolphinPartListingFilterExtension(DolphinPart* part); FilterModes supportedFilterModes() const override; bool supportsMultipleFilters(FilterMode mode) const override; QVariant filter(FilterMode mode) const override; @@ -83,7 +83,7 @@ class DolphinPartListingNotificationExtension : public KParts::ListingNotificati Q_OBJECT public: - DolphinPartListingNotificationExtension(DolphinPart* part); + explicit DolphinPartListingNotificationExtension(DolphinPart* part); NotificationEventTypes supportedNotificationEventTypes() const override; public Q_SLOTS: diff --git a/src/kitemviews/kfileitemlistview.h b/src/kitemviews/kfileitemlistview.h index 95ad9ba686..c7fdf972db 100644 --- a/src/kitemviews/kfileitemlistview.h +++ b/src/kitemviews/kfileitemlistview.h @@ -41,7 +41,7 @@ class DOLPHIN_EXPORT KFileItemListView : public KStandardItemListView Q_OBJECT public: - KFileItemListView(QGraphicsWidget* parent = nullptr); + explicit KFileItemListView(QGraphicsWidget* parent = nullptr); ~KFileItemListView() override; void setPreviewsShown(bool show); diff --git a/src/kitemviews/kitemlistgroupheader.h b/src/kitemviews/kitemlistgroupheader.h index 6a8bd76e86..ec5fb145eb 100644 --- a/src/kitemviews/kitemlistgroupheader.h +++ b/src/kitemviews/kitemlistgroupheader.h @@ -42,7 +42,7 @@ class DOLPHIN_EXPORT KItemListGroupHeader : public QGraphicsWidget Q_OBJECT public: - KItemListGroupHeader(QGraphicsWidget* parent = nullptr); + explicit KItemListGroupHeader(QGraphicsWidget* parent = nullptr); ~KItemListGroupHeader() override; void setRole(const QByteArray& role); diff --git a/src/kitemviews/kitemlistheader.h b/src/kitemviews/kitemlistheader.h index 4d9d9a5b08..ef1dd0f859 100644 --- a/src/kitemviews/kitemlistheader.h +++ b/src/kitemviews/kitemlistheader.h @@ -87,7 +87,7 @@ signals: qreal currentWidth); private: - KItemListHeader(KItemListView* listView); + explicit KItemListHeader(KItemListView* listView); private: KItemListView* m_view; diff --git a/src/kitemviews/kitemlistselectionmanager.h b/src/kitemviews/kitemlistselectionmanager.h index 54c2cc0629..e4fe0c2304 100644 --- a/src/kitemviews/kitemlistselectionmanager.h +++ b/src/kitemviews/kitemlistselectionmanager.h @@ -51,7 +51,7 @@ public: Toggle }; - KItemListSelectionManager(QObject* parent = nullptr); + explicit KItemListSelectionManager(QObject* parent = nullptr); ~KItemListSelectionManager() override; void setCurrentItem(int current); diff --git a/src/kitemviews/kitemlistview.h b/src/kitemviews/kitemlistview.h index e3793e10ef..7af3d3283a 100644 --- a/src/kitemviews/kitemlistview.h +++ b/src/kitemviews/kitemlistview.h @@ -67,7 +67,7 @@ class DOLPHIN_EXPORT KItemListView : public QGraphicsWidget Q_PROPERTY(qreal itemOffset READ itemOffset WRITE setItemOffset) public: - KItemListView(QGraphicsWidget* parent = nullptr); + explicit KItemListView(QGraphicsWidget* parent = nullptr); ~KItemListView() override; /** diff --git a/src/kitemviews/kitemmodelbase.h b/src/kitemviews/kitemmodelbase.h index 0aa6d187f4..7db387ec2e 100644 --- a/src/kitemviews/kitemmodelbase.h +++ b/src/kitemviews/kitemmodelbase.h @@ -55,7 +55,7 @@ class DOLPHIN_EXPORT KItemModelBase : public QObject Q_OBJECT public: - KItemModelBase(QObject* parent = nullptr); + explicit KItemModelBase(QObject* parent = nullptr); explicit KItemModelBase(const QByteArray& sortRole, QObject* parent = nullptr); ~KItemModelBase() override; diff --git a/src/kitemviews/kitemrange.h b/src/kitemviews/kitemrange.h index ecc03988d2..6453f2154a 100644 --- a/src/kitemviews/kitemrange.h +++ b/src/kitemviews/kitemrange.h @@ -51,7 +51,7 @@ class KItemRangeList : public QList { public: KItemRangeList() : QList() {} - KItemRangeList(const QList& list) : QList(list) {} + explicit KItemRangeList(const QList& list) : QList(list) {} template static KItemRangeList fromSortedContainer(const Container& container); diff --git a/src/kitemviews/kitemset.h b/src/kitemviews/kitemset.h index 5afe24df5d..b831953c66 100644 --- a/src/kitemviews/kitemset.h +++ b/src/kitemviews/kitemset.h @@ -163,7 +163,7 @@ public: { } - const_iterator(const iterator& other) : + explicit const_iterator(const iterator& other) : m_rangeIt(other.m_rangeIt), m_offset(other.m_offset) { diff --git a/src/kitemviews/kstandarditemlistgroupheader.h b/src/kitemviews/kstandarditemlistgroupheader.h index 36ab777221..136bb866fa 100644 --- a/src/kitemviews/kstandarditemlistgroupheader.h +++ b/src/kitemviews/kstandarditemlistgroupheader.h @@ -32,7 +32,7 @@ class DOLPHIN_EXPORT KStandardItemListGroupHeader : public KItemListGroupHeader Q_OBJECT public: - KStandardItemListGroupHeader(QGraphicsWidget* parent = nullptr); + explicit KStandardItemListGroupHeader(QGraphicsWidget* parent = nullptr); ~KStandardItemListGroupHeader() override; void paint(QPainter* painter, const QStyleOptionGraphicsItem* option, QWidget* widget = nullptr) override; diff --git a/src/kitemviews/kstandarditemlistview.h b/src/kitemviews/kstandarditemlistview.h index 6321a1d2e6..f6125621ff 100644 --- a/src/kitemviews/kstandarditemlistview.h +++ b/src/kitemviews/kstandarditemlistview.h @@ -52,7 +52,7 @@ public: DetailsLayout }; - KStandardItemListView(QGraphicsWidget* parent = nullptr); + explicit KStandardItemListView(QGraphicsWidget* parent = nullptr); ~KStandardItemListView() override; void setItemLayout(ItemLayout layout); diff --git a/src/kitemviews/private/kfileitemmodeldirlister.h b/src/kitemviews/private/kfileitemmodeldirlister.h index c8b670f713..b3f85c8da3 100644 --- a/src/kitemviews/private/kfileitemmodeldirlister.h +++ b/src/kitemviews/private/kfileitemmodeldirlister.h @@ -34,7 +34,7 @@ class DOLPHIN_EXPORT KFileItemModelDirLister : public KDirLister Q_OBJECT public: - KFileItemModelDirLister(QObject* parent = nullptr); + explicit KFileItemModelDirLister(QObject* parent = nullptr); ~KFileItemModelDirLister() override; signals: diff --git a/src/kitemviews/private/kitemlistheaderwidget.h b/src/kitemviews/private/kitemlistheaderwidget.h index 6d0974f979..193f2b34ed 100644 --- a/src/kitemviews/private/kitemlistheaderwidget.h +++ b/src/kitemviews/private/kitemlistheaderwidget.h @@ -38,7 +38,7 @@ class DOLPHIN_EXPORT KItemListHeaderWidget : public QGraphicsWidget Q_OBJECT public: - KItemListHeaderWidget(QGraphicsWidget* parent = nullptr); + explicit KItemListHeaderWidget(QGraphicsWidget* parent = nullptr); ~KItemListHeaderWidget() override; void setModel(KItemModelBase* model); diff --git a/src/kitemviews/private/kitemlistkeyboardsearchmanager.h b/src/kitemviews/private/kitemlistkeyboardsearchmanager.h index 02dedefca0..f9d77d0b1a 100644 --- a/src/kitemviews/private/kitemlistkeyboardsearchmanager.h +++ b/src/kitemviews/private/kitemlistkeyboardsearchmanager.h @@ -41,7 +41,7 @@ class DOLPHIN_EXPORT KItemListKeyboardSearchManager : public QObject public: - KItemListKeyboardSearchManager(QObject* parent = nullptr); + explicit KItemListKeyboardSearchManager(QObject* parent = nullptr); ~KItemListKeyboardSearchManager() override; /** diff --git a/src/kitemviews/private/kitemlistselectiontoggle.h b/src/kitemviews/private/kitemlistselectiontoggle.h index a10995372e..a537a99048 100644 --- a/src/kitemviews/private/kitemlistselectiontoggle.h +++ b/src/kitemviews/private/kitemlistselectiontoggle.h @@ -34,7 +34,7 @@ class DOLPHIN_EXPORT KItemListSelectionToggle : public QGraphicsWidget Q_OBJECT public: - KItemListSelectionToggle(QGraphicsItem* parent); + explicit KItemListSelectionToggle(QGraphicsItem* parent); ~KItemListSelectionToggle() override; void setChecked(bool checked); diff --git a/src/kitemviews/private/kitemlistsizehintresolver.h b/src/kitemviews/private/kitemlistsizehintresolver.h index fa92b86822..b62c87a69b 100644 --- a/src/kitemviews/private/kitemlistsizehintresolver.h +++ b/src/kitemviews/private/kitemlistsizehintresolver.h @@ -34,7 +34,7 @@ class KItemListView; class DOLPHIN_EXPORT KItemListSizeHintResolver { public: - KItemListSizeHintResolver(const KItemListView* itemListView); + explicit KItemListSizeHintResolver(const KItemListView* itemListView); virtual ~KItemListSizeHintResolver(); QSizeF maxSizeHint(); QSizeF minSizeHint(); diff --git a/src/kitemviews/private/kitemlistviewanimation.h b/src/kitemviews/private/kitemlistviewanimation.h index ba3a33dc92..f73ea7fb75 100644 --- a/src/kitemviews/private/kitemlistviewanimation.h +++ b/src/kitemviews/private/kitemlistviewanimation.h @@ -48,7 +48,7 @@ public: ResizeAnimation }; - KItemListViewAnimation(QObject* parent = nullptr); + explicit KItemListViewAnimation(QObject* parent = nullptr); ~KItemListViewAnimation() override; void setScrollOrientation(Qt::Orientation orientation); diff --git a/src/kitemviews/private/kitemlistviewlayouter.h b/src/kitemviews/private/kitemlistviewlayouter.h index 2116f8405c..6cdce666f4 100644 --- a/src/kitemviews/private/kitemlistviewlayouter.h +++ b/src/kitemviews/private/kitemlistviewlayouter.h @@ -50,7 +50,7 @@ class DOLPHIN_EXPORT KItemListViewLayouter : public QObject Q_OBJECT public: - KItemListViewLayouter(KItemListSizeHintResolver* sizeHintResolver, QObject* parent = nullptr); + explicit KItemListViewLayouter(KItemListSizeHintResolver* sizeHintResolver, QObject* parent = nullptr); ~KItemListViewLayouter() override; void setScrollOrientation(Qt::Orientation orientation); diff --git a/src/middleclickactioneventfilter.h b/src/middleclickactioneventfilter.h index 6974f469e7..e88eabc8af 100644 --- a/src/middleclickactioneventfilter.h +++ b/src/middleclickactioneventfilter.h @@ -35,7 +35,7 @@ class DOLPHIN_EXPORT MiddleClickActionEventFilter : public QObject Q_OBJECT public: - MiddleClickActionEventFilter(QObject *parent); + explicit MiddleClickActionEventFilter(QObject *parent); ~MiddleClickActionEventFilter() override; signals: diff --git a/src/panels/information/phononwidget.h b/src/panels/information/phononwidget.h index 947f0cdac2..eff613bd96 100644 --- a/src/panels/information/phononwidget.h +++ b/src/panels/information/phononwidget.h @@ -43,7 +43,7 @@ class PhononWidget : public QWidget { Q_OBJECT public: - PhononWidget(QWidget *parent = nullptr); + explicit PhononWidget(QWidget *parent = nullptr); void setUrl(const QUrl &url); QUrl url() const; diff --git a/src/panels/places/placesitemlistgroupheader.h b/src/panels/places/placesitemlistgroupheader.h index 4408aa9ef8..7276622416 100644 --- a/src/panels/places/placesitemlistgroupheader.h +++ b/src/panels/places/placesitemlistgroupheader.h @@ -27,7 +27,7 @@ class PlacesItemListGroupHeader : public KStandardItemListGroupHeader Q_OBJECT public: - PlacesItemListGroupHeader(QGraphicsWidget* parent = nullptr); + explicit PlacesItemListGroupHeader(QGraphicsWidget* parent = nullptr); ~PlacesItemListGroupHeader() override; protected: diff --git a/src/settings/general/confirmationssettingspage.h b/src/settings/general/confirmationssettingspage.h index f8e5e3540c..22e47aead8 100644 --- a/src/settings/general/confirmationssettingspage.h +++ b/src/settings/general/confirmationssettingspage.h @@ -31,7 +31,7 @@ class ConfirmationsSettingsPage : public SettingsPageBase Q_OBJECT public: - ConfirmationsSettingsPage(QWidget* parent); + explicit ConfirmationsSettingsPage(QWidget* parent); ~ConfirmationsSettingsPage() override; /** @see SettingsPageBase::applySettings() */ diff --git a/src/settings/general/previewssettingspage.h b/src/settings/general/previewssettingspage.h index 0bac4da650..875c19dd65 100644 --- a/src/settings/general/previewssettingspage.h +++ b/src/settings/general/previewssettingspage.h @@ -34,7 +34,7 @@ class PreviewsSettingsPage : public SettingsPageBase Q_OBJECT public: - PreviewsSettingsPage(QWidget* parent); + explicit PreviewsSettingsPage(QWidget* parent); ~PreviewsSettingsPage() override; /** diff --git a/src/settings/general/statusbarsettingspage.h b/src/settings/general/statusbarsettingspage.h index d85f0aaa15..3c0bd2b3c1 100644 --- a/src/settings/general/statusbarsettingspage.h +++ b/src/settings/general/statusbarsettingspage.h @@ -31,7 +31,7 @@ class StatusBarSettingsPage : public SettingsPageBase Q_OBJECT public: - StatusBarSettingsPage(QWidget* parent); + explicit StatusBarSettingsPage(QWidget* parent); ~StatusBarSettingsPage() override; /** @see SettingsPageBase::applySettings() */ diff --git a/src/settings/navigation/navigationsettingspage.h b/src/settings/navigation/navigationsettingspage.h index d58a8e8110..188fe51f1e 100644 --- a/src/settings/navigation/navigationsettingspage.h +++ b/src/settings/navigation/navigationsettingspage.h @@ -31,7 +31,7 @@ class NavigationSettingsPage : public SettingsPageBase Q_OBJECT public: - NavigationSettingsPage(QWidget* parent); + explicit NavigationSettingsPage(QWidget* parent); ~NavigationSettingsPage() override; /** @see SettingsPageBase::applySettings() */ diff --git a/src/settings/services/servicessettingspage.h b/src/settings/services/servicessettingspage.h index c1239c9f5f..bcbce19180 100644 --- a/src/settings/services/servicessettingspage.h +++ b/src/settings/services/servicessettingspage.h @@ -35,7 +35,7 @@ class ServicesSettingsPage : public SettingsPageBase Q_OBJECT public: - ServicesSettingsPage(QWidget* parent); + explicit ServicesSettingsPage(QWidget* parent); ~ServicesSettingsPage() override; /** @see SettingsPageBase::applySettings() */ diff --git a/src/settings/trash/trashsettingspage.h b/src/settings/trash/trashsettingspage.h index 57631b7602..6faf3f61e2 100644 --- a/src/settings/trash/trashsettingspage.h +++ b/src/settings/trash/trashsettingspage.h @@ -30,7 +30,7 @@ class TrashSettingsPage : public SettingsPageBase Q_OBJECT public: - TrashSettingsPage(QWidget* parent); + explicit TrashSettingsPage(QWidget* parent); ~TrashSettingsPage() override; /** @see SettingsPageBase::applySettings() */ diff --git a/src/settings/viewmodes/dolphinfontrequester.h b/src/settings/viewmodes/dolphinfontrequester.h index 3f355e3141..6f1b8400ea 100644 --- a/src/settings/viewmodes/dolphinfontrequester.h +++ b/src/settings/viewmodes/dolphinfontrequester.h @@ -40,7 +40,7 @@ public: CustomFont = 1 }; - DolphinFontRequester(QWidget* parent); + explicit DolphinFontRequester(QWidget* parent); ~DolphinFontRequester() override; void setMode(Mode mode); diff --git a/src/settings/viewmodes/viewmodesettings.h b/src/settings/viewmodes/viewmodesettings.h index 9f0b44e9ba..8bc9b562e8 100644 --- a/src/settings/viewmodes/viewmodesettings.h +++ b/src/settings/viewmodes/viewmodesettings.h @@ -36,7 +36,7 @@ public: DetailsMode }; - ViewModeSettings(ViewMode mode); + explicit ViewModeSettings(ViewMode mode); virtual ~ViewModeSettings(); void setIconSize(int size) const; diff --git a/src/settings/viewmodes/viewsettingspage.h b/src/settings/viewmodes/viewsettingspage.h index 4f57e5c191..2e456a867c 100644 --- a/src/settings/viewmodes/viewsettingspage.h +++ b/src/settings/viewmodes/viewsettingspage.h @@ -36,7 +36,7 @@ class ViewSettingsPage : public SettingsPageBase Q_OBJECT public: - ViewSettingsPage(QWidget* parent); + explicit ViewSettingsPage(QWidget* parent); ~ViewSettingsPage() override; /** @see SettingsPageBase::applySettings() */ diff --git a/src/statusbar/dolphinstatusbar.h b/src/statusbar/dolphinstatusbar.h index 0b0004e47e..8b872ace58 100644 --- a/src/statusbar/dolphinstatusbar.h +++ b/src/statusbar/dolphinstatusbar.h @@ -43,7 +43,7 @@ class DolphinStatusBar : public QWidget Q_OBJECT public: - DolphinStatusBar(QWidget* parent); + explicit DolphinStatusBar(QWidget* parent); ~DolphinStatusBar() override; QString text() const; diff --git a/src/views/tooltips/dolphinfilemetadatawidget.h b/src/views/tooltips/dolphinfilemetadatawidget.h index 6dcc5237c1..3017ef5ced 100644 --- a/src/views/tooltips/dolphinfilemetadatawidget.h +++ b/src/views/tooltips/dolphinfilemetadatawidget.h @@ -45,7 +45,7 @@ class DolphinFileMetaDataWidget : public QWidget Q_OBJECT public: - DolphinFileMetaDataWidget(QWidget* parent = nullptr); + explicit DolphinFileMetaDataWidget(QWidget* parent = nullptr); ~DolphinFileMetaDataWidget() override; void setPreview(const QPixmap& pixmap);