From 28a949a925193bc71007efa15034df325e797939 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Br=C3=BCns?= Date: Thu, 18 Apr 2019 14:37:09 +0200 Subject: [PATCH] Fix missing update of file name label in information panel without preview Summary: The file name label was only updated when the preview was shown, after the function was moved into a conditional section. This is a regression caused by commit 405aa4878f75 ("[InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled"). Test Plan: Hide the preview in dolphin's information panel Hover different files, the name label reflects the hovered file again Reviewers: #dolphin, elvisangelaccio, meven, ngraham Reviewed By: meven Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20660 --- src/panels/information/informationpanelcontent.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panels/information/informationpanelcontent.cpp b/src/panels/information/informationpanelcontent.cpp index e2b90dcc89..0eaa125f11 100644 --- a/src/panels/information/informationpanelcontent.cpp +++ b/src/panels/information/informationpanelcontent.cpp @@ -154,12 +154,12 @@ void InformationPanelContent::refreshPreview() { m_previewJob->kill(); } + setNameLabelText(m_item.text()); if (InformationPanelSettings::previewsShown()) { m_preview->show(); const QUrl itemUrl = m_item.url(); const bool isSearchUrl = itemUrl.scheme().contains(QStringLiteral("search")) && m_item.localPath().isEmpty(); - setNameLabelText(m_item.text()); if (isSearchUrl) { // in the case of a search-URL the URL is not readable for humans // (at least not useful to show in the Information Panel)