mirror of
https://invent.kde.org/system/dolphin
synced 2024-10-28 03:21:56 +00:00
After opening and switching to a new tab, always focus the view
Summary: When Dolphin opens a new tab and immediately switches to it, the URL navigator gets focus if it's editable. If it's not, the breadcrumbs bar gets keyboard focus, which is not very useful since it's not really intended for keyboard navigation. This patch changes that behavior so that the view always gets focus, which seems more useful and more consistent. BUG: 401899 FIXED-IN: 19.04.0 Test Plan: 1. Put the URL navigator into breadcrumbs mode 2. Open a new tab 3. Observe that the view gets keyboard focus 4. Put the URL navigator into editable mode 5. Open a new tab 6. Observe that the view still gets keyboard focus Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: emateli, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17635
This commit is contained in:
parent
8bc93b564c
commit
b7ceb51b44
|
@ -135,14 +135,10 @@ void DolphinTabWidget::openNewActivatedTab()
|
|||
|
||||
// The URL navigator of the new tab should have the same editable state
|
||||
// as the current tab
|
||||
KUrlNavigator* navigator = newActiveViewContainer->urlNavigator();
|
||||
navigator->setUrlEditable(isUrlEditable);
|
||||
newActiveViewContainer->urlNavigator()->setUrlEditable(isUrlEditable);
|
||||
|
||||
if (isUrlEditable) {
|
||||
// If a new tab is opened and the URL is editable, assure that
|
||||
// the user can edit the URL without manually setting the focus
|
||||
navigator->setFocus();
|
||||
}
|
||||
// Always focus the new tab's view
|
||||
newActiveViewContainer->view()->setFocus();
|
||||
}
|
||||
|
||||
void DolphinTabWidget::openNewActivatedTab(const QUrl& primaryUrl, const QUrl& secondaryUrl)
|
||||
|
|
Loading…
Reference in a new issue