kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-10-03 23:29:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add test for accessibility ancestor tree

Browse source 
This is to make sure that all items that can be tabbed to and their
accessible children have the main window somewhere in their
ancestry/ancestor tree.
This commit is contained in:
Felix Ernst 2023-09-08 17:10:29 +02:00 committed by Felix Ernst
parent 549fad2dae
commit b58fead9be
1 changed files with 37 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
src/tests/dolphinmainwindowtest.cpp
View file

@ -14,11 +14,14 @@
#include <KActionCollection>
#include <QAccessible>
#include <QScopedPointer>
#include <QSignalSpy>
#include <QStandardPaths>
#include <QTest>
#include <set>
class DolphinMainWindowTest : public QObject
{
Q_OBJECT
@ -39,6 +42,7 @@ private Q_SLOTS:
void testPlacesPanelWidthResistance();
void testGoActions();
void testOpenFiles();
void testAccessibilityAncestorTree();
void cleanupTestCase();
private:
@ -524,6 +528,39 @@ void DolphinMainWindowTest::testOpenFiles()
QTRY_COMPARE(m_mainWindow->m_activeViewContainer->view()->selectedItems().count(), 1);
}
void DolphinMainWindowTest::testAccessibilityAncestorTree()
{
m_mainWindow->openDirectories({QUrl::fromLocalFile(QDir::homePath())}, false);
m_mainWindow->show();
QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data()));
QVERIFY(m_mainWindow->isVisible());
std::set<const QObject *> testedObjects; // Makes sure we stop testing if we arrive at an item that was already tested.
QAccessibleInterface *accessibleInterfaceOfMainWindow = QAccessible::queryAccessibleInterface(m_mainWindow.get());
Q_CHECK_PTR(accessibleInterfaceOfMainWindow);
// We will do accessibility checks for every object that gets focus. Focus will be changed using the Tab key.
while (qApp->focusObject() && !testedObjects.count(qApp->focusObject())) {
const auto currentlyFocusedObject = qApp->focusObject();
QAccessibleInterface *accessibleInterface = QAccessible::queryAccessibleInterface(currentlyFocusedObject);
// The accessibleInterfaces of focused objects might themselves have children.
// We go down that hierarchy as far as possible and then test the ancestor tree from there.
while (accessibleInterface->childCount() > 0) {
accessibleInterface = accessibleInterface->child(0);
}
while (accessibleInterface != accessibleInterfaceOfMainWindow) {
QVERIFY2(accessibleInterface,
qPrintable(QString("%1's accessibleInterface or one of its accessible children doesn't have the main window as an ancestor.")
.arg(currentlyFocusedObject->metaObject()->className())));
accessibleInterface = accessibleInterface->parent();
}
testedObjects.insert(currentlyFocusedObject); // Add it to testedObjects so we won't test it again later.
QTest::keyClick(m_mainWindow.get(), Qt::Key::Key_Tab, Qt::ShiftModifier); // ShiftModifier because the Tab cycle is currently broken going forward.
}
}
void DolphinMainWindowTest::cleanupTestCase()
{
m_mainWindow->showNormal();