From b500c27e11acd6a6de4aab507f6df438b6d2f580 Mon Sep 17 00:00:00 2001 From: Zakhar Afonin Date: Sat, 22 Jun 2024 15:49:07 +0300 Subject: [PATCH] Fixed empty files being erroneously grouped together with folders in "By size" grouping --- src/kitemviews/kfileitemmodel.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp index 2133eef79e..e7afa5288d 100644 --- a/src/kitemviews/kfileitemmodel.cpp +++ b/src/kitemviews/kfileitemmodel.cpp @@ -2513,8 +2513,6 @@ KFileItemModel::ItemGroupInfo KFileItemModel::nameRoleGroup(const ItemData *item KFileItemModel::ItemGroupInfo KFileItemModel::sizeRoleGroup(const ItemData *itemData, bool withString) const { - static ItemGroupInfo oldGroupInfo; - static KIO::filesize_t oldFileSize; ItemGroupInfo groupInfo; KIO::filesize_t fileSize; @@ -2529,9 +2527,6 @@ KFileItemModel::ItemGroupInfo KFileItemModel::sizeRoleGroup(const ItemData *item fileSize = itemData->values.value("size").toULongLong(); } } - if (fileSize == oldFileSize) { - return oldGroupInfo; - } if (groupInfo.comparable < 0) { if (fileSize < 5 * 1024 * 1024) { // < 5 MB groupInfo.comparable = 1; // Small @@ -2546,8 +2541,6 @@ KFileItemModel::ItemGroupInfo KFileItemModel::sizeRoleGroup(const ItemData *item char const *groupNames[] = {"Folders", "Small", "Medium", "Big"}; groupInfo.text = i18nc("@title:group Size", groupNames[groupInfo.comparable]); } - oldFileSize = fileSize; - oldGroupInfo = groupInfo; return groupInfo; }