From b319c59b8d1e068cf621be852ced9c5396bd77f9 Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Fri, 11 May 2012 16:23:49 +0200 Subject: [PATCH] Allow moving items to trash also for non-local files See bug 188032 for an ongoing discussion. In case if this behavior is really not wanted by users (the feedback on bugs.kde.org will show), the review-request https://git.reviewboard.kde.org/r/104915/ should be merged too (after adjusting some parts of the code). --- src/dolphincontextmenu.cpp | 2 +- src/dolphincontextmenu.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp index 286d304c52..670062250a 100644 --- a/src/dolphincontextmenu.cpp +++ b/src/dolphincontextmenu.cpp @@ -559,7 +559,7 @@ void DolphinContextMenu::updateRemoveAction() bool DolphinContextMenu::moveToTrash() const { - return selectedItemsProperties().isLocal() && !m_shiftPressed; + return !m_shiftPressed; } #include "dolphincontextmenu.moc" diff --git a/src/dolphincontextmenu.h b/src/dolphincontextmenu.h index 9e8b804cd4..75a6e35e85 100644 --- a/src/dolphincontextmenu.h +++ b/src/dolphincontextmenu.h @@ -176,8 +176,8 @@ private: void updateRemoveAction(); /** - * @return True if no shift key has been pressed and the selection represents - * only local files. + * @return True if a moving to the trash should be done instead of + * deleting the selected items. * @see updateRemoveAction(), slotRemoveActionTriggered() */ bool moveToTrash() const;