mirror of
https://invent.kde.org/system/dolphin
synced 2024-09-17 15:31:20 +00:00
Don't trigger rubberband with back/foward mouse buttons
Right now the back/foward mouse buttons work, but also if you hold either
of them and move the mouse the rubberband selection is triggered.
This is the correct fix (instead of commit d0c71a1435
), to match the
original code before the touch events patches, we need to check the
back/foward buttons after mouseButtonPressed is emitted and before
triggering the rubberbad selection.
This commit is contained in:
parent
3d8bb6c385
commit
aa12f9ec1d
|
@ -557,12 +557,6 @@ bool KItemListController::mousePressEvent(QGraphicsSceneMouseEvent* event, const
|
|||
return false;
|
||||
}
|
||||
|
||||
if (buttons & (Qt::BackButton | Qt::ForwardButton)) {
|
||||
// Do not select items when clicking the back/forward buttons, see
|
||||
// https://bugs.kde.org/show_bug.cgi?id=327412.
|
||||
return true;
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
|
@ -1423,6 +1417,12 @@ bool KItemListController::onPress(const QPoint& screenPos, const QPointF& pos, c
|
|||
{
|
||||
emit mouseButtonPressed(m_pressedIndex, buttons);
|
||||
|
||||
if (buttons & (Qt::BackButton | Qt::ForwardButton)) {
|
||||
// Do not select items when clicking the back/forward buttons, see
|
||||
// https://bugs.kde.org/show_bug.cgi?id=327412.
|
||||
return true;
|
||||
}
|
||||
|
||||
if (m_view->isAboveExpansionToggle(m_pressedIndex, m_pressedMousePos)) {
|
||||
m_selectionManager->endAnchoredSelection();
|
||||
m_selectionManager->setCurrentItem(m_pressedIndex);
|
||||
|
|
Loading…
Reference in a new issue