From a8dd6998407cd27daf160c45ae77a8d0ae5cf1f7 Mon Sep 17 00:00:00 2001 From: Ismael Asensio Date: Sun, 22 Dec 2019 17:46:48 +0100 Subject: [PATCH] Get rid of -Wdeprecated-copy warning Summary: Remove the explicit copy constructor of `KItemListStyleOption`, since it does not add any logic to what the implicit copy constructor does, but triggers a compiler warning if we don't overload `operator=` too. Test Plan: Compiles without `-Wdeprecated-copy` warning No behavior changes Reviewers: elvisangelaccio, #dolphin Reviewed By: elvisangelaccio, #dolphin Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D26585 --- src/kitemviews/kitemliststyleoption.cpp | 15 --------------- src/kitemviews/kitemliststyleoption.h | 3 --- 2 files changed, 18 deletions(-) diff --git a/src/kitemviews/kitemliststyleoption.cpp b/src/kitemviews/kitemliststyleoption.cpp index bcfb86064b..84054aaacc 100644 --- a/src/kitemviews/kitemliststyleoption.cpp +++ b/src/kitemviews/kitemliststyleoption.cpp @@ -35,21 +35,6 @@ KItemListStyleOption::KItemListStyleOption() : { } -KItemListStyleOption::KItemListStyleOption(const KItemListStyleOption& other) : - rect(other.rect), - font(other.font), - fontMetrics(other.fontMetrics), - palette(other.palette), - padding(other.padding), - horizontalMargin(other.horizontalMargin), - verticalMargin(other.verticalMargin), - iconSize(other.iconSize), - extendedSelectionRegion(other.extendedSelectionRegion), - maxTextLines(other.maxTextLines), - maxTextWidth(other.maxTextWidth) -{ -} - KItemListStyleOption::~KItemListStyleOption() { } diff --git a/src/kitemviews/kitemliststyleoption.h b/src/kitemviews/kitemliststyleoption.h index 93aafac1f5..381f4bbe50 100644 --- a/src/kitemviews/kitemliststyleoption.h +++ b/src/kitemviews/kitemliststyleoption.h @@ -31,7 +31,6 @@ class DOLPHIN_EXPORT KItemListStyleOption { public: KItemListStyleOption(); - KItemListStyleOption(const KItemListStyleOption& other); virtual ~KItemListStyleOption(); QRect rect; @@ -48,8 +47,6 @@ public: bool operator==(const KItemListStyleOption& other) const; bool operator!=(const KItemListStyleOption& other) const; - - }; #endif