mirror of
https://invent.kde.org/system/dolphin
synced 2024-10-28 03:21:56 +00:00
Fix an issue with a new tab focus
Summary: When opening a new tab in the background and switching to that tab the focus is set on the location bar instead of the files view. If you switch back to the original tab and then to the new tab again focus will be set on the files view. The problem is caused by creation of //DolphinTabPage// in an active state which leads to skipping by //return// in //DolphinView::setActive(bool active)// without setting the focus on the view. This patch fixes this defect. BUG: 407604 FIXED-IN: 19.11.80 Test Plan: 1. Open a new tab in the background 2. Switch to the new tab 3. Check current focus widget by the up/down arrows on the keyboard with and without changes. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: ngraham Subscribers: anthonyfieroni, ngraham, elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22386
This commit is contained in:
parent
e5c698f295
commit
9d4c75d2f7
|
@ -161,6 +161,7 @@ void DolphinTabWidget::openNewTab(const QUrl& primaryUrl, const QUrl& secondaryU
|
|||
QWidget* focusWidget = QApplication::focusWidget();
|
||||
|
||||
DolphinTabPage* tabPage = new DolphinTabPage(primaryUrl, secondaryUrl, this);
|
||||
tabPage->setActive(false);
|
||||
tabPage->setPlacesSelectorVisible(m_placesSelectorVisible);
|
||||
connect(tabPage, &DolphinTabPage::activeViewChanged,
|
||||
this, &DolphinTabWidget::activeViewChanged);
|
||||
|
|
Loading…
Reference in a new issue