From 9581a2732829cde1770441da3e3a57ca2ff3d843 Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Mon, 17 Dec 2018 22:51:42 +0100 Subject: [PATCH] Make RenameDialog modal again. Summary: The rename dialog used to be modal, but commit 828ba8902ce16819a385832b487e60eab36e54ca changed the behavior without really explaining why. Test Plan: disable inline renaming and rename something. Reviewers: #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17621 --- src/panels/folders/folderspanel.cpp | 4 +--- src/views/dolphinview.cpp | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/panels/folders/folderspanel.cpp b/src/panels/folders/folderspanel.cpp index 7a0b4b6b24..c98a2150cf 100644 --- a/src/panels/folders/folderspanel.cpp +++ b/src/panels/folders/folderspanel.cpp @@ -105,9 +105,7 @@ void FoldersPanel::rename(const KFileItem& item) m_controller->view()->editRole(index, "text"); } else { RenameDialog* dialog = new RenameDialog(this, KFileItemList() << item); - dialog->show(); - dialog->raise(); - dialog->activateWindow(); + dialog->open(); } } diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index 617c41acec..e3a986e118 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -638,9 +638,7 @@ void DolphinView::renameSelectedItems() RenameDialog* dialog = new RenameDialog(this, items); connect(dialog, &RenameDialog::renamingFinished, this, &DolphinView::slotRenameDialogRenamingFinished); - dialog->show(); - dialog->raise(); - dialog->activateWindow(); + dialog->open(); } // Assure that the current index remains visible when KFileItemModel