From 91709cb6fe61dbec300a8d51d3064a57d9f63f37 Mon Sep 17 00:00:00 2001 From: Alexander Saoutkin Date: Sun, 25 Aug 2019 10:26:39 -0600 Subject: [PATCH] Fixing bug where split view opens with no URLs Summary: BUG: 411193 FIXED-IN: 19.08.1 Test Plan: Reproduce steps as given in bug report. Observe the exected result. Used qdbusviewer and ShowFolders method to observe that no regressions occured in the "open new folders in tabs" feature. Reviewers: elvisangelaccio, ngraham Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23445 --- src/main.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index 10adfc638b..8981b54bce 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -142,11 +142,6 @@ extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv) return app.exec(); } - if (splitView && urls.size() < 2) { - // Split view does only make sense if we have at least 2 URLs - urls.append(urls.last()); - } - if (!parser.isSet(QStringLiteral("new-window"))) { if (Dolphin::attachToExistingInstance(urls, openFiles, splitView)) { // Successfully attached to existing instance of Dolphin @@ -159,6 +154,11 @@ extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv) urls.append(Dolphin::homeUrl()); } + if (splitView && urls.size() < 2) { + // Split view does only make sense if we have at least 2 URLs + urls.append(urls.last()); + } + DolphinMainWindow* mainWindow = new DolphinMainWindow(); if (openFiles) {