kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-20 08:51:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Factorize some code

Browse source 
svn path=/trunk/kdebase/libkonq/; revision=348979
This commit is contained in:
David Faure 2004-09-24 07:56:05 +00:00
parent 6c1d3b8248
commit 8a368c03db
2 changed files with 15 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
lib/konq/konq_popupmenu.cc
View file

@ -47,9 +47,10 @@
/*
Test cases:
iconview background
iconview file (with and without servicemenus)
iconview directory
iconview file: background
iconview file: file (with and without servicemenus)
iconview file: directory
iconview remote protocol (e.g. ftp: or fish:)
sidebar directory tree
khtml background
khtml link
@ -889,24 +890,7 @@ void KonqPopupMenu::setup(KonqPopupFlags kpf)
void KonqPopupMenu::slotOpenShareFileDialog()
{
//kdDebug()<<"KonqPopupMenu::slotOpenShareFileDialog()\n";
// It may be that the kfileitem was created by hand
// (see KonqKfmIconView::slotMouseButtonPressed)
// In that case, we can get more precise info in the properties
// (like permissions) if we stat the URL.
if ( m_lstItems.count() == 1 )
{
KFileItem * item = m_lstItems.first();
if (item->entry().count() == 0) // this item wasn't listed by a slave
{
// KPropertiesDialog will use stat to get more info on the file
KPropertiesDialog*dlg= new KPropertiesDialog( item->url(), d->m_parentWidget );
dlg->showFileSharingPage();
return;
}
}
KPropertiesDialog*dlg=new KPropertiesDialog( m_lstItems, d->m_parentWidget );
KPropertiesDialog* dlg = showPropertiesDialog();
dlg->showFileSharingPage();
}
@ -916,7 +900,7 @@ KonqPopupMenu::~KonqPopupMenu()
delete m_factory;
delete m_builder;
delete d;
kdDebug(1203) << "~KonqPopupMenu leave" << endl;
//kdDebug(1203) << "~KonqPopupMenu leave" << endl;
}
void KonqPopupMenu::setURLTitle( const QString& urlTitle )
@ -1001,6 +985,11 @@ void KonqPopupMenu::slotPopupMimeType()
}
void KonqPopupMenu::slotPopupProperties()
{
(void)showPropertiesDialog();
}
KPropertiesDialog* KonqPopupMenu::showPropertiesDialog()
{
// It may be that the kfileitem was created by hand
// (see KonqKfmIconView::slotMouseButtonPressed)
@ -1012,11 +1001,10 @@ void KonqPopupMenu::slotPopupProperties()
if (item->entry().count() == 0) // this item wasn't listed by a slave
{
// KPropertiesDialog will use stat to get more info on the file
(void) new KPropertiesDialog( item->url(), d->m_parentWidget );
return;
return new KPropertiesDialog( item->url(), d->m_parentWidget );
}
}
(void) new KPropertiesDialog( m_lstItems, d->m_parentWidget );
return new KPropertiesDialog( m_lstItems, d->m_parentWidget );
}
KAction *KonqPopupMenu::action( const QDomElement &element ) const

2
lib/konq/konq_popupmenu.h
View file

@ -38,6 +38,7 @@
typedef QValueList<KDEDesktopMimeType::Service> ServiceList;
class KPropertiesDialog;
class KNewMenu;
class KService;
class KonqPopupMenuPlugin;
@ -177,6 +178,7 @@ private:
int insertServicesSubmenus(const QMap<QString, ServiceList>& list, QDomElement& menu, bool isBuiltin);
int insertServices(const ServiceList& list, QDomElement& menu, bool isBuiltin);
bool KIOSKAuthorizedAction(KConfig& cfg);
KPropertiesDialog* showPropertiesDialog();
class KonqPopupMenuPrivate;
KonqPopupMenuPrivate *d;