kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-19 16:31:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused argument

Browse source 
I saw a runtime warning from QMetaObject::invokeMethod() that KJob* is
not a registered type. Since we don't use that argument in
slotPreviewJobFinished(KJob*) anyway, it's best to remove it.
This commit is contained in:
Frank Reininghaus 2013-06-07 09:22:32 +02:00
parent 06ffc25dd7
commit 8989317ab0
2 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp
View file

@ -611,10 +611,8 @@ void KFileItemModelRolesUpdater::slotPreviewFailed(const KFileItem& item)
}
}
void KFileItemModelRolesUpdater::slotPreviewJobFinished(KJob* job)
void KFileItemModelRolesUpdater::slotPreviewJobFinished()
{
Q_UNUSED(job);
m_previewJob = 0;
if (m_state != PreviewJobRunning) {
@ -912,7 +910,7 @@ void KFileItemModelRolesUpdater::startPreviewJob(const KFileItemList items)
m_state = PreviewJobRunning;
if (items.isEmpty()) {
QMetaObject::invokeMethod(this, "slotPreviewJobFinished", Qt::QueuedConnection, Q_ARG(KJob*, 0));
QTimer::singleShot(0, this, SLOT(slotPreviewJobFinished()));
return;
}
@ -977,7 +975,7 @@ void KFileItemModelRolesUpdater::startPreviewJob(const KFileItemList items)
connect(job, SIGNAL(failed(KFileItem)),
this, SLOT(slotPreviewFailed(KFileItem)));
connect(job, SIGNAL(finished(KJob*)),
this, SLOT(slotPreviewJobFinished(KJob*)));
this, SLOT(slotPreviewJobFinished()));
m_previewJob = job;
}
@ -1282,7 +1280,7 @@ void KFileItemModelRolesUpdater::killPreviewJob()
disconnect(m_previewJob, SIGNAL(failed(KFileItem)),
this, SLOT(slotPreviewFailed(KFileItem)));
disconnect(m_previewJob, SIGNAL(finished(KJob*)),
this, SLOT(slotPreviewJobFinished(KJob*)));
this, SLOT(slotPreviewJobFinished()));
m_previewJob->kill();
m_previewJob = 0;
m_pendingPreviewItems.clear();

2
dolphin/src/kitemviews/kfileitemmodelrolesupdater.h
View file

@ -185,7 +185,7 @@ private slots:
* the changed items otherwise. *
* @see startPreviewJob()
*/
void slotPreviewJobFinished(KJob* job);
void slotPreviewJobFinished();
/**
* Resolves the sort role of the next item in m_pendingSortRole, applies it