From 6de7aae20ad5110fb0615857328bd26ceee55ccc Mon Sep 17 00:00:00 2001 From: l10n daemon script Date: Sun, 23 Dec 2018 06:55:00 +0100 Subject: [PATCH 1/4] GIT_SILENT made messages (after extraction) --- src/org.kde.dolphin.appdata.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/org.kde.dolphin.appdata.xml b/src/org.kde.dolphin.appdata.xml index 1d293fa273..2c01778154 100644 --- a/src/org.kde.dolphin.appdata.xml +++ b/src/org.kde.dolphin.appdata.xml @@ -536,6 +536,7 @@ File management in Dolphin Gestión de archivos en Dolphin Tiedostonhallinta Dolphinissa + Gestion de fichiers dans Dophin Xestión de ficheiros en Dolphin Gestione dei file in Dolphin Bestandsbeheer in Dolphin From f0e66d34655d5e1eecaed2cab7fd07432aecb714 Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Mon, 31 Dec 2018 00:21:25 +0100 Subject: [PATCH 2/4] Add failing test case for bug #402641 CCBUG: 402641 --- src/tests/dolphinmainwindowtest.cpp | 32 +++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/src/tests/dolphinmainwindowtest.cpp b/src/tests/dolphinmainwindowtest.cpp index 673bccd440..d7ff1fb542 100644 --- a/src/tests/dolphinmainwindowtest.cpp +++ b/src/tests/dolphinmainwindowtest.cpp @@ -40,6 +40,7 @@ private slots: void testActiveViewAfterClosingSplitView_data(); void testActiveViewAfterClosingSplitView(); void testUpdateWindowTitleAfterClosingSplitView(); + void testUpdateWindowTitleAfterChangingSplitView(); void testOpenInNewTabTitle(); void testNewFileMenuEnabled_data(); void testNewFileMenuEnabled(); @@ -175,6 +176,37 @@ void DolphinMainWindowTest::testUpdateWindowTitleAfterClosingSplitView() QCOMPARE(currentUrlChangedSpy.count(), 1); } +// Test case for bug #402641 +void DolphinMainWindowTest::testUpdateWindowTitleAfterChangingSplitView() +{ + m_mainWindow->openDirectories({ QUrl::fromLocalFile(QDir::homePath()) }, false); + m_mainWindow->show(); + QVERIFY(QTest::qWaitForWindowExposed(m_mainWindow.data())); + QVERIFY(m_mainWindow->isVisible()); + + auto tabWidget = m_mainWindow->findChild("tabWidget"); + QVERIFY(tabWidget); + + // Open split view. + m_mainWindow->actionCollection()->action(QStringLiteral("split_view"))->trigger(); + QVERIFY(tabWidget->currentTabPage()->splitViewEnabled()); + + auto leftViewContainer = tabWidget->currentTabPage()->primaryViewContainer(); + auto rightViewContainer = tabWidget->currentTabPage()->secondaryViewContainer(); + + // Store old window title. + const auto oldTitle = m_mainWindow->windowTitle(); + + // Change URL in the right view and make sure the title gets updated. + rightViewContainer->setUrl(QUrl::fromLocalFile(QDir::rootPath())); + QVERIFY(m_mainWindow->windowTitle() != oldTitle); + + // Activate back the left view and check whether the old title gets restored. + leftViewContainer->setActive(true); + QEXPECT_FAIL("", "Bug #402641", Continue); + QCOMPARE(m_mainWindow->windowTitle(), oldTitle); +} + // Test case for bug #397910 void DolphinMainWindowTest::testOpenInNewTabTitle() { From 393358392590ddda726d7d1f673e9dc8213f2a37 Mon Sep 17 00:00:00 2001 From: Christoph Feck Date: Thu, 3 Jan 2019 22:47:46 +0100 Subject: [PATCH 3/4] GIT_SILENT Upgrade KDE Applications version to 18.12.1. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index d52731e964..bc4d6b84f8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.0) # KDE Application Version, managed by release script set (KDE_APPLICATIONS_VERSION_MAJOR "18") set (KDE_APPLICATIONS_VERSION_MINOR "12") -set (KDE_APPLICATIONS_VERSION_MICRO "0") +set (KDE_APPLICATIONS_VERSION_MICRO "1") set (KDE_APPLICATIONS_VERSION "${KDE_APPLICATIONS_VERSION_MAJOR}.${KDE_APPLICATIONS_VERSION_MINOR}.${KDE_APPLICATIONS_VERSION_MICRO}") project(Dolphin VERSION ${KDE_APPLICATIONS_VERSION}) From 1cde03cdfe66f455e115a373878524b227fadc4e Mon Sep 17 00:00:00 2001 From: "Friedrich W. H. Kossebau" Date: Fri, 4 Jan 2019 22:22:07 +0100 Subject: [PATCH 4/4] Use https over http for homepage url --- src/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main.cpp b/src/main.cpp index 09d3fe7531..08405d0073 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -72,7 +72,7 @@ extern "C" Q_DECL_EXPORT int kdemain(int argc, char **argv) i18nc("@title", "File Manager"), KAboutLicense::GPL, i18nc("@info:credit", "(C) 2006-2018 Peter Penz, Frank Reininghaus, Emmanuel Pescosta and Elvis Angelaccio")); - aboutData.setHomepage(QStringLiteral("http://dolphin.kde.org")); + aboutData.setHomepage(QStringLiteral("https://dolphin.kde.org")); aboutData.addAuthor(i18nc("@info:credit", "Elvis Angelaccio"), i18nc("@info:credit", "Maintainer (since 2018) and developer"), QStringLiteral("elvis.angelaccio@kde.org"));