From 40bc9531c576848cbafc637a26a66473fcbbc85d Mon Sep 17 00:00:00 2001 From: Christoph Feck Date: Fri, 9 Aug 2019 01:59:49 +0200 Subject: [PATCH 1/2] GIT_SILENT Upgrade KDE Applications version to 19.08.0. --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 838ca1445c..3237a03a28 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -2,8 +2,8 @@ cmake_minimum_required(VERSION 3.0) # KDE Application Version, managed by release script set (KDE_APPLICATIONS_VERSION_MAJOR "19") -set (KDE_APPLICATIONS_VERSION_MINOR "07") -set (KDE_APPLICATIONS_VERSION_MICRO "90") +set (KDE_APPLICATIONS_VERSION_MINOR "08") +set (KDE_APPLICATIONS_VERSION_MICRO "0") set (KDE_APPLICATIONS_VERSION "${KDE_APPLICATIONS_VERSION_MAJOR}.${KDE_APPLICATIONS_VERSION_MINOR}.${KDE_APPLICATIONS_VERSION_MICRO}") project(Dolphin VERSION ${KDE_APPLICATIONS_VERSION}) From aeba47648d8b4b43ad0f8e237cfc95b8a4bd60ac Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio Date: Sun, 11 Aug 2019 12:10:43 +0200 Subject: [PATCH 2/2] Do not match daemonized dolphin instances: part 2 Summary: `dolphin --daemon` does not have the `/dolphin/Dolphin_1` dbus path, because it doesn't have any DolphinMainWindow. Checking if the QDBusInterface is valid is not enough, we also need to look for dbus errors. This should have been part of commit 7df5fc8edb54153f. Not sure how I missed it. BUG: 408244 FIXED-IN: 19.08.0 Test Plan: 1. Make sure the new "Open new folders in tabs" setting is enabled. 2. Run `dolphin --deamon` and make sure is the only dolphin process around. 3. Call the `org.freedesktop.FileManager1.ShowFolders` method from QDbusViewer. Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D23087 --- src/global.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/global.cpp b/src/global.cpp index 4547faced4..21660a8281 100644 --- a/src/global.cpp +++ b/src/global.cpp @@ -90,7 +90,7 @@ bool Dolphin::attachToExistingInstance(const QList& inputUrls, bool openFi QStringLiteral("/dolphin/Dolphin_1"), QStringLiteral("org.kde.dolphin.MainWindow")) ); - if (preferred->isValid()) { + if (preferred->isValid() && !preferred->lastError().isValid()) { dolphinServices.append(qMakePair(preferred, QStringList() )); } }