kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-11-05 18:47:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

Simplify KItemListControllerTest::testKeyboardNavigation_data()

Browse source 
Function-static variables do not help much in a function which is
called exactly once.
This commit is contained in:
Frank Reininghaus 2012-02-04 17:29:09 +01:00
parent d9bc83e626
commit 847c8ebfd3
1 changed files with 22 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
dolphin/src/tests/kitemlistcontrollertest.cpp
View file

@ -192,41 +192,30 @@ void KItemListControllerTest::testKeyboardNavigation_data()
QTest::addColumn<bool>("groupingEnabled");
QTest::addColumn<QList<QPair<KeyPress, ViewState> > >("testList");
static QList<KFileItemListView::Layout> layoutList;
static QHash<KFileItemListView::Layout, QString> layoutNames;
if (layoutList.isEmpty()) {
layoutList.append(KFileItemListView::IconsLayout);
layoutNames[KFileItemListView::IconsLayout] = "Icons";
QList<KFileItemListView::Layout> layoutList;
QHash<KFileItemListView::Layout, QString> layoutNames;
layoutList.append(KFileItemListView::IconsLayout);
layoutNames[KFileItemListView::IconsLayout] = "Icons";
layoutList.append(KFileItemListView::CompactLayout);
layoutNames[KFileItemListView::CompactLayout] = "Compact";
layoutList.append(KFileItemListView::DetailsLayout);
layoutNames[KFileItemListView::DetailsLayout] = "Details";
layoutList.append(KFileItemListView::CompactLayout);
layoutNames[KFileItemListView::CompactLayout] = "Compact";
QList<KItemListController::SelectionBehavior> selectionBehaviorList;
QHash<KItemListController::SelectionBehavior, QString> selectionBehaviorNames;
selectionBehaviorList.append(KItemListController::NoSelection);
selectionBehaviorNames[KItemListController::NoSelection] = "NoSelection";
selectionBehaviorList.append(KItemListController::SingleSelection);
selectionBehaviorNames[KItemListController::SingleSelection] = "SingleSelection";
selectionBehaviorList.append(KItemListController::MultiSelection);
selectionBehaviorNames[KItemListController::MultiSelection] = "MultiSelection";
layoutList.append(KFileItemListView::DetailsLayout);
layoutNames[KFileItemListView::DetailsLayout] = "Details";
}
static QList<KItemListController::SelectionBehavior> selectionBehaviorList;
static QHash<KItemListController::SelectionBehavior, QString> selectionBehaviorNames;
if (selectionBehaviorList.isEmpty()) {
selectionBehaviorList.append(KItemListController::NoSelection);
selectionBehaviorNames[KItemListController::NoSelection] = "NoSelection";
selectionBehaviorList.append(KItemListController::SingleSelection);
selectionBehaviorNames[KItemListController::SingleSelection] = "SingleSelection";
selectionBehaviorList.append(KItemListController::MultiSelection);
selectionBehaviorNames[KItemListController::MultiSelection] = "MultiSelection";
}
static QList<bool> groupingEnabledList;
static QHash<bool, QString> groupingEnabledNames;
if (groupingEnabledList.isEmpty()) {
groupingEnabledList.append(false);
groupingEnabledNames[false] = "ungrouped";
groupingEnabledList.append(true);
groupingEnabledNames[true] = "grouping enabled";
}
QList<bool> groupingEnabledList;
QHash<bool, QString> groupingEnabledNames;
groupingEnabledList.append(false);
groupingEnabledNames[false] = "ungrouped";
groupingEnabledList.append(true);
groupingEnabledNames[true] = "grouping enabled";
foreach (KFileItemListView::Layout layout, layoutList) {
// The following settings depend on the layout.