From 7799bf1828b06ccbc1f688a2e4dc1bfa73c7c380 Mon Sep 17 00:00:00 2001 From: Frank Reininghaus Date: Fri, 28 Jun 2013 21:39:35 +0200 Subject: [PATCH] Fix memory leak in KFileItemModel Since m_pendingItemsToInsert is a list of pointers now (and not a list of KFileItems, as in the 4.10 branch), we have to delete all pointers when clearing or destroying the model. I think that no review request is necessary for this small and obvious change. CCMAIL: emmanuelpescosta099@gmail.com --- src/kitemviews/kfileitemmodel.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp index 3f19a20113..d174cf67fd 100644 --- a/src/kitemviews/kfileitemmodel.cpp +++ b/src/kitemviews/kfileitemmodel.cpp @@ -114,6 +114,7 @@ KFileItemModel::~KFileItemModel() { qDeleteAll(m_itemData); qDeleteAll(m_filteredItems.values()); + qDeleteAll(m_pendingItemsToInsert); } void KFileItemModel::loadDirectory(const KUrl& url) @@ -941,6 +942,8 @@ void KFileItemModel::slotClear() m_maximumUpdateIntervalTimer->stop(); m_resortAllItemsTimer->stop(); + + qDeleteAll(m_pendingItemsToInsert); m_pendingItemsToInsert.clear(); const int removedCount = m_itemData.count();