From 75679f628a4052908112846b1e66bb06d90c32eb Mon Sep 17 00:00:00 2001 From: Felix Ernst Date: Thu, 13 Oct 2022 22:13:00 +0200 Subject: [PATCH] Fix dismiss button in selection mode paste bar This one liner changes the signal that is emitted when the "Dismiss" button is pressed on the Paste bottom bar in selection mode. Before this commit, the `leaveSelectionModeRequested()` signal was used but it had no effect because technically the selection mode isn't active anymore when the paste bar is shown. Everything works as expected if instead `barVisibilityChangeRequested()` is emitted. --- src/selectionmode/bottombarcontentscontainer.cpp | 2 +- src/selectionmode/bottombarcontentscontainer.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/selectionmode/bottombarcontentscontainer.cpp b/src/selectionmode/bottombarcontentscontainer.cpp index 048e845a01..1634cf4c98 100644 --- a/src/selectionmode/bottombarcontentscontainer.cpp +++ b/src/selectionmode/bottombarcontentscontainer.cpp @@ -388,7 +388,7 @@ void BottomBarContentsContainer::addPasteContents() * So we first have to claim that we have different contents before requesting to leave selection mode. */ auto actuallyLeaveSelectionMode = [this]() { m_contents = BottomBar::Contents::CopyLocationContents; - Q_EMIT selectionModeLeavingRequested(); + Q_EMIT barVisibilityChangeRequested(false); }; auto *pasteButton = new QPushButton(this); diff --git a/src/selectionmode/bottombarcontentscontainer.h b/src/selectionmode/bottombarcontentscontainer.h index 6d44adf740..6cb66fcc1b 100644 --- a/src/selectionmode/bottombarcontentscontainer.h +++ b/src/selectionmode/bottombarcontentscontainer.h @@ -74,7 +74,7 @@ Q_SIGNALS: /** * When it does not make sense to show any specific contents, this signal is emitted and the receiver hides the bar. - * Later it might sense to show it again e.g. because the user selected items. Then this signal is used to request showing of the bar. + * Later it might make sense to show it again e.g. because the user selected items. Then this signal is used to request showing of the bar. */ void barVisibilityChangeRequested(bool visible);