Clean includes + port to QMenu

This commit is contained in:
Montel Laurent 2014-10-10 23:36:36 +02:00
parent 64bc639395
commit 6f6b1bbb69
28 changed files with 41 additions and 58 deletions

View file

@ -39,7 +39,7 @@
#include <KIO/JobUiDelegate> #include <KIO/JobUiDelegate>
#include <KJobUiDelegate> #include <KJobUiDelegate>
#include <KJobWidgets> #include <KJobWidgets>
#include <KMenu> #include <QMenu>
#include <KMenuBar> #include <KMenuBar>
#include <KMessageBox> #include <KMessageBox>
#include <KMimeTypeTrader> #include <KMimeTypeTrader>
@ -66,7 +66,7 @@ DolphinContextMenu::DolphinContextMenu(DolphinMainWindow* parent,
const QPoint& pos, const QPoint& pos,
const KFileItem& fileInfo, const KFileItem& fileInfo,
const KUrl& baseUrl) : const KUrl& baseUrl) :
KMenu(parent), QMenu(parent),
m_pos(pos), m_pos(pos),
m_mainWindow(parent), m_mainWindow(parent),
m_fileInfo(fileInfo), m_fileInfo(fileInfo),
@ -131,7 +131,7 @@ void DolphinContextMenu::keyPressEvent(QKeyEvent *ev)
if (m_removeAction && ev->key() == Qt::Key_Shift) { if (m_removeAction && ev->key() == Qt::Key_Shift) {
m_removeAction->update(); m_removeAction->update();
} }
KMenu::keyPressEvent(ev); QMenu::keyPressEvent(ev);
} }
void DolphinContextMenu::keyReleaseEvent(QKeyEvent *ev) void DolphinContextMenu::keyReleaseEvent(QKeyEvent *ev)
@ -139,7 +139,7 @@ void DolphinContextMenu::keyReleaseEvent(QKeyEvent *ev)
if (m_removeAction && ev->key() == Qt::Key_Shift) { if (m_removeAction && ev->key() == Qt::Key_Shift) {
m_removeAction->update(); m_removeAction->update();
} }
KMenu::keyReleaseEvent(ev); QMenu::keyReleaseEvent(ev);
} }
void DolphinContextMenu::openTrashContextMenu() void DolphinContextMenu::openTrashContextMenu()

View file

@ -24,7 +24,7 @@
#include <KService> #include <KService>
#include <KUrl> #include <KUrl>
#include <konq_copytomenu.h> #include <konq_copytomenu.h>
#include <KMenu> #include <QMenu>
#include <QObject> #include <QObject>
@ -50,7 +50,7 @@ class DolphinRemoveAction;
* - 'Actions': Contains all actions which can be applied to the * - 'Actions': Contains all actions which can be applied to the
* given item. * given item.
*/ */
class DolphinContextMenu : public KMenu class DolphinContextMenu : public QMenu
{ {
Q_OBJECT Q_OBJECT

View file

@ -65,7 +65,7 @@
#include <KInputDialog> #include <KInputDialog>
#include <KLocale> #include <KLocale>
#include <KProtocolManager> #include <KProtocolManager>
#include <KMenu> #include <QMenu>
#include <KMenuBar> #include <KMenuBar>
#include <KMessageBox> #include <KMessageBox>
#include <KFileItemListProperties> #include <KFileItemListProperties>
@ -797,10 +797,10 @@ void DolphinMainWindow::openContextMenu(const QPoint& pos,
void DolphinMainWindow::updateControlMenu() void DolphinMainWindow::updateControlMenu()
{ {
KMenu* menu = qobject_cast<KMenu*>(sender()); QMenu* menu = qobject_cast<QMenu*>(sender());
Q_ASSERT(menu); Q_ASSERT(menu);
// All actions get cleared by KMenu::clear(). The sub-menus are deleted // All actions get cleared by QMenu::clear(). The sub-menus are deleted
// by connecting to the aboutToHide() signal from the parent-menu. // by connecting to the aboutToHide() signal from the parent-menu.
menu->clear(); menu->clear();
@ -842,7 +842,7 @@ void DolphinMainWindow::updateControlMenu()
} }
addActionToMenu(ac->action("panels"), menu); addActionToMenu(ac->action("panels"), menu);
KMenu* locationBarMenu = new KMenu(i18nc("@action:inmenu", "Location Bar"), menu); QMenu* locationBarMenu = new QMenu(i18nc("@action:inmenu", "Location Bar"), menu);
locationBarMenu->addAction(ac->action("editable_location")); locationBarMenu->addAction(ac->action("editable_location"));
locationBarMenu->addAction(ac->action("replace_location")); locationBarMenu->addAction(ac->action("replace_location"));
menu->addMenu(locationBarMenu); menu->addMenu(locationBarMenu);
@ -850,8 +850,8 @@ void DolphinMainWindow::updateControlMenu()
menu->addSeparator(); menu->addSeparator();
// Add "Go" menu // Add "Go" menu
KMenu* goMenu = new KMenu(i18nc("@action:inmenu", "Go"), menu); QMenu* goMenu = new QMenu(i18nc("@action:inmenu", "Go"), menu);
connect(menu, &KMenu::aboutToHide, goMenu, &KMenu::deleteLater); connect(menu, &QMenu::aboutToHide, goMenu, &QMenu::deleteLater);
goMenu->addAction(ac->action(KStandardAction::name(KStandardAction::Back))); goMenu->addAction(ac->action(KStandardAction::name(KStandardAction::Back)));
goMenu->addAction(ac->action(KStandardAction::name(KStandardAction::Forward))); goMenu->addAction(ac->action(KStandardAction::name(KStandardAction::Forward)));
goMenu->addAction(ac->action(KStandardAction::name(KStandardAction::Up))); goMenu->addAction(ac->action(KStandardAction::name(KStandardAction::Up)));
@ -860,8 +860,8 @@ void DolphinMainWindow::updateControlMenu()
menu->addMenu(goMenu); menu->addMenu(goMenu);
// Add "Tool" menu // Add "Tool" menu
KMenu* toolsMenu = new KMenu(i18nc("@action:inmenu", "Tools"), menu); QMenu* toolsMenu = new QMenu(i18nc("@action:inmenu", "Tools"), menu);
connect(menu, &KMenu::aboutToHide, toolsMenu, &KMenu::deleteLater); connect(menu, &QMenu::aboutToHide, toolsMenu, &QMenu::deleteLater);
toolsMenu->addAction(ac->action("show_filter_bar")); toolsMenu->addAction(ac->action("show_filter_bar"));
toolsMenu->addAction(ac->action("compare_files")); toolsMenu->addAction(ac->action("compare_files"));
toolsMenu->addAction(ac->action("open_terminal")); toolsMenu->addAction(ac->action("open_terminal"));
@ -874,8 +874,8 @@ void DolphinMainWindow::updateControlMenu()
addActionToMenu(ac->action(KStandardAction::name(KStandardAction::Preferences)), menu); addActionToMenu(ac->action(KStandardAction::name(KStandardAction::Preferences)), menu);
// Add "Help" menu // Add "Help" menu
KMenu* helpMenu = new KMenu(i18nc("@action:inmenu", "Help"), menu); QMenu* helpMenu = new QMenu(i18nc("@action:inmenu", "Help"), menu);
connect(menu, &KMenu::aboutToHide, helpMenu, &KMenu::deleteLater); connect(menu, &QMenu::aboutToHide, helpMenu, &QMenu::deleteLater);
helpMenu->addAction(ac->action(KStandardAction::name(KStandardAction::HelpContents))); helpMenu->addAction(ac->action(KStandardAction::name(KStandardAction::HelpContents)));
helpMenu->addAction(ac->action(KStandardAction::name(KStandardAction::WhatsThis))); helpMenu->addAction(ac->action(KStandardAction::name(KStandardAction::WhatsThis)));
helpMenu->addSeparator(); helpMenu->addSeparator();
@ -1352,8 +1352,8 @@ void DolphinMainWindow::createControlButton()
m_controlButton->setPopupMode(QToolButton::InstantPopup); m_controlButton->setPopupMode(QToolButton::InstantPopup);
m_controlButton->setToolButtonStyle(toolBar()->toolButtonStyle()); m_controlButton->setToolButtonStyle(toolBar()->toolButtonStyle());
KMenu* controlMenu = new KMenu(m_controlButton); QMenu* controlMenu = new QMenu(m_controlButton);
connect(controlMenu, &KMenu::aboutToShow, this, &DolphinMainWindow::updateControlMenu); connect(controlMenu, &QMenu::aboutToShow, this, &DolphinMainWindow::updateControlMenu);
m_controlButton->setMenu(controlMenu); m_controlButton->setMenu(controlMenu);
@ -1381,7 +1381,7 @@ void DolphinMainWindow::deleteControlButton()
m_updateToolBarTimer = 0; m_updateToolBarTimer = 0;
} }
bool DolphinMainWindow::addActionToMenu(QAction* action, KMenu* menu) bool DolphinMainWindow::addActionToMenu(QAction* action, QMenu* menu)
{ {
Q_ASSERT(action); Q_ASSERT(action);
Q_ASSERT(menu); Q_ASSERT(menu);

View file

@ -448,7 +448,7 @@ private:
* case if it has not added already to the toolbar. * case if it has not added already to the toolbar.
* @return True if the action has been added to the menu. * @return True if the action has been added to the menu.
*/ */
bool addActionToMenu(QAction* action, KMenu* menu); bool addActionToMenu(QAction* action, QMenu* menu);
/** /**
* Connects the signals from the created DolphinView with * Connects the signals from the created DolphinView with

View file

@ -38,7 +38,7 @@
#include <KIO/NetAccess> #include <KIO/NetAccess>
#include <KToolInvocation> #include <KToolInvocation>
#include <kauthorized.h> #include <kauthorized.h>
#include <KMenu> #include <QMenu>
#include <KInputDialog> #include <KInputDialog>
#include <KProtocolInfo> #include <KProtocolInfo>
#include <kdeversion.h> #include <kdeversion.h>

View file

@ -22,7 +22,7 @@
#include <KLocalizedString> #include <KLocalizedString>
#include <KAcceleratorManager> #include <KAcceleratorManager>
#include <kio/global.h> #include <kio/global.h>
#include <KMenu> #include <QMenu>
DolphinRecentTabsMenu::DolphinRecentTabsMenu(QObject* parent) : DolphinRecentTabsMenu::DolphinRecentTabsMenu(QObject* parent) :
KActionMenu(QIcon::fromTheme("edit-undo"), i18n("Recently Closed Tabs"), parent) KActionMenu(QIcon::fromTheme("edit-undo"), i18n("Recently Closed Tabs"), parent)

View file

@ -22,7 +22,7 @@
#include <QTimer> #include <QTimer>
#include <QDragEnterEvent> #include <QDragEnterEvent>
#include <KLocalizedString> #include <KLocalizedString>
#include <KMenu> #include <QMenu>
#include <QIcon> #include <QIcon>
#include <KUrl> #include <KUrl>
@ -122,7 +122,7 @@ void DolphinTabBar::contextMenuEvent(QContextMenuEvent* event)
if (index >= 0) { if (index >= 0) {
// Tab context menu // Tab context menu
KMenu menu(this); QMenu menu(this);
QAction* newTabAction = menu.addAction(QIcon::fromTheme("tab-new"), i18nc("@action:inmenu", "New Tab")); QAction* newTabAction = menu.addAction(QIcon::fromTheme("tab-new"), i18nc("@action:inmenu", "New Tab"));
QAction* detachTabAction = menu.addAction(QIcon::fromTheme("tab-detach"), i18nc("@action:inmenu", "Detach Tab")); QAction* detachTabAction = menu.addAction(QIcon::fromTheme("tab-detach"), i18nc("@action:inmenu", "Detach Tab"));

View file

@ -20,15 +20,14 @@
***************************************************************************/ ***************************************************************************/
#include "filterbar.h" #include "filterbar.h"
#include <QBoxLayout>
#include <QKeyEvent> #include <QKeyEvent>
#include <QLabel> #include <QLabel>
#include <QToolButton> #include <QToolButton>
#include <QHBoxLayout>
#include <QIcon> #include <QIcon>
#include <KLocale> #include <KLocale>
#include <KLineEdit> #include <KLineEdit>
#include <KIconLoader>
FilterBar::FilterBar(QWidget* parent) : FilterBar::FilterBar(QWidget* parent) :
QWidget(parent) QWidget(parent)

View file

@ -32,7 +32,6 @@ class KItemListController;
class KItemListSmoothScroller; class KItemListSmoothScroller;
class KItemListView; class KItemListView;
class KItemModelBase; class KItemModelBase;
class QPropertyAnimation;
/** /**
* @brief Provides a QWidget based scrolling view for a KItemListController. * @brief Provides a QWidget based scrolling view for a KItemListController.

View file

@ -44,7 +44,6 @@ class QGraphicsSceneWheelEvent;
class QHideEvent; class QHideEvent;
class QInputMethodEvent; class QInputMethodEvent;
class QKeyEvent; class QKeyEvent;
class QMimeData;
class QShowEvent; class QShowEvent;
class QTransform; class QTransform;

View file

@ -44,7 +44,6 @@ class KItemListViewLayouter;
class KItemListWidget; class KItemListWidget;
class KItemListWidgetInformant; class KItemListWidgetInformant;
class KItemListWidgetCreatorBase; class KItemListWidgetCreatorBase;
class KItemListViewCreatorBase;
class QTimer; class QTimer;
/** /**

View file

@ -19,7 +19,7 @@
#include "kitemlistheaderwidget.h" #include "kitemlistheaderwidget.h"
#include <KMenu> #include <QMenu>
#include <kitemviews/kitemmodelbase.h> #include <kitemviews/kitemmodelbase.h>
#include <QApplication> #include <QApplication>

View file

@ -25,7 +25,6 @@
#include <QGraphicsWidget> #include <QGraphicsWidget>
#include <QPixmap> #include <QPixmap>
class QPropertyAnimation;
/** /**
* @brief Allows to toggle between the selected and unselected state of an item. * @brief Allows to toggle between the selected and unselected state of an item.

View file

@ -28,7 +28,6 @@
class KItemListView; class KItemListView;
class QGraphicsWidget; class QGraphicsWidget;
class QPointF;
class QPropertyAnimation; class QPropertyAnimation;
/** /**

View file

@ -25,7 +25,7 @@
#include <KIO/CopyJob> #include <KIO/CopyJob>
#include <KIO/DeleteJob> #include <KIO/DeleteJob>
#include <KIO/JobUiDelegate> #include <KIO/JobUiDelegate>
#include <KMenu> #include <QMenu>
#include <QIcon> #include <QIcon>
#include <KJobWidgets> #include <KJobWidgets>
#include <KSharedConfig> #include <KSharedConfig>
@ -58,7 +58,7 @@ TreeViewContextMenu::~TreeViewContextMenu()
void TreeViewContextMenu::open() void TreeViewContextMenu::open()
{ {
KMenu* popup = new KMenu(m_parent); QMenu* popup = new QMenu(m_parent);
if (!m_fileItem.isNull()) { if (!m_fileItem.isNull()) {
KFileItemListProperties capabilities(KFileItemList() << m_fileItem); KFileItemListProperties capabilities(KFileItemList() << m_fileItem);
@ -147,7 +147,7 @@ void TreeViewContextMenu::open()
} }
} }
QWeakPointer<KMenu> popupPtr = popup; QWeakPointer<QMenu> popupPtr = popup;
popup->exec(QCursor::pos()); popup->exec(QCursor::pos());
if (popupPtr.data()) { if (popupPtr.data()) {
popupPtr.data()->deleteLater(); popupPtr.data()->deleteLater();

View file

@ -29,7 +29,7 @@
#include <KIconLoader> #include <KIconLoader>
#include <QIcon> #include <QIcon>
#include <KLocale> #include <KLocale>
#include <KMenu> #include <QMenu>
#include <kseparator.h> #include <kseparator.h>
#include <KStringHandler> #include <KStringHandler>
@ -289,7 +289,7 @@ bool InformationPanelContent::eventFilter(QObject* obj, QEvent* event)
void InformationPanelContent::configureSettings(const QList<QAction*>& customContextMenuActions) void InformationPanelContent::configureSettings(const QList<QAction*>& customContextMenuActions)
{ {
KMenu popup(this); QMenu popup(this);
QAction* previewAction = popup.addAction(i18nc("@action:inmenu", "Preview")); QAction* previewAction = popup.addAction(i18nc("@action:inmenu", "Preview"));
previewAction->setIcon(QIcon::fromTheme("view-preview")); previewAction->setIcon(QIcon::fromTheme("view-preview"));

View file

@ -38,7 +38,7 @@
#include <kitemviews/kitemlistcontroller.h> #include <kitemviews/kitemlistcontroller.h>
#include <kitemviews/kitemlistselectionmanager.h> #include <kitemviews/kitemlistselectionmanager.h>
#include <kitemviews/kstandarditem.h> #include <kitemviews/kstandarditem.h>
#include <KMenu> #include <QMenu>
#include <KMessageBox> #include <KMessageBox>
#include <KNotification> #include <KNotification>
#include "placesitem.h" #include "placesitem.h"
@ -155,7 +155,7 @@ void PlacesPanel::slotItemContextMenuRequested(int index, const QPointF& pos)
return; return;
} }
KMenu menu(this); QMenu menu(this);
QAction* emptyTrashAction = 0; QAction* emptyTrashAction = 0;
QAction* addAction = 0; QAction* addAction = 0;
@ -221,7 +221,7 @@ void PlacesPanel::slotItemContextMenuRequested(int index, const QPointF& pos)
} }
menu.addSeparator(); menu.addSeparator();
KMenu* iconSizeSubMenu = new KMenu(i18nc("@item:inmenu", "Icon Size"), &menu); QMenu* iconSizeSubMenu = new QMenu(i18nc("@item:inmenu", "Icon Size"), &menu);
struct IconSizeInfo struct IconSizeInfo
{ {
@ -303,7 +303,7 @@ void PlacesPanel::slotItemContextMenuRequested(int index, const QPointF& pos)
void PlacesPanel::slotViewContextMenuRequested(const QPointF& pos) void PlacesPanel::slotViewContextMenuRequested(const QPointF& pos)
{ {
KMenu menu(this); QMenu menu(this);
QAction* addAction = menu.addAction(QIcon::fromTheme("document-new"), i18nc("@item:inmenu", "Add Entry...")); QAction* addAction = menu.addAction(QIcon::fromTheme("document-new"), i18nc("@item:inmenu", "Add Entry..."));

View file

@ -24,7 +24,6 @@
#include <QList> #include <QList>
#include <QListWidget> #include <QListWidget>
class QCheckBox;
/** /**
* @brief Dialog for changing the additional information shown in the view. * @brief Dialog for changing the additional information shown in the view.

View file

@ -23,7 +23,6 @@
#include <settings/settingspagebase.h> #include <settings/settingspagebase.h>
#include <KUrl> #include <KUrl>
class KComboBox;
class QCheckBox; class QCheckBox;
class QLabel; class QLabel;
class QRadioButton; class QRadioButton;

View file

@ -24,8 +24,6 @@
#include <QMap> #include <QMap>
#include <QString> #include <QString>
class QCheckBox;
class QGroupBox;
class QListView; class QListView;
class QSortFilterProxyModel; class QSortFilterProxyModel;
class ServiceModel; class ServiceModel;

View file

@ -24,7 +24,7 @@
#include <KIconLoader> #include <KIconLoader>
#include <QIcon> #include <QIcon>
#include <KLocale> #include <KLocale>
#include <KMenu> #include <QMenu>
#include <KVBox> #include <KVBox>
#include "statusbarspaceinfo.h" #include "statusbarspaceinfo.h"
@ -259,7 +259,7 @@ void DolphinStatusBar::contextMenuEvent(QContextMenuEvent* event)
{ {
Q_UNUSED(event); Q_UNUSED(event);
KMenu menu(this); QMenu menu(this);
QAction* showZoomSliderAction = menu.addAction(i18nc("@action:inmenu", "Show Zoom Slider")); QAction* showZoomSliderAction = menu.addAction(i18nc("@action:inmenu", "Show Zoom Slider"));
showZoomSliderAction->setCheckable(true); showZoomSliderAction->setCheckable(true);

View file

@ -25,7 +25,6 @@
#include "libdolphin_export.h" #include "libdolphin_export.h"
class DolphinNewFileMenu; class DolphinNewFileMenu;
class KUrl;
/** /**
* @brief Allows to observe new file items that have been created * @brief Allows to observe new file items that have been created

View file

@ -35,7 +35,7 @@
#include <KMimeType> #include <KMimeType>
#include <KConfig> #include <KConfig>
#include <KCharsets> #include <KCharsets>
#include <KMenu> #include <QMenu>
#include <KProtocolInfo> #include <KProtocolInfo>
#include <KProtocolManager> #include <KProtocolManager>
#include <KIO/Scheduler> #include <KIO/Scheduler>

View file

@ -58,7 +58,7 @@
#include <KIO/PreviewJob> #include <KIO/PreviewJob>
#include <KIO/Paste> #include <KIO/Paste>
#include <KJob> #include <KJob>
#include <KMenu> #include <QMenu>
#include <KGlobal> #include <KGlobal>
#include <KMessageBox> #include <KMessageBox>
#include <KJobWidgets> #include <KJobWidgets>
@ -874,7 +874,7 @@ void DolphinView::slotHeaderContextMenuRequested(const QPointF& pos)
{ {
ViewProperties props(viewPropertiesUrl()); ViewProperties props(viewPropertiesUrl());
QPointer<KMenu> menu = new KMenu(QApplication::activeWindow()); QPointer<QMenu> menu = new QMenu(QApplication::activeWindow());
KItemListView* view = m_container->controller()->view(); KItemListView* view = m_container->controller()->view();
const QSet<QByteArray> visibleRolesSet = view->visibleRoles().toSet(); const QSet<QByteArray> visibleRolesSet = view->visibleRoles().toSet();

View file

@ -40,7 +40,6 @@
typedef KIO::FileUndoManager::CommandType CommandType; typedef KIO::FileUndoManager::CommandType CommandType;
class DolphinItemListView; class DolphinItemListView;
class KActionCollection;
class KFileItemModel; class KFileItemModel;
class KItemListContainer; class KItemListContainer;
class KItemModelBase; class KItemModelBase;

View file

@ -33,7 +33,7 @@
#include <KActionMenu> #include <KActionMenu>
#include <kitemviews/kfileitemmodel.h> #include <kitemviews/kfileitemmodel.h>
#include <KLocale> #include <KLocale>
#include <KMenu> #include <QMenu>
#include <KNewFileMenu> #include <KNewFileMenu>
#include <KSelectAction> #include <KSelectAction>
#include <KToggleAction> #include <KToggleAction>

View file

@ -28,7 +28,6 @@
class KFileItem; class KFileItem;
class KUrl; class KUrl;
class QDropEvent; class QDropEvent;
class QWidget;
class KonqOperations; class KonqOperations;
class LIBDOLPHINPRIVATE_EXPORT DragAndDropHelper class LIBDOLPHINPRIVATE_EXPORT DragAndDropHelper

View file

@ -25,11 +25,7 @@
#include <KFileItem> #include <KFileItem>
class DolphinModel;
class DolphinSortFilterProxyModel;
class FileMetaDataToolTip; class FileMetaDataToolTip;
class QAbstractItemView;
class QModelIndex;
class QTimer; class QTimer;
/** /**