kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't reinterpret_cast QEvent

Browse source 
We know that we'll be a `QHelpEvent` from `QEvent::ToolTip`, so do a
static_cast from the event handler (where it's obvious from context),
and then pass it along to `tryShowNameToolTip`.
This commit is contained in:
Kai Uwe Broulik 2022-07-05 13:18:45 +02:00
parent f3a0986b8b
commit 5ebc6b865d
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/views/dolphinview.cpp
View file

@ -925,7 +925,7 @@ bool DolphinView::eventFilter(QObject* watched, QEvent* event)
break;
case QEvent::ToolTip:
tryShowNameToolTip(event);
tryShowNameToolTip(static_cast<QHelpEvent*>(event));
default:
break;
@ -2196,11 +2196,10 @@ void DolphinView::updatePlaceholderLabel()
m_placeholderLabel->setVisible(true);
}
void DolphinView::tryShowNameToolTip(QEvent* event)
void DolphinView::tryShowNameToolTip(QHelpEvent* event)
{
if (!GeneralSettings::showToolTips() && m_mode == DolphinView::IconsView) {
QHelpEvent *hoverEvent = reinterpret_cast<QHelpEvent *>(event);
const std::optional<int> index = m_view->itemAt(hoverEvent->pos());
const std::optional<int> index = m_view->itemAt(event->pos());
if (!index.has_value()) {
return;
@ -2212,7 +2211,7 @@ void DolphinView::tryShowNameToolTip(QEvent* event)
if(isElided) {
const KFileItem item = m_model->fileItem(index.value());
const QString text = item.text();
const QPoint pos = mapToGlobal(hoverEvent->pos());
const QPoint pos = mapToGlobal(event->pos());
QToolTip::showText(pos, text);
}
}

3
src/views/dolphinview.h
View file

@ -35,6 +35,7 @@ class VersionControlObserver;
class ViewProperties;
class QLabel;
class QGraphicsSceneDragDropEvent;
class QHelpEvent;
class QRegularExpression;
/**
@ -862,7 +863,7 @@ private:
void updatePlaceholderLabel();
void tryShowNameToolTip(QEvent* event);
void tryShowNameToolTip(QHelpEvent* event);
private:
void updatePalette();