From 58d37b233177765b4908e2ab32413afe9fbd4da6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Fern=C3=A1ndez=20L=C3=B3pez?= Date: Sun, 16 Dec 2007 11:53:28 +0000 Subject: [PATCH] When collapsing nodes that made the scrollbar bigger, it didnt became smaller. I've debugged on event() method to find out which event was the one called. It seems QEvent::MetaCall is always called when we want and is not as impressive called as paintEvent(), so there we go. This will fix another problem that when a second expanded cached node should make the horizontal scrollbar bigger it didn't till the tree view lost the focus or was resized. Everything fixed :) CCMAIL: peter.penz@gmx.at svn path=/trunk/KDE/kdebase/apps/; revision=749049 --- src/sidebartreeview.cpp | 13 +++++++------ src/treeviewsidebarpage.cpp | 8 -------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/src/sidebartreeview.cpp b/src/sidebartreeview.cpp index d31300539f..9ab10a0b26 100644 --- a/src/sidebartreeview.cpp +++ b/src/sidebartreeview.cpp @@ -81,12 +81,10 @@ bool SidebarTreeView::event(QEvent* event) header()->hide(); } else if (event->type() == QEvent::UpdateRequest) { - resizeColumnToContents(DolphinModel::Name); - -// TODO: Remove this check when 4.3.2 is released and KDE requires it... this -// check avoids a division by zero happening on versions before 4.3.1. -// Right now KDE in theory can be shipped with Qt 4.3.0 and above. -// ereslibre + // TODO: Remove this check when 4.3.2 is released and KDE requires it... this + // check avoids a division by zero happening on versions before 4.3.1. + // Right now KDE in theory can be shipped with Qt 4.3.0 and above. + // ereslibre #if (QT_VERSION >= QT_VERSION_CHECK(4, 3, 2) || defined(QT_KDE_QT_COPY)) // a wheel movement will scroll 1 item if (model()->rowCount() > 0) { @@ -94,6 +92,9 @@ bool SidebarTreeView::event(QEvent* event) } #endif } + else if (event->type() == QEvent::MetaCall) { + resizeColumnToContents(DolphinModel::Name); + } return QTreeView::event(event); } diff --git a/src/treeviewsidebarpage.cpp b/src/treeviewsidebarpage.cpp index 0b28b97e88..82e2a0507f 100644 --- a/src/treeviewsidebarpage.cpp +++ b/src/treeviewsidebarpage.cpp @@ -192,8 +192,6 @@ void TreeViewSidebarPage::expandToLeafDir() QItemSelectionModel* selModel = m_treeView->selectionModel(); selModel->setCurrentIndex(proxyIndex, QItemSelectionModel::Select); - - m_treeView->resizeColumnToContents(DolphinModel::Name); } @@ -203,8 +201,6 @@ void TreeViewSidebarPage::loadSubTree() selModel->clearSelection(); if (m_leafDir.isParentOf(m_dirLister->url())) { - m_treeView->resizeColumnToContents(DolphinModel::Name); - // The leaf directory is not a child of the base URL, hence // no sub directory must be loaded or selected. return; @@ -222,8 +218,6 @@ void TreeViewSidebarPage::loadSubTree() // get invoked if the expanding has been finished. m_dolphinModel->expandToUrl(m_leafDir); } - - m_treeView->resizeColumnToContents(DolphinModel::Name); } void TreeViewSidebarPage::loadTree(const KUrl& url) @@ -246,8 +240,6 @@ void TreeViewSidebarPage::loadTree(const KUrl& url) } else { loadSubTree(); } - - m_treeView->resizeColumnToContents(DolphinModel::Name); } #include "treeviewsidebarpage.moc"