kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-11-05 18:47:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

avoid a potential stall: QComboBox::maxCount() -> QComboBox::count()

Browse source
This commit is contained in:
Ignat Semenov 2013-04-16 22:51:01 +04:00
parent 277ec25250
commit 574cd6de32
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plasma/applets/folderview/folderview.cpp
View file

@ -766,21 +766,21 @@ void FolderView::createConfigurationInterface(KConfigDialog *parent)
uiDisplay.numLinesEdit->setValue(m_numTextLines); uiDisplay.numLinesEdit->setValue(m_numTextLines);
uiDisplay.colorButton->setColor(textColor()); uiDisplay.colorButton->setColor(textColor());
for (int i = 0; i < uiDisplay.sortCombo->maxCount(); i++) { for (int i = 0; i < uiDisplay.sortCombo->count(); i++) {
if (m_sortColumn == uiDisplay.sortCombo->itemData(i).toInt()) { if (m_sortColumn == uiDisplay.sortCombo->itemData(i).toInt()) {
uiDisplay.sortCombo->setCurrentIndex(i); uiDisplay.sortCombo->setCurrentIndex(i);
break; break;
} }
} }
for (int i = 0; i < uiDisplay.flowCombo->maxCount(); i++) { for (int i = 0; i < uiDisplay.flowCombo->count(); i++) {
if (m_flow == uiDisplay.flowCombo->itemData(i).value<IconView::Flow>()) { if (m_flow == uiDisplay.flowCombo->itemData(i).value<IconView::Flow>()) {
uiDisplay.flowCombo->setCurrentIndex(i); uiDisplay.flowCombo->setCurrentIndex(i);
break; break;
} }
} }
for (int i = 0; i < uiFilter.filterCombo->maxCount(); i++) { for (int i = 0; i < uiFilter.filterCombo->count(); i++) {
if (m_filterType == uiFilter.filterCombo->itemData(i).value<ProxyModel::FilterMode>()) { if (m_filterType == uiFilter.filterCombo->itemData(i).value<ProxyModel::FilterMode>()) {
uiFilter.filterCombo->setCurrentIndex(i); uiFilter.filterCombo->setCurrentIndex(i);
break; break;
@ -1969,7 +1969,7 @@ void FolderView::indexesMoved(const QModelIndexList &indexes)
emit configNeedsSaving(); emit configNeedsSaving();
if (isUserConfiguring()) { if (isUserConfiguring()) {
for (int i = 0; i < uiDisplay.sortCombo->maxCount(); i++) { for (int i = 0; i < uiDisplay.sortCombo->count(); i++) {
if (m_sortColumn == uiDisplay.sortCombo->itemData(i).toInt()) { if (m_sortColumn == uiDisplay.sortCombo->itemData(i).toInt()) {
uiDisplay.sortCombo->setCurrentIndex(i); uiDisplay.sortCombo->setCurrentIndex(i);
break; break;