kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-12 12:54:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG: 191309

Browse source 
Don't show 'Add to Places' context-menu action for urls already in places.


svn path=/trunk/KDE/kdebase/apps/; revision=1048149
This commit is contained in:
Harsh Chouraria J 2009-11-12 20:22:22 +00:00
parent ebba84fbdd
commit 51dc542497
2 changed files with 31 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/dolphincontextmenu.cpp
View file

@ -124,6 +124,11 @@ void DolphinContextMenu::openTrashContextMenu()
QAction* addToPlacesAction = popup->addAction(KIcon("bookmark-new"),
i18nc("@action:inmenu Add current folder to places", "Add to Places"));
// Don't show if url is already in places
if (placeExists(m_mainWindow->activeViewContainer()->url())) {
addToPlacesAction->setVisible(false);
}
addCustomActions(popup);
QAction* propertiesAction = m_mainWindow->actionCollection()->action("properties");
@ -209,6 +214,10 @@ void DolphinContextMenu::openItemContextMenu()
if (m_fileInfo.isDir() && (m_selectedUrls.count() == 1)) {
addToPlacesAction = popup->addAction(KIcon("bookmark-new"),
i18nc("@action:inmenu Add selected folder to places", "Add to Places"));
// Don't show if url is already in places
if (placeExists(m_fileInfo.url())) {
addToPlacesAction->setVisible(false);
}
}
KonqMenuActions menuActions;
@ -288,6 +297,11 @@ void DolphinContextMenu::openViewportContextMenu()
QAction* addToPlacesAction = popup->addAction(KIcon("bookmark-new"),
i18nc("@action:inmenu Add current folder to places", "Add to Places"));
// Don't show if url is already in places
if (placeExists(m_mainWindow->activeViewContainer()->url())) {
addToPlacesAction->setVisible(false);
}
addCustomActions(popup);
QAction* propertiesAction = popup->addAction(i18nc("@action:inmenu", "Properties"));
@ -365,6 +379,21 @@ QString DolphinContextMenu::placesName(const KUrl& url) const
return name;
}
bool DolphinContextMenu::placeExists(const KUrl& url) const
{
const KFilePlacesModel* placesModel = DolphinSettings::instance().placesModel();
const int count = placesModel->rowCount();
for (int i = 0; i < count; ++i) {
const QModelIndex index = placesModel->index(i, 0);
if (url.equals(placesModel->url(index), KUrl::CompareWithoutTrailingSlash)) {
return true;
}
}
return false;
}
QAction* DolphinContextMenu::createPasteAction()
{
QAction* action = 0;

2
src/dolphincontextmenu.h
View file

@ -92,6 +92,8 @@ private:
*/
QString placesName(const KUrl& url) const;
bool placeExists(const KUrl& url) const;
QAction* createPasteAction();
private: