kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix title update when changing active split view

Browse source 
Summary:
The DolphinTabPage::activeViewUrlChanged signal triggers the title
update in DolphinMainWindow, which sets the new title from the
`m_activeViewContainer` instance.

This means we need to notify the main window that the active view
changed before telling it that the current url changed.

BUG: 402641
FIXED-IN: 18.12.1

Reviewers: #dolphin, rizzitello, ngraham

Reviewed By: #dolphin, rizzitello, ngraham

Subscribers: rizzitello, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D17881
This commit is contained in:
Elvis Angelaccio 2019-01-05 17:29:34 +01:00
parent 1cde03cdfe
commit 504db3f702
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/dolphintabpage.cpp
View file

@ -331,8 +331,8 @@ void DolphinTabPage::slotViewActivated()
this, &DolphinTabPage::slotViewUrlRedirection);
}
emit activeViewUrlChanged(activeViewContainer()->url());
emit activeViewChanged(activeViewContainer());
emit activeViewUrlChanged(activeViewContainer()->url());
}
void DolphinTabPage::slotViewUrlRedirection(const QUrl& oldUrl, const QUrl& newUrl)

1
src/tests/dolphinmainwindowtest.cpp
View file

@ -203,7 +203,6 @@ void DolphinMainWindowTest::testUpdateWindowTitleAfterChangingSplitView()
// Activate back the left view and check whether the old title gets restored.
leftViewContainer->setActive(true);
QEXPECT_FAIL("", "Bug #402641", Continue);
QCOMPARE(m_mainWindow->windowTitle(), oldTitle);
}