From 4d930992c47140bc47dac2ecfe0c4ca7eca33be7 Mon Sep 17 00:00:00 2001 From: Tem PQD Date: Thu, 29 Jun 2023 22:42:34 +0000 Subject: [PATCH] Use ellipsis everywhere instead of three dots Better for screen readers etc. --- src/dolphinmainwindow.cpp | 4 ++-- src/dolphinpart.cpp | 8 ++++---- src/dolphinviewcontainer.cpp | 6 +++--- src/filterbar/filterbar.cpp | 2 +- src/panels/folders/treeviewcontextmenu.cpp | 2 +- src/panels/information/informationpanel.cpp | 2 +- src/search/dolphinsearchbox.cpp | 2 +- src/settings/contextmenu/contextmenusettingspage.cpp | 4 ++-- src/settings/viewmodes/dolphinfontrequester.cpp | 2 +- src/views/dolphinview.cpp | 2 +- src/views/dolphinviewactionhandler.cpp | 4 ++-- src/views/versioncontrol/versioncontrolobserver.cpp | 2 +- 12 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index 219c9eb56f..fd1c6f0208 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -1651,7 +1651,7 @@ void DolphinMainWindow::setupActions() connect(moveToOtherViewAction, &QAction::triggered, this, &DolphinMainWindow::moveToInactiveSplitView); QAction *showFilterBar = actionCollection()->addAction(QStringLiteral("show_filter_bar")); - showFilterBar->setText(i18nc("@action:inmenu Tools", "Filter...")); + showFilterBar->setText(i18nc("@action:inmenu Tools", "Filter…")); showFilterBar->setToolTip(i18nc("@info:tooltip", "Show Filter Bar")); showFilterBar->setWhatsThis(xi18nc("@info:whatsthis", "This opens the " @@ -1675,7 +1675,7 @@ void DolphinMainWindow::setupActions() connect(toggleFilter, &QAction::triggered, this, &DolphinMainWindow::toggleFilterBar); QAction *searchAction = KStandardAction::find(this, &DolphinMainWindow::find, actionCollection()); - searchAction->setText(i18n("Search...")); + searchAction->setText(i18n("Search…")); searchAction->setToolTip(i18nc("@info:tooltip", "Search for files and folders")); searchAction->setWhatsThis(xi18nc("@info:whatsthis find", "This helps you " diff --git a/src/dolphinpart.cpp b/src/dolphinpart.cpp index 64c829c2d2..015e7e65cc 100644 --- a/src/dolphinpart.cpp +++ b/src/dolphinpart.cpp @@ -146,16 +146,16 @@ void DolphinPart::createActions() connect(m_newFileMenu->menu(), &QMenu::aboutToShow, this, &DolphinPart::updateNewMenu); QAction *editMimeTypeAction = actionCollection()->addAction(QStringLiteral("editMimeType")); - editMimeTypeAction->setText(i18nc("@action:inmenu Edit", "&Edit File Type...")); + editMimeTypeAction->setText(i18nc("@action:inmenu Edit", "&Edit File Type…")); connect(editMimeTypeAction, &QAction::triggered, this, &DolphinPart::slotEditMimeType); QAction *selectItemsMatching = actionCollection()->addAction(QStringLiteral("select_items_matching")); - selectItemsMatching->setText(i18nc("@action:inmenu Edit", "Select Items Matching...")); + selectItemsMatching->setText(i18nc("@action:inmenu Edit", "Select Items Matching…")); actionCollection()->setDefaultShortcut(selectItemsMatching, Qt::CTRL | Qt::Key_S); connect(selectItemsMatching, &QAction::triggered, this, &DolphinPart::slotSelectItemsMatchingPattern); QAction *unselectItemsMatching = actionCollection()->addAction(QStringLiteral("unselect_items_matching")); - unselectItemsMatching->setText(i18nc("@action:inmenu Edit", "Unselect Items Matching...")); + unselectItemsMatching->setText(i18nc("@action:inmenu Edit", "Unselect Items Matching…")); connect(unselectItemsMatching, &QAction::triggered, this, &DolphinPart::slotUnselectItemsMatchingPattern); KStandardAction::selectAll(m_view, &DolphinView::selectAll, actionCollection()); @@ -187,7 +187,7 @@ void DolphinPart::createActions() // Tools menu m_findFileAction = KStandardAction::find(this, &DolphinPart::slotFindFile, actionCollection()); - m_findFileAction->setText(i18nc("@action:inmenu Tools", "Find File...")); + m_findFileAction->setText(i18nc("@action:inmenu Tools", "Find File…")); #ifndef Q_OS_WIN if (KAuthorized::authorize(QStringLiteral("shell_access"))) { diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp index 5a4540786a..66a2f2dea9 100644 --- a/src/dolphinviewcontainer.cpp +++ b/src/dolphinviewcontainer.cpp @@ -634,7 +634,7 @@ void DolphinViewContainer::updateStatusBar() void DolphinViewContainer::updateDirectoryLoadingProgress(int percent) { if (m_statusBar->progressText().isEmpty()) { - m_statusBar->setProgressText(i18nc("@info:progress", "Loading folder...")); + m_statusBar->setProgressText(i18nc("@info:progress", "Loading folder…")); } m_statusBar->setProgress(percent); } @@ -642,7 +642,7 @@ void DolphinViewContainer::updateDirectoryLoadingProgress(int percent) void DolphinViewContainer::updateDirectorySortingProgress(int percent) { if (m_statusBar->progressText().isEmpty()) { - m_statusBar->setProgressText(i18nc("@info:progress", "Sorting...")); + m_statusBar->setProgressText(i18nc("@info:progress", "Sorting…")); } m_statusBar->setProgress(percent); } @@ -653,7 +653,7 @@ void DolphinViewContainer::slotDirectoryLoadingStarted() // Search KIO-slaves usually don't provide any progress information. Give // a hint to the user that a searching is done: updateStatusBar(); - m_statusBar->setProgressText(i18nc("@info", "Searching...")); + m_statusBar->setProgressText(i18nc("@info", "Searching…")); m_statusBar->setProgress(-1); } else { // Trigger an undetermined progress indication. The progress diff --git a/src/filterbar/filterbar.cpp b/src/filterbar/filterbar.cpp index e24025c5b9..08c44596f9 100644 --- a/src/filterbar/filterbar.cpp +++ b/src/filterbar/filterbar.cpp @@ -31,7 +31,7 @@ FilterBar::FilterBar(QWidget *parent) m_filterInput = new QLineEdit(this); m_filterInput->setLayoutDirection(Qt::LeftToRight); m_filterInput->setClearButtonEnabled(true); - m_filterInput->setPlaceholderText(i18n("Filter...")); + m_filterInput->setPlaceholderText(i18n("Filter…")); connect(m_filterInput, &QLineEdit::textChanged, this, &FilterBar::filterChanged); setFocusProxy(m_filterInput); diff --git a/src/panels/folders/treeviewcontextmenu.cpp b/src/panels/folders/treeviewcontextmenu.cpp index f6cafcac51..0e6260b3b8 100644 --- a/src/panels/folders/treeviewcontextmenu.cpp +++ b/src/panels/folders/treeviewcontextmenu.cpp @@ -75,7 +75,7 @@ void TreeViewContextMenu::open(const QPoint &pos) popup->addSeparator(); // insert 'Rename' - QAction *renameAction = new QAction(i18nc("@action:inmenu", "Rename..."), this); + QAction *renameAction = new QAction(i18nc("@action:inmenu", "Rename…"), this); renameAction->setEnabled(capabilities.supportsMoving()); renameAction->setIcon(QIcon::fromTheme(QStringLiteral("edit-rename"))); connect(renameAction, &QAction::triggered, this, &TreeViewContextMenu::rename); diff --git a/src/panels/information/informationpanel.cpp b/src/panels/information/informationpanel.cpp index 6060e2d8c8..55b734cf05 100644 --- a/src/panels/information/informationpanel.cpp +++ b/src/panels/information/informationpanel.cpp @@ -165,7 +165,7 @@ void InformationPanel::showContextMenu(const QPoint &pos) showHoveredAction->setCheckable(true); showHoveredAction->setChecked(InformationPanelSettings::showHovered()); - QAction *configureAction = popup.addAction(i18nc("@action:inmenu", "Configure...")); + QAction *configureAction = popup.addAction(i18nc("@action:inmenu", "Configure…")); configureAction->setIcon(QIcon::fromTheme(QStringLiteral("configure"))); if (m_inConfigurationMode) { configureAction->setEnabled(false); diff --git a/src/search/dolphinsearchbox.cpp b/src/search/dolphinsearchbox.cpp index b44f19092b..56b929c04f 100644 --- a/src/search/dolphinsearchbox.cpp +++ b/src/search/dolphinsearchbox.cpp @@ -327,7 +327,7 @@ void DolphinSearchBox::init() { // Create search box m_searchInput = new QLineEdit(this); - m_searchInput->setPlaceholderText(i18n("Search...")); + m_searchInput->setPlaceholderText(i18n("Search…")); m_searchInput->installEventFilter(this); m_searchInput->setClearButtonEnabled(true); m_searchInput->setFont(QFontDatabase::systemFont(QFontDatabase::GeneralFont)); diff --git a/src/settings/contextmenu/contextmenusettingspage.cpp b/src/settings/contextmenu/contextmenusettingspage.cpp index c363914d0d..52b2e3113c 100644 --- a/src/settings/contextmenu/contextmenusettingspage.cpp +++ b/src/settings/contextmenu/contextmenusettingspage.cpp @@ -66,7 +66,7 @@ ContextMenuSettingsPage::ContextMenuSettingsPage(QWidget *parent, const KActionC this); label->setWordWrap(true); m_searchLineEdit = new QLineEdit(this); - m_searchLineEdit->setPlaceholderText(i18nc("@label:textbox", "Search...")); + m_searchLineEdit->setPlaceholderText(i18nc("@label:textbox", "Search…")); connect(m_searchLineEdit, &QLineEdit::textChanged, this, [this](const QString &filter) { m_sortModel->setFilterFixedString(filter); }); @@ -93,7 +93,7 @@ ContextMenuSettingsPage::ContextMenuSettingsPage(QWidget *parent, const KActionC #ifndef Q_OS_WIN using NewStuffButton = KNSWidgets::Button; - auto *downloadButton = new NewStuffButton(i18nc("@action:button", "Download New Services..."), QStringLiteral("servicemenu.knsrc"), this); + auto *downloadButton = new NewStuffButton(i18nc("@action:button", "Download New Services…"), QStringLiteral("servicemenu.knsrc"), this); connect(downloadButton, &NewStuffButton::dialogFinished, this, [this](const auto &changedEntries) { if (!changedEntries.isEmpty()) { m_serviceModel->clear(); diff --git a/src/settings/viewmodes/dolphinfontrequester.cpp b/src/settings/viewmodes/dolphinfontrequester.cpp index 68ffa4f001..ffa460f425 100644 --- a/src/settings/viewmodes/dolphinfontrequester.cpp +++ b/src/settings/viewmodes/dolphinfontrequester.cpp @@ -29,7 +29,7 @@ DolphinFontRequester::DolphinFontRequester(QWidget *parent) m_modeCombo->addItem(i18nc("@item:inlistbox Font", "Custom Font")); connect(m_modeCombo, &QComboBox::activated, this, &DolphinFontRequester::changeMode); - m_chooseFontButton = new QPushButton(i18nc("@action:button Choose font", "Choose..."), this); + m_chooseFontButton = new QPushButton(i18nc("@action:button Choose font", "Choose…"), this); connect(m_chooseFontButton, &QPushButton::clicked, this, &DolphinFontRequester::openFontDialog); changeMode(m_modeCombo->currentIndex()); diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index 320524e651..1cc8a5f29d 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -2343,7 +2343,7 @@ void DolphinView::slotSwipeUp() void DolphinView::showLoadingPlaceholder() { - m_placeholderLabel->setText(i18n("Loading...")); + m_placeholderLabel->setText(i18n("Loading…")); m_placeholderLabel->setVisible(true); } diff --git a/src/views/dolphinviewactionhandler.cpp b/src/views/dolphinviewactionhandler.cpp index 32bec03df7..86ed05e971 100644 --- a/src/views/dolphinviewactionhandler.cpp +++ b/src/views/dolphinviewactionhandler.cpp @@ -77,7 +77,7 @@ void DolphinViewActionHandler::createActions(SelectionMode::ActionTextHelper *ac // This action doesn't appear in the GUI, it's for the shortcut only. // KNewFileMenu takes care of the GUI stuff. QAction *newDirAction = m_actionCollection->addAction(QStringLiteral("create_dir")); - newDirAction->setText(i18nc("@action", "Create Folder...")); + newDirAction->setText(i18nc("@action", "Create Folder…")); m_actionCollection->setDefaultShortcuts(newDirAction, KStandardShortcut::createFolder()); newDirAction->setIcon(QIcon::fromTheme(QStringLiteral("folder-new"))); newDirAction->setEnabled(false); // Will be enabled in slotWriteStateChanged(bool) if the current URL is writable @@ -327,7 +327,7 @@ void DolphinViewActionHandler::createActions(SelectionMode::ActionTextHelper *ac connect(showHiddenFiles, &KToggleAction::triggered, this, &DolphinViewActionHandler::toggleShowHiddenFiles); QAction *adjustViewProps = m_actionCollection->addAction(QStringLiteral("view_properties")); - adjustViewProps->setText(i18nc("@action:inmenu View", "Adjust View Display Style...")); + adjustViewProps->setText(i18nc("@action:inmenu View", "Adjust View Display Style…")); adjustViewProps->setIcon(QIcon::fromTheme(QStringLiteral("view-choose"))); adjustViewProps->setWhatsThis(i18nc("@info:whatsthis", "This opens a window " diff --git a/src/views/versioncontrol/versioncontrolobserver.cpp b/src/views/versioncontrol/versioncontrolobserver.cpp index 28fbbef1a4..428572f088 100644 --- a/src/views/versioncontrol/versioncontrolobserver.cpp +++ b/src/views/versioncontrol/versioncontrolobserver.cpp @@ -218,7 +218,7 @@ void VersionControlObserver::updateItemStates() if (!itemStates.isEmpty()) { if (!m_silentUpdate) { - Q_EMIT infoMessage(i18nc("@info:status", "Updating version information...")); + Q_EMIT infoMessage(i18nc("@info:status", "Updating version information…")); } m_updateItemStatesThread = new UpdateItemStatesThread(m_plugin, itemStates); connect(m_updateItemStatesThread, &UpdateItemStatesThread::finished, this, &VersionControlObserver::slotThreadFinished);